[GitHub] [airflow] mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator

2019-09-21 Thread GitBox 
mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator
URL: https://github.com/apache/airflow/pull/5914#issuecomment-533823603
 
 
   Travis is sad. Can you fix it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator

2019-08-26 Thread GitBox 
mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator
URL: https://github.com/apache/airflow/pull/5914#issuecomment-524862605
 
 
   I think, Airflow operators should be synchronous so that Airflow retrieves 
information about the success of the operation.  The operator should outsource 
the task, but also wait for the result to be completed. Otherwise, it will be 
difficult to use this operator in more complex processes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator

2019-08-26 Thread GitBox 
mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator
URL: https://github.com/apache/airflow/pull/5914#issuecomment-524808769
 
 
   One more small change.
   ``AWSLambdaInvokeFunctionOperator`` > ``AwsLambdaInvokeFunctionOperator``
   This will allow easier name reading.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator

2019-08-26 Thread GitBox 
mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator
URL: https://github.com/apache/airflow/pull/5914#issuecomment-524807101
 
 
   Operator suffix is required:  The service name should be a prefix.We expect 
operator names to be in the form of {ServiceName}{Behaviour}Operator for 
example  BigQueryExecuteQuery
   
   Example good operator’s names:
   BigQueryExecuteQuery, 
   BigQuerySubmitJob, 
   CloudVisionAddProductToProductSet
   
   Please look at: 
   
https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths
   
   My proposition: `AWSLambdaInvokeFunction`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator

2019-08-26 Thread GitBox 
mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator
URL: https://github.com/apache/airflow/pull/5914#issuecomment-524796942
 
 
   Quick comment.  The operator's name should describe the behavior, not just 
the name of the service. It should contain a verb.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services