[GitHub] [airflow] mik-laj commented on pull request #9354: Task logging handlers can provide custom log links

2020-07-01 Thread GitBox


mik-laj commented on pull request #9354:
URL: https://github.com/apache/airflow/pull/9354#issuecomment-652676572


   @turbaszek Do you want to add anything else?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [airflow] mik-laj commented on pull request #9354: Task logging handlers can provide custom log links

2020-06-28 Thread GitBox


mik-laj commented on pull request #9354:
URL: https://github.com/apache/airflow/pull/9354#issuecomment-650711579


   > thank you @mdediana , this is very useful. @mik-laj - is there a chance to 
get this in 1.10.11? :)
   
   I'm not the release manager, but I don't see any obstacles for it to be 
added to the next release.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [airflow] mik-laj commented on pull request #9354: Task logging handlers can provide custom log links

2020-06-28 Thread GitBox


mik-laj commented on pull request #9354:
URL: https://github.com/apache/airflow/pull/9354#issuecomment-650708973


   Can you add some documentation?  I am thinking about the new section - 
"External links" on the ["Writing 
logs"](https://airflow.readthedocs.io/en/latest/howto/write-logs.html#writing-logs)
 page. (This page has a bad title and I will try to change it to "Logging" soon)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [airflow] mik-laj commented on pull request #9354: Task logging handlers can provide custom log links

2020-06-20 Thread GitBox


mik-laj commented on pull request #9354:
URL: https://github.com/apache/airflow/pull/9354#issuecomment-646985000


   Yes. We should use TaskLogReader, if possible. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [airflow] mik-laj commented on pull request #9354: Task logging handlers can provide custom log links

2020-06-19 Thread GitBox


mik-laj commented on pull request #9354:
URL: https://github.com/apache/airflow/pull/9354#issuecomment-646878976


   TaskLogReader has been merged. Can you do.a rebase?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [airflow] mik-laj commented on pull request #9354: Task logging handlers can provide custom log links

2020-06-17 Thread GitBox


mik-laj commented on pull request #9354:
URL: https://github.com/apache/airflow/pull/9354#issuecomment-645643685


   Thank you very much. A very useful change. I look forward to further work 
results.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org