mik-laj commented on pull request #9618:
URL: https://github.com/apache/airflow/pull/9618#issuecomment-653176749
@vuppalli We don't need unit tests for DAG. We use them in the
documentation and in system tests. System tests are sufficient in this case.
Have the files that are needed to run the tests changed?
It is better if the contribution is small because then it is much easier to
review and merge in the project. In this case, I would prefer you to create a
new PR that will only contain documentation. If you need any changes that are
included in this PR then you can copy the changes from this PR and add
annotations in the PR title `[depends on ]`. Additionally, you can add a
note in the description, but not everyone reads the description of the changes.
Example:
```
Add guide for MLEngine [depends on #9618]
```
In order for this change to be merged, you must fix static check errors in
this change.
```
airflow/providers/google/cloud/example_dags/example_mlengine.py:29:89: W291
trailing whitespace
airflow/providers/google/cloud/example_dags/example_mlengine.py:30:80: W291
trailing whitespace
```
+ isort
For more information:
https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#id1
How do you like an internship at Google? Do you have any concerns about
contributing to Open Source? The community of this project is very open to new
contributors and interns. We currently have two active interns who contribute
to the project. If you would like to get more involved in this project, we'll
be happy to help. Apache Airflow is the core of the Cloud Composer service, so
contributions to this project will be appreciated by your company.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
