[GitHub] [airflow] nuclearpinguin commented on issue #6876: [AIRFLOW-6322] Add pytest.mark.slow marker

2019-12-23 Thread GitBox 
nuclearpinguin commented on issue #6876: [AIRFLOW-6322] Add pytest.mark.slow 
marker
URL: https://github.com/apache/airflow/pull/6876#issuecomment-568685481
 
 
   In my opinion we do not need this mark, as @potiuk mentioned, it's too 
ambiguous. Our top 5 slowest tests:
   ```
   == slowest 100 test durations 
==
   51.87s call 
tests/cli/commands/test_task_command.py::TestCliTaskBackfill::test_run_ignores_all_dependencies
   42.27s call 
tests/providers/amazon/aws/hooks/test_lambda_function.py::TestAwsLambdaHook::test_invoke_lambda_function
   38.90s call 
tests/test_impersonation.py::TestImpersonation::test_impersonation_subdag
   29.33s call 
tests/cli/commands/test_dag_command.py::TestCliDags::test_next_execution
   25.06s call 
tests/executors/test_celery_executor.py::TestCeleryExecutor::test_celery_integration_1_redis_redis_6379_0
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on issue #6876: [AIRFLOW-6322] Add pytest.mark.slow marker

2019-12-22 Thread GitBox 
nuclearpinguin commented on issue #6876: [AIRFLOW-6322] Add pytest.mark.slow 
marker
URL: https://github.com/apache/airflow/pull/6876#issuecomment-568244414
 
 
   What is the purpose of the marker? Currently we are not using any markers 
and introduction of this feature is [still 
discussed](https://lists.apache.org/list.html?d...@airflow.apache.org:lte=1M:markers).
 What we would like to work out is a set of markers that would allow us 
optimise time of CI without. @mik-laj @potiuk 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services