[GitHub] [airflow] nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-591092356 That was a big cycle removal. As discussed above, I don't know any other "session" in airflow so the `session.py` was quite intuitive. Do you think it would be worth to rename it to `db_session` ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-591091572 Yeah, so long that I at first edited your comment instead of reply :D This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-591091208 >And how did this reduce cyclic imports when utils.db imports the new file still?! That is not a problem. The main reason is that db.py imports all models, and plenty of models methods uses provide_session decorator. So every model imported db.provide_session. And db.py imported every model. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-569442066 > I restarted the latest build - it was failing with cassandra problem It's 3 time at this build. It makes me think there's something build / cache / machine dependent? Moreover we have the skip decorator... #6926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-569430073 > I rebased before opening a PR because I saw merge conflict ✅ > But i see some changes that are unrelated (and seem like reverting change from #6936. Unless it's github interface problem (seen that in the past) it is a bad conflict resolution. See here for example: [7be9e73#diff-c834cf104193b3b493916d646bc5d386R132](https://github.com/apache/airflow/commit/7be9e73b7af788847753933edbb49b28e7b40840#diff-c834cf104193b3b493916d646bc5d386R132) I rebased one more time and it seems to be ok. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-569427448 Regarding backward compatibility - it works only for `provide_session`, should I import `create_session` in `airflow.utils.db` to preserve full backward compatibility? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
nuclearpinguin commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-569427350 > But I think it needs rebase now after I merged #6936 as it contains some unrelated changes. > I rebased before opening a PR because I saw merge conflict ✅ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
