[GitHub] [airflow] o-nikolas commented on issue #27338: scripts/tools/initialize_virtualenv.py calling .exists() on str
o-nikolas commented on issue #27338: URL: https://github.com/apache/airflow/issues/27338#issuecomment-1295761268 > Hi @o-nikolas, seems like it was intended to be a `Path` object like you said, thank you for pointing that out and assigning me the ticket. I had a PR open with an approval but needed to move it to a branch in my fork so I opened another PR for this. Thanks for putting up a PR! I've reviewed it and left a comment :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] o-nikolas commented on issue #27338: scripts/tools/initialize_virtualenv.py calling .exists() on str
o-nikolas commented on issue #27338: URL: https://github.com/apache/airflow/issues/27338#issuecomment-1294435687 Thanks for the bug report @rkarish! I've assigned you the task since you checked that you're willing to submit a PR :smiley: > I believe this should be os.path.exists(airflow_home) instead Looking at the function stub for `clean_up_airflow_home` it looks like that code is expecting a `Path` object, but it's getting a string. So I think the better fix is to update the calling code to pass in a Path object instead of a string as it is now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
