[GitHub] [airflow] potiuk commented on a change in pull request #6952: [AIRFLOW-4445] mushroom cloud errors too verbose

2019-12-31 Thread GitBox
potiuk commented on a change in pull request #6952: [AIRFLOW-4445] mushroom 
cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#discussion_r362175923
 
 

 ##
 File path: airflow/config_templates/default_airflow.cfg
 ##
 @@ -324,6 +324,12 @@ error_logfile = -
 # Expose the configuration file in the web server
 expose_config = False
 
+# Expose hostname in the web server
+expose_hostname = True
 
 Review comment:
   @tooptoop4 -> would you be so kind to add this in the doc section as 
explained by @mik-laj ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] potiuk commented on a change in pull request #6952: [AIRFLOW-4445] mushroom cloud errors too verbose

2019-12-30 Thread GitBox
potiuk commented on a change in pull request #6952: [AIRFLOW-4445] mushroom 
cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#discussion_r362108536
 
 

 ##
 File path: airflow/config_templates/default_airflow.cfg
 ##
 @@ -324,6 +324,12 @@ error_logfile = -
 # Expose the configuration file in the web server
 expose_config = False
 
+# Expose hostname in the web server
+expose_hostname = True
 
 Review comment:
   @mik-laj - > where do you think the documentation should be added ? Maybe 
you can provide some pointers? Most of the config options are documented in 
comments of the default_airlfow.cfg. Any other specific place you think this 
documentation should be added (and where all the previous options are 
documented?)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services