[GitHub] [airflow] potiuk commented on a change in pull request #7456: [AIRFLOW-6817] [WIP] - Move airflow __init__.py imports to sub-packages
potiuk commented on a change in pull request #7456: [AIRFLOW-6817] [WIP] - Move airflow __init__.py imports to sub-packages URL: https://github.com/apache/airflow/pull/7456#discussion_r382725838 ## File path: airflow/__init__.py ## @@ -30,13 +30,8 @@ # pylint: disable=wrong-import-position from typing import Callable, Optional -from airflow import utils from airflow import settings from airflow import version -from airflow.utils.log.logging_mixin import LoggingMixin -from airflow.configuration import conf -from airflow.exceptions import AirflowException -from airflow.models.dag import DAG Review comment: But no matter what - if we do it, it should be separate PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7456: [AIRFLOW-6817] [WIP] - Move airflow __init__.py imports to sub-packages
potiuk commented on a change in pull request #7456: [AIRFLOW-6817] [WIP] - Move airflow __init__.py imports to sub-packages URL: https://github.com/apache/airflow/pull/7456#discussion_r382725105 ## File path: airflow/__init__.py ## @@ -30,13 +30,8 @@ # pylint: disable=wrong-import-position from typing import Callable, Optional -from airflow import utils from airflow import settings from airflow import version -from airflow.utils.log.logging_mixin import LoggingMixin -from airflow.configuration import conf -from airflow.exceptions import AirflowException -from airflow.models.dag import DAG Review comment: Something like that. I already had a PR for that (but I think I abandon it as there were many changes in the meantime #6696 ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7456: [AIRFLOW-6817] [WIP] - Move airflow __init__.py imports to sub-packages
potiuk commented on a change in pull request #7456: [AIRFLOW-6817] [WIP] - Move airflow __init__.py imports to sub-packages URL: https://github.com/apache/airflow/pull/7456#discussion_r382571494 ## File path: airflow/__init__.py ## @@ -30,13 +30,8 @@ # pylint: disable=wrong-import-position from typing import Callable, Optional -from airflow import utils from airflow import settings from airflow import version -from airflow.utils.log.logging_mixin import LoggingMixin -from airflow.configuration import conf -from airflow.exceptions import AirflowException -from airflow.models.dag import DAG Review comment: I think we also need to remove plugins eventually - but this is a good step (and it will be a bit more complex as we have to make sure plugins are initialized where needed). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7456: [AIRFLOW-6817] [WIP] - Move airflow __init__.py imports to sub-packages
potiuk commented on a change in pull request #7456: [AIRFLOW-6817] [WIP] - Move airflow __init__.py imports to sub-packages URL: https://github.com/apache/airflow/pull/7456#discussion_r382572247 ## File path: airflow/providers/qubole/example_dags/example_qubole_sensor.py ## @@ -0,0 +1,80 @@ +# Review comment: Unrelated? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services