[GitHub] [airflow] potiuk commented on issue #21348: Status of testing Providers that were prepared on February 05, 2022
potiuk commented on issue #21348: URL: https://github.com/apache/airflow/issues/21348#issuecomment-1031840031 As discussed above ^^ I will cancel the whole vote/release and will make an RC2 as soon as we release the conditonally working SQL renderer. Thanks @josh-fell for spotting this and raising it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21348: Status of testing Providers that were prepared on February 05, 2022
potiuk commented on issue #21348: URL: https://github.com/apache/airflow/issues/21348#issuecomment-1031838519 Yeah. It's easy enough to fix and I agree it's better. I think - due to the the number of those affected, it makes more sense to cancel the whole release and re-release all providers as RC2 with that fix to not mess with two releases. there are no super-urgent changes in this wave. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21348: Status of testing Providers that were prepared on February 05, 2022
potiuk commented on issue #21348: URL: https://github.com/apache/airflow/issues/21348#issuecomment-1031832322 The second option is to indeed drop all the "21237" providers an release them in RC2 with some "conditional" code that will check if the lexer is there. After thinking a bit I think that would be much "cleaner" solution and I am leaning towards this option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21348: Status of testing Providers that were prepared on February 05, 2022
potiuk commented on issue #21348: URL: https://github.com/apache/airflow/issues/21348#issuecomment-1031828515 Good point Josh. I think this one might be a bit tricky, I do not think it is "blocker" - the rendering is not nice but it does not "break" anything. However I thought it might be a nice way to incentivize people to migrate to 2.2.4 if we also cherry-pick the lexer to 2.2.4. Then we could telll them "migrate to 2.2.4 to get it nicer". This is a new feature - of course - so technically we shoud add it in 2.3.0. So I am a bit torn here. There are quite a number of those providers that are only released because of this renderer so we can easily skip them from this release and release them when we release 2.3.0 @jedcunningham @josh-fell @WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21348: Status of testing Providers that were prepared on February 05, 2022
potiuk commented on issue #21348: URL: https://github.com/apache/airflow/issues/21348#issuecomment-1031199630 > Hi @potiuk - It is my first time doing this testing: Are there any specific steps we follow? Good question. Depends on your "local" environment. But what I would do, is to use: 1. Start airflow 2.2.3 in breeze ``` ./breeze start-airflow --use-airflow-version 2.2.3 --backend postgres --db-reset --load-default-connections This will start our dockerized development environment with Airflow 2.2.3 installed and open 4 terminals: triggerer, scheduler, webserver and "bash console". 2. update the package to Rc: In the console: ``` pip install apache-airflow-providers-google==6.4.0rc1 ``` Then restarting scheduler/webserver (by Ctrl+C) followed by "up cursor" to go back and run previous command 3. Prepare a test dag using calendar api and run it For that you likely need to configure the "google_default_connection" to include your credentials. You can put your dags in "files/dags" folder of your Airlfow sources (the "files" folder is mounted to inside the docker) and they should be scanned/visible in webserver -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21348: Status of testing Providers that were prepared on February 05, 2022
potiuk commented on issue #21348: URL: https://github.com/apache/airflow/issues/21348#issuecomment-1030797255 I also removed some of the "no-need-to-test" changes :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #21348: Status of testing Providers that were prepared on February 05, 2022
potiuk commented on issue #21348: URL: https://github.com/apache/airflow/issues/21348#issuecomment-1030793431 Ok. Still worth testing Amazon changes on this version but I will remove Amazon + Docker and prepare RC2 right after we release all others and get fixes merged. Thanks @Ritika-Singhal @raphaelauv ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
