[GitHub] [airflow] potiuk edited a comment on issue #14128: Circular package imports in Airflow 2.0
potiuk edited a comment on issue #14128: URL: https://github.com/apache/airflow/issues/14128#issuecomment-811473508 https://stackoverflow.com/q/52474931/516701 gives a brief explanation about extras. I think it make sense to at least take a brief look if you are going to use them to understand what they are -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #14128: Circular package imports in Airflow 2.0
potiuk edited a comment on issue #14128: URL: https://github.com/apache/airflow/issues/14128#issuecomment-811389466 I don't belive it's an issue at all. Airflow is only officialy installable with `pip` and it works nicely when you run installation including constraints in the way described here: http://airflow.apache.org/docs/apache-airflow/stable/installation.html#installation-tools. This is the only installation method that brings repeatable results. Other methods might fail, but w are not supporting a full range of tools that behave differently than PIP. If you are using poetry, pipenv or other tools like that you are pretty much on your own. If this is not a 'serious issue' but "some way of using some tool', it's likely to be closed as invalid. So possibly starting discussion and discussing it might be a better way to go about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #14128: Circular package imports in Airflow 2.0
potiuk edited a comment on issue #14128: URL: https://github.com/apache/airflow/issues/14128#issuecomment-811389466 I don't belive it's an issue at all. Airflow is only officialy installable with `pip` and it works nicely when you run it in including constraints in the way described here: http://airflow.apache.org/docs/apache-airflow/stable/installation.html#installation-tools. This is the only installation method that brings repeatable results. Other methods might fail, but w are not supporting a full range of tools that behave differently than PIP. If you are using poetry, pipenv or other tools like that you are pretty much on your own. If this is not a 'serious issue' but "some way of using some tool', it's likely to be closed as invalid. So possibly starting discussion and discussing it might be a better way to go about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #14128: Circular package imports in Airflow 2.0
potiuk edited a comment on issue #14128: URL: https://github.com/apache/airflow/issues/14128#issuecomment-811266078 > @potiuk any clue when airflow will get a new release with this issue fixed? It's already fixed in released 2.0.1 https://github.com/apache/airflow/pull/13314 > also looks like the issue is not fixed at least for apache-airflow-providers-cncf-kubernetes It's never been an issue for cncf-kubernetes. This was only issue for the 4 providers that are preinstalled: 'ftp', 'http', 'imap', 'sqlite'. Airflow has only "extra" dependency on cncf.kubernetes but extras are not counting as "install-requires" so this is not a problem as far as I know (unless you specifically have some problem that you would like to describe). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #14128: Circular package imports in Airflow 2.0
potiuk edited a comment on issue #14128: URL: https://github.com/apache/airflow/issues/14128#issuecomment-774806420 It''s been already solved in https://github.com/apache/airflow/commit/0d214575a144356a8a83a462d6d9fb68bf4999c7#diff-ee4de59d2448e097b1d108d4d83a0d40cb3e2767c84f67a62696e62c6afa23f8R291 in master during provider package preparation (those 4 pre-installed packages will have no dependency any more on apache-airflow to avoid the circular dependency). Also we are already voting on the new provider packages (target date to release them - tomorrow). The discussion about release candidates for those is in https://lists.apache.org/thread.html/rffdfd355a28e08ec7e3e8749eedd51ba8a248107d72e4b893d04af81%40%3Cdev.airflow.apache.org%3E Kind request @thundergolfer - could you please check the release candidates for those packages: * https://pypi.org/project/apache-airflow-providers-http/1.1.0rc1 * https://pypi.org/project/apache-airflow-providers-ftp/1.0.1rc1/ * https://pypi.org/project/apache-airflow-providers-imap/1.0.1rc1/ * https://pypi.org/project/apache-airflow-providers-sqlite/1.0.1rc1/ and install them with airflow, and see if the circular problem is solved? I am closing this issue now, but if you find that it is not solved, let me know what the problems are and I might re-open it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #14128: Circular package imports in Airflow 2.0
potiuk edited a comment on issue #14128: URL: https://github.com/apache/airflow/issues/14128#issuecomment-774806420 It''s been already solved in https://github.com/apache/airflow/commit/0d214575a144356a8a83a462d6d9fb68bf4999c7#diff-ee4de59d2448e097b1d108d4d83a0d40cb3e2767c84f67a62696e62c6afa23f8R291 in master during provider package preparation (those 4 pre-installed packages will have no dependency any more on apache-airflow to avoid the circular dependency). Also we are already voting on the new provider packages (target date to relese them - tomorrow). The discussion about release candidates for those is in https://lists.apache.org/thread.html/rffdfd355a28e08ec7e3e8749eedd51ba8a248107d72e4b893d04af81%40%3Cdev.airflow.apache.org%3E Kind request @thundergolfer - could you please check the release candidates for those packages: * https://pypi.org/project/apache-airflow-providers-http/1.1.0rc1 * https://pypi.org/project/apache-airflow-providers-ftp/1.0.1rc1/ * https://pypi.org/project/apache-airflow-providers-imap/1.0.1rc1/ * https://pypi.org/project/apache-airflow-providers-sqlite/1.0.1rc1/ and install them with airflow, and see if the circular problem is solved? I am closing this issue now, but if you find that it is not solved, let me know what the problems are and I might re-open it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
