[GitHub] [airflow] saguziel commented on a change in pull request #7363: [AIRFLOW-6730] Use total_seconds instead of seconds

2020-02-27 Thread GitBox 
saguziel commented on a change in pull request #7363: [AIRFLOW-6730] Use 
total_seconds instead of seconds
URL: https://github.com/apache/airflow/pull/7363#discussion_r385388599
 
 

 ##
 File path: tests/providers/google/cloud/operators/test_dataproc.py
 ##
 @@ -104,7 +104,7 @@
 "autoscaling_config": {"policy_uri": "autoscaling_policy"},
 "config_bucket": "storage_bucket",
 "initialization_actions": [
-{"executable_file": "init_actions_uris", "execution_timeout": 
"600s"}
+{"executable_file": "init_actions_uris", "execution_timeout": 
"600.0s"}
 
 Review comment:
   the python typing indicates float, but I think that is just within the 
airflow project.
   
   I will just cast it to int since that is guaranteed to not break anything


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] saguziel commented on a change in pull request #7363: [AIRFLOW-6730] Use total_seconds instead of seconds

2020-02-06 Thread GitBox 
saguziel commented on a change in pull request #7363: [AIRFLOW-6730] Use 
total_seconds instead of seconds
URL: https://github.com/apache/airflow/pull/7363#discussion_r376051577
 
 

 ##
 File path: airflow/providers/google/cloud/operators/dataproc.py
 ##
 @@ -618,16 +618,16 @@ def _graceful_decommission_timeout_object(self) -> 
Optional[Dict]:
 match = re.match(r"^(\d+)([smdh])$", 
self.graceful_decommission_timeout)
 if match:
 if match.group(2) == "s":
-timeout = int(match.group(1))
+timeout = float(match.group(1))
 
 Review comment:
   This one I think makes sense as float since it is only passed as a param to 
something that is a float  
   (to hooks/dataproc.py -> update_cluster which takes timeout as an 
Optional[float] )


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services