[GitHub] [airflow] steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement
steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement URL: https://github.com/apache/airflow/pull/5770#issuecomment-531443919 I got everything working but seem to have a build documentation error. I can't seem to figure it out. I am up to date with the master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement
steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement URL: https://github.com/apache/airflow/pull/5770#issuecomment-530395963 Everything looks ready to go. Please let me know if I can do anything else :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement
steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement URL: https://github.com/apache/airflow/pull/5770#issuecomment-529121895 git remote show origin is saying all branches are tracked and my master is up to date. Heres a link to my fork and travis. https://github.com/steven-freed/airflow https://travis-ci.com/steven-freed/airflow/builds/126309005 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement
steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement URL: https://github.com/apache/airflow/pull/5770#issuecomment-529118318 The error I’m talking about is actually on my forked repos master. I was trying to test on my own Travis before pushing a new change to my gas-hook-update branch. I know the error above was my code that was what I wanted to fix. But now I have that new error I pointed out that occurred after I rebased my forked repos master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement
steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method
Improvement
URL: https://github.com/apache/airflow/pull/5770#issuecomment-529037214
After rebasing now I am getting errors for "Tests sqlite python 3.5" that I
cannot seem to figure out. I haven't changed anything in those files, it seems
like its coming from another module. I believe I rebased it correctly, maybe
that is my issue.
ERROR - Failed to import plugin /opt/airflow/tests/plugins/test_plugin.py
{plugins_manager.py:148} ERROR - invalid syntax (convert.py, line 80)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement
steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement URL: https://github.com/apache/airflow/pull/5770#issuecomment-528486971 Yes I will I apologize I just started up my course work and have been busy but I will this weekend. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement
steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement URL: https://github.com/apache/airflow/pull/5770#issuecomment-526874310 Can you point me in the right direction of writing tests with GCP? I saw in the airflow tests directory there were tests for hooks but none for GCS. I am a bit confused on what credentials to use to mock a GCP account for tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement
steven-freed commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement URL: https://github.com/apache/airflow/pull/5770#issuecomment-520257848 My PR Travis tests were canceled. I may have ran too many test (this is my first PR). Is there any way that I can have my canceled tests run in Travis without having to push an unnecessary commit to auto run the tests? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
