[GitHub] [airflow] swapz-z commented on pull request #28282: Mark stepIds for cancel in EmrAddStepsOperator
swapz-z commented on PR #28282: URL: https://github.com/apache/airflow/pull/28282#issuecomment-1356269146 @Taragolis Again the reviewers were removed when I tried adding you as reviewer. 🤦🏻♂️ Could you please add them back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] swapz-z commented on pull request #28282: Mark stepIds for cancel in EmrAddStepsOperator
swapz-z commented on PR #28282: URL: https://github.com/apache/airflow/pull/28282#issuecomment-1355303154 > Please add the reviewers again, I was just trying to request for a re-review from you and others got removed 🤦🏻♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] swapz-z commented on pull request #28282: Mark stepIds for cancel in EmrAddStepsOperator
swapz-z commented on PR #28282: URL: https://github.com/apache/airflow/pull/28282#issuecomment-1354966147 Hello @Taragolis I accidentally removed @eladkal from reviewers list. Now I don't have an option to add a reviewer. Could you do the needful and add him back :) Also, let me know if I need to change anything beyond these files like docs/etc. Thanks in advance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] swapz-z commented on pull request #28282: Mark stepIds for cancel in EmrAddStepsOperator
swapz-z commented on PR #28282: URL: https://github.com/apache/airflow/pull/28282#issuecomment-1345529940 Thanks [Taragolis](https://github.com/Taragolis) I will incorporate these as suggested > Also this code need to be covered by tests, we want to reduce chance of any regression. Although tests for hooks are added, I was hoping to add more after getting some initial review/thoughts on the functional code, since existing test cases also will have to be modified accordingly, if needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
