[GitHub] [airflow] uranusjr commented on pull request #17581: Remove the use of multiprocessing in TestLocalTaskJob and Improve Tests

2021-08-17 Thread GitBox 


uranusjr commented on pull request #17581:
URL: https://github.com/apache/airflow/pull/17581#issuecomment-900172063


   I think an assert would be better than the `task_terminated_externally` 
check. It’s better to not depend on too much logic to trigger a test failure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #17581: Remove the use of multiprocessing in TestLocalTaskJob and Improve Tests

2021-08-17 Thread GitBox 


uranusjr commented on pull request #17581:
URL: https://github.com/apache/airflow/pull/17581#issuecomment-900159470


   There are several
   
   ```python
   # This should not happen.
   time.sleep(10)
   ```
   
   usages in the tests. I wonder if we should add an `assert False, "This 
should not happen"` at their end to make the test fail explicitly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #17581: Remove the use of multiprocessing in TestLocalTaskJob and Improve Tests

2021-08-17 Thread GitBox 


uranusjr commented on pull request #17581:
URL: https://github.com/apache/airflow/pull/17581#issuecomment-900156495


   Note: The MSSQL job was red since it’s killed midway, so I think it’s safe 
to assume all tests are passing right now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org