[GitHub] [airflow] uranusjr commented on pull request #29034: Add functionality for operators to template all eligible fields (apac…

2023-02-02 Thread via GitHub 


uranusjr commented on PR #29034:
URL: https://github.com/apache/airflow/pull/29034#issuecomment-1414988919

   Same way as it’s determined now (if `template_fields` is `__all__` on the 
class we calculate it in `__init__`).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #29034: Add functionality for operators to template all eligible fields (apac…

2023-02-02 Thread via GitHub 


uranusjr commented on PR #29034:
URL: https://github.com/apache/airflow/pull/29034#issuecomment-1414934990

   I have doubts making this an operator argument is the right design. I’d want 
to make this designed at the operator class level, e.g.
   
   ```python
   class MyOperator(BaseOperator):
   template_fields = "__all__"  # Or we could introduce a flag constant for 
this.
   template_fields_excludes = [...]  # If needed.
   ```
   
   And then we can work to convert existing operators gradually with more 
confidence they work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org