[GitHub] [airflow] uranusjr commented on pull request #29608: Enable passing --xcom-args to tasks test CLI command

2023-02-23 Thread via GitHub


uranusjr commented on PR #29608:
URL: https://github.com/apache/airflow/pull/29608#issuecomment-1442811804

   I think your plan makes sense. So we’ll use this PR to implement 
value-passing, and add path support in a later PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] uranusjr commented on pull request #29608: Enable passing --xcom-args to tasks test CLI command

2023-02-22 Thread via GitHub


uranusjr commented on PR #29608:
URL: https://github.com/apache/airflow/pull/29608#issuecomment-1441235817

   By the way, the argument name can probably be shortened to just `--xcom` or 
`--xcoms`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] uranusjr commented on pull request #29608: Enable passing --xcom-args to tasks test CLI command

2023-02-22 Thread via GitHub


uranusjr commented on PR #29608:
URL: https://github.com/apache/airflow/pull/29608#issuecomment-1441235340

   Allowing a path makes sense to me. Since a JSON string has a pretty 
distinctive shape (starts and ends with either brackets or braces depending on 
which format we decide to use), I think we can allow both with one option.
   
   While path to a pickle object also makes sense in theory, generating that 
pickle file would be pretty cumbersome and I’m not sure people would want to 
use that. I would probably leave that out for now until someone asks for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] uranusjr commented on pull request #29608: Enable passing --xcom-args to tasks test CLI command

2023-02-20 Thread via GitHub


uranusjr commented on PR #29608:
URL: https://github.com/apache/airflow/pull/29608#issuecomment-1437292418

   Using JSON for this feels cumbersome to me. I don’t have a much better idea 
though. Also we need to find a way to support custom backends that may not 
store values as JSON.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org