[GitHub] [airflow] vuppalli commented on pull request #9618: Fix typos, older versions, and deprecated operators with AI platform example DAG

2020-07-06 Thread GitBox


vuppalli commented on pull request #9618:
URL: https://github.com/apache/airflow/pull/9618#issuecomment-654336203


   @mik-laj Yes, thank you!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [airflow] vuppalli commented on pull request #9618: Fix typos, older versions, and deprecated operators with AI platform example DAG

2020-07-06 Thread GitBox


vuppalli commented on pull request #9618:
URL: https://github.com/apache/airflow/pull/9618#issuecomment-654305242


   @mik-laj Thanks so much for your response. I am not sure which files are 
needed to run the tests so I do not know if they have changed. The only file I 
have contributed to is the example DAG. Also, I have fixed the trailing 
whitespace issues and will create a new PR for the guide sometime this week. 
   
   I am really enjoying my internship at Google and this contribution is quite 
relevant the work I am doing! Since I am working with Cloud Composer and AI 
Platform, I am grateful to have helped with this contribution as I learned a 
lot about both products. I would love to get more involved with Open Source and 
appreciate the help!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [airflow] vuppalli commented on pull request #9618: Fix typos, older versions, and deprecated operators with AI platform example DAG

2020-07-01 Thread GitBox


vuppalli commented on pull request #9618:
URL: https://github.com/apache/airflow/pull/9618#issuecomment-652672627


   @mik-laj You mentioned that this DAG does not have accompanying tests. How 
should I go about addressing the Unit tests coverage bullet above? 
Additionally, should I make this a draft PR while I work on the corresponding 
documentation?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org