[GitHub] [airflow] yuqian90 commented on issue #7139: [AIRFLOW-2279] Clear tasks across DAGs if marked by ExternalTaskMarker
yuqian90 commented on issue #7139: [AIRFLOW-2279] Clear tasks across DAGs if marked by ExternalTaskMarker URL: https://github.com/apache/airflow/pull/7139#issuecomment-573390871 @kaxil, this is the same change that you already merged. Since it's a bit of work to merge against v1-10-test, I put up this PR to do that. (e.g. www vs www_rbac are two separate packages, and there's a test which counts the number of example DAGs that need to be updated). However, I noticed some tests time out. It doesn't look related to my change, e.g. test_cli.py timesout. test_external_task_sensors.py times out in one of the test profiles (Tests sqlite python 3.5), again I don't think it's due to my change. Is there some known issue with the tests in v1-10-test? The same tests in master seem to work just fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] yuqian90 commented on issue #7139: [AIRFLOW-2279] Clear tasks across DAGs if marked by ExternalTaskMarker
yuqian90 commented on issue #7139: [AIRFLOW-2279] Clear tasks across DAGs if marked by ExternalTaskMarker URL: https://github.com/apache/airflow/pull/7139#issuecomment-576619381 > @kaxil, this is the same change that you already merged. Since it's a bit of work to merge against v1-10-test, I put up this PR to do that. (e.g. www vs www_rbac are two separate packages, and there's a test which counts the number of example DAGs that need to be updated). > > However, I noticed some tests time out. It doesn't look related to my change, e.g. test_cli.py timesout. test_external_task_sensors.py times out in one of the test profiles (Tests sqlite python 3.5), again I don't think it's due to my change. Is there some known issue with the tests in v1-10-test? The same tests in master seem to work just fine. Okay I found the problem with `test_external_task_sensors.py`. I need to set the `ExternalTaskSensor` to `mode="reschedule"` in order to pass the Travis test for sqlite. I did that and the test is now happy. It's interesting the same test passes without issue in master branch. For `test_cli.py`, I have double checked it is unrelated to my PR. I tried running the same test using clean `upstream/v1-10-test`, it fails too. So it's likely some other issue that should be addressed in a separate PR by someone else. @kaxil pls take a look if you have a chance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] yuqian90 commented on issue #7139: [AIRFLOW-2279] Clear tasks across DAGs if marked by ExternalTaskMarker
yuqian90 commented on issue #7139: [AIRFLOW-2279] Clear tasks across DAGs if marked by ExternalTaskMarker URL: https://github.com/apache/airflow/pull/7139#issuecomment-577077316 Some new test failures appeared after I git rebased onto `upstream/v1-10-test`. None of them look related to my change. @potiuk might have better ideas regarding those failures since I see he's committing changes to fix some of them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] yuqian90 commented on issue #7139: [AIRFLOW-2279] Clear tasks across DAGs if marked by ExternalTaskMarker
yuqian90 commented on issue #7139: [AIRFLOW-2279] Clear tasks across DAGs if marked by ExternalTaskMarker URL: https://github.com/apache/airflow/pull/7139#issuecomment-577994008 > Merged to v1-10-test in [14111b4](https://github.com/apache/airflow/commit/14111b4bddbaa7c7085a25cdfe923f88219e1582) Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
