[GitHub] [airflow] zhongjiajie commented on issue #6950: [AIRFLOW-6392] Remove cyclic dependency baseoperator <-> helpers
zhongjiajie commented on issue #6950: [AIRFLOW-6392] Remove cyclic dependency baseoperator <-> helpers URL: https://github.com/apache/airflow/pull/6950#issuecomment-569910783 > These functions are used by users, so we should think about backward compatibility. I submit https://github.com/apache/airflow/pull/4779 due to use bit shift will so lengthy in some situation as I comment in https://github.com/apache/airflow/pull/4779#issuecomment-467694805, but when I use `chain` could be more easy using `chain(*[lists_of_task])`, So IMO and situation, I think function `chain` is useful and I will not remove it, that my point This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6950: [AIRFLOW-6392] Remove cyclic dependency baseoperator <-> helpers
zhongjiajie commented on issue #6950: [AIRFLOW-6392] Remove cyclic dependency baseoperator <-> helpers URL: https://github.com/apache/airflow/pull/6950#issuecomment-569911368 Our community have another function `chain` big fans @bcb , FYI, `chain` import path will change in Ariflow 2.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6950: [AIRFLOW-6392] Remove cyclic dependency baseoperator <-> helpers
zhongjiajie commented on issue #6950: [AIRFLOW-6392] Remove cyclic dependency baseoperator <-> helpers URL: https://github.com/apache/airflow/pull/6950#issuecomment-569912631 @potiuk Should we add the different import path in https://github.com/apache/airflow/blob/master/docs/concepts.rst#relationship-helper ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6950: [AIRFLOW-6392] Remove cyclic dependency baseoperator <-> helpers
zhongjiajie commented on issue #6950: [AIRFLOW-6392] Remove cyclic dependency baseoperator <-> helpers URL: https://github.com/apache/airflow/pull/6950#issuecomment-569914203 > Updated all comments @kaxil ! What shall we do with the backwards compatibility there? Do you think we should worry about this in this case? IMO, If only import path change but function still exists, I think is not a problem. But if remove function should be more careful. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
