[GitHub] drewsonne commented on issue #4412: [AIRFLOW-3605] Load plugins from entry_points

2019-01-10 Thread GitBox 
drewsonne commented on issue #4412: [AIRFLOW-3605] Load plugins from 
entry_points
URL: https://github.com/apache/airflow/pull/4412#issuecomment-453300966
 
 
   @feng-tao amazing, thank you! looking forward to the release for this  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] drewsonne commented on issue #4412: [AIRFLOW-3605] Load plugins from entry_points

2019-01-10 Thread GitBox 
drewsonne commented on issue #4412: [AIRFLOW-3605] Load plugins from 
entry_points
URL: https://github.com/apache/airflow/pull/4412#issuecomment-453268397
 
 
   Argh, stupid mistake and here's a PR to try to shorten the turnaround time 
for travis alerting on lint failures
   https://github.com/apache/airflow/pull/4477/files


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] drewsonne commented on issue #4412: [AIRFLOW-3605] Load plugins from entry_points

2019-01-10 Thread GitBox 
drewsonne commented on issue #4412: [AIRFLOW-3605] Load plugins from 
entry_points
URL: https://github.com/apache/airflow/pull/4412#issuecomment-453224881
 
 
   Ok, this looks good from my side now. The codecov says it's reducing 
coverage, but in files this PR doesn't touch, so I'm not sure why :-/
   
   Anything else or is this good to go?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] drewsonne commented on issue #4412: [AIRFLOW-3605] Load plugins from entry_points

2019-01-10 Thread GitBox 
drewsonne commented on issue #4412: [AIRFLOW-3605] Load plugins from 
entry_points
URL: https://github.com/apache/airflow/pull/4412#issuecomment-453110777
 
 
   Uh... it's failing on writing a log  
   
   https://travis-ci.org/apache/airflow/jobs/477803046#L4897
   ```==
   37) ERROR: test_failed_load_entrpoint_plugins 
(tests.plugins.test_plugins_manager_www.PluginsTestEntrypointLoad)
   --
  Traceback (most recent call last):
   tests/plugins/test_plugins_manager_www.py line 128 in 
test_failed_load_entrpoint_plugins
 )], []),
   airflow/plugins_manager.py line 88 in load_entrypoint_plugins
 log.debug('Importing entry_point plugin %s', entry_point.name)
   /usr/lib/python2.7/logging/__init__.py line 1155 in debug
 self._log(DEBUG, msg, args, **kwargs)
   /usr/lib/python2.7/logging/__init__.py line 1286 in _log
 self.handle(record)
   /usr/lib/python2.7/logging/__init__.py line 1296 in handle
 self.callHandlers(record)
   /usr/lib/python2.7/logging/__init__.py line 1336 in callHandlers
 hdlr.handle(record)
   /usr/lib/python2.7/logging/__init__.py line 759 in handle
 self.emit(record)
   
.tox/py27-backend_mysql-env_docker/lib/python2.7/site-packages/nose/plugins/logcapture.py
 line 82 in emit
 self.buffer.append(self.format(record))
   /usr/lib/python2.7/logging/__init__.py line 734 in format
 return fmt.format(record)
   /usr/lib/python2.7/logging/__init__.py line 465 in format
 record.message = record.getMessage()
   /usr/lib/python2.7/logging/__init__.py line 329 in getMessage
 msg = msg % self.args
  TypeError: coercing to Unicode: need string or buffer, MagicMock found```
   
   Initial inspection looks like I'm using logging the same as everywhere else, 
but I will have to have a closer look later. It looks like a problem with the 
method of test implementation rather than the code itself... I think.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] drewsonne commented on issue #4412: [AIRFLOW-3605] Load plugins from entry_points

2019-01-09 Thread GitBox 
drewsonne commented on issue #4412: [AIRFLOW-3605] Load plugins from 
entry_points
URL: https://github.com/apache/airflow/pull/4412#issuecomment-452623597
 
 
   @feng-tao I've got a PR to your airflow repo, which fixes one of the 
failures in the test cases https://github.com/feng-tao/incubator-airflow/pull/12


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services