[GitHub] jgao54 commented on issue #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function
jgao54 commented on issue #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function URL: https://github.com/apache/incubator-airflow/pull/4423#issuecomment-451297332 great! it does look like we are short of an input validation check for CLI that could have made this a bit easier to detect. contributions welcome :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jgao54 commented on issue #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function
jgao54 commented on issue #4423: [AIRFLOW-3618] - Fix models.connection.Connection get_hook function URL: https://github.com/apache/incubator-airflow/pull/4423#issuecomment-451090738 All the conn type are defined [here](https://github.com/apache/incubator-airflow/blob/master/airflow/models/connection.py#L53-L92) and they are all lower case consistently. We don't use .lower() because these conn types are hard-coded into the connection.py module. I noticed that in your JIRA it shows `MySQL` instead, perhaps it's a custom created connection type? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
