[GitHub] kaxil commented on a change in pull request #4455: [AIRFLOW-3519] Fix example http operator

2019-01-07 Thread GitBox
kaxil commented on a change in pull request #4455: [AIRFLOW-3519] Fix example 
http operator
URL: https://github.com/apache/airflow/pull/4455#discussion_r245790529
 
 

 ##
 File path: airflow/example_dags/example_http_operator.py
 ##
 @@ -92,7 +92,7 @@
 http_conn_id='http_default',
 endpoint='',
 request_params={},
-response_check=lambda response: True if "Google" in response.content else 
False,
 
 Review comment:
   Makes sense. Thanks @feluelle 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kaxil commented on a change in pull request #4455: [AIRFLOW-3519] Fix example http operator

2019-01-07 Thread GitBox
kaxil commented on a change in pull request #4455: [AIRFLOW-3519] Fix example 
http operator
URL: https://github.com/apache/airflow/pull/4455#discussion_r245784539
 
 

 ##
 File path: airflow/example_dags/example_http_operator.py
 ##
 @@ -92,7 +92,7 @@
 http_conn_id='http_default',
 endpoint='',
 request_params={},
-response_check=lambda response: True if "Google" in response.content else 
False,
 
 Review comment:
   response.content works as well. Does it error for you @feluelle ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services