[jira] [Commented] (AIRFLOW-4008) Add ability to set a ConfigMap to EnvFrom for pods brought up by the Kubernetes Executor
[ https://issues.apache.org/jira/browse/AIRFLOW-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808525#comment-16808525 ] ASF subversion and git services commented on AIRFLOW-4008: -- Commit 4a052013d4c28d53d288fbe159c3b39153b1fc3a in airflow's branch refs/heads/v1-10-test from davlum [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=4a05201 ] [AIRFLOW-4008] add envFrom for Kubernetes Executor (#4952) > Add ability to set a ConfigMap to EnvFrom for pods brought up by the > Kubernetes Executor > > > Key: AIRFLOW-4008 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4008 > Project: Apache Airflow > Issue Type: Improvement > Components: kubernetes >Reporter: David Lum >Assignee: David Lum >Priority: Minor > Labels: Kubernetes, kubernetes > > This ticket is split off from AIRFLOW-3258. This ticket will allow users to > specify configMapRefs and secretRefs to envFrom for worker pods brought up by > the KubernetesExecutor. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-4008) Add ability to set a ConfigMap to EnvFrom for pods brought up by the Kubernetes Executor
[ https://issues.apache.org/jira/browse/AIRFLOW-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808522#comment-16808522 ] ASF GitHub Bot commented on AIRFLOW-4008: - ashb commented on pull request #4952: [AIRFLOW-4008] add envFrom for Kubernetes Executor URL: https://github.com/apache/airflow/pull/4952 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add ability to set a ConfigMap to EnvFrom for pods brought up by the > Kubernetes Executor > > > Key: AIRFLOW-4008 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4008 > Project: Apache Airflow > Issue Type: Improvement > Components: kubernetes >Reporter: David Lum >Assignee: David Lum >Priority: Minor > Labels: Kubernetes, kubernetes > > This ticket is split off from AIRFLOW-3258. This ticket will allow users to > specify configMapRefs and secretRefs to envFrom for worker pods brought up by > the KubernetesExecutor. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-4008) Add ability to set a ConfigMap to EnvFrom for pods brought up by the Kubernetes Executor
[ https://issues.apache.org/jira/browse/AIRFLOW-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808523#comment-16808523 ] ASF subversion and git services commented on AIRFLOW-4008: -- Commit e72ff0aeab3951d01360e65276a1088cd8a52c82 in airflow's branch refs/heads/master from davlum [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=e72ff0a ] [AIRFLOW-4008] add envFrom for Kubernetes Executor (#4952) > Add ability to set a ConfigMap to EnvFrom for pods brought up by the > Kubernetes Executor > > > Key: AIRFLOW-4008 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4008 > Project: Apache Airflow > Issue Type: Improvement > Components: kubernetes >Reporter: David Lum >Assignee: David Lum >Priority: Minor > Labels: Kubernetes, kubernetes > > This ticket is split off from AIRFLOW-3258. This ticket will allow users to > specify configMapRefs and secretRefs to envFrom for worker pods brought up by > the KubernetesExecutor. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-4008) Add ability to set a ConfigMap to EnvFrom for pods brought up by the Kubernetes Executor
[
https://issues.apache.org/jira/browse/AIRFLOW-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797277#comment-16797277
]
ASF GitHub Bot commented on AIRFLOW-4008:
-
davlum commented on pull request #4952: feat/AIRFLOW-4008/k8s-executor-env-from
URL: https://github.com/apache/airflow/pull/4952
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add ability to set a ConfigMap to EnvFrom for pods brought up by the
> Kubernetes Executor
>
>
> Key: AIRFLOW-4008
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4008
> Project: Apache Airflow
> Issue Type: Improvement
> Components: kubernetes
>Reporter: David Lum
>Assignee: David Lum
>Priority: Minor
> Labels: Kubernetes, kubernetes
>
> This ticket is split off from AIRFLOW-3258. This ticket will allow users to
> specify configMapRefs and secretRefs to envFrom for worker pods brought up by
> the KubernetesExecutor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-4008) Add ability to set a ConfigMap to EnvFrom for pods brought up by the Kubernetes Executor
[
https://issues.apache.org/jira/browse/AIRFLOW-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796100#comment-16796100
]
ASF subversion and git services commented on AIRFLOW-4008:
--
Commit ddaa00cd0beab2bf212ad67d2fb57de35ab7ee22 in airflow's branch
refs/heads/v1-10-stable from davlum
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=ddaa00c ]
[AIRFLOW-3258] K8S executor environment variables section. (#4627)
* [AIRFLOW-3258] K8S executor, optional mount current env in worker pods
* fix(AIRFLOW-3258): fix tests
* fetch config in KubeConfig init
* fix(AIRFLOW-3258): address pr comments
feat(AIRFLOW-3258): move feature to AIRFLOW-4008
fix(AIRFLOW-3258): fix tests
* refactor(AIRFLOW-3258): changes for PR
> Add ability to set a ConfigMap to EnvFrom for pods brought up by the
> Kubernetes Executor
>
>
> Key: AIRFLOW-4008
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4008
> Project: Apache Airflow
> Issue Type: Improvement
> Components: kubernetes
>Reporter: David Lum
>Assignee: David Lum
>Priority: Minor
> Labels: Kubernetes, kubernetes
>
> This ticket is split off from AIRFLOW-3258. This addresses the problem of
> having scheduler and worker pods with the same configuration. Manually
> specifying environment variables in the deployment file and then again in the
> {{airflow.cfg}} is error prone. Two options to fix this are:
> # Add all the environment variables of the scheduler to the pods being
> brought up. This could be set with a boolean flag in the kubernetes section
> of the {{airflow.cfg}} which would to default to false, and have a name such
> as copy_scheduler_enivronement. Any environment variables set in the
> kubernetes_environment_variables or kuberenetes_secrets section, as well as
> those that are hard coded such as AIRFLOW__CORE__EXECUTOR would overwrite
> those present in the current environment when applied to the worker pod.
> # Specify a ConfigMap that the worker pods {{envFrom}} in the
> {{airflow.cfg}} that could act as a shared resource for the scheduler and
> worker pods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-4008) Add ability to set a ConfigMap to EnvFrom for pods brought up by the Kubernetes Executor
[
https://issues.apache.org/jira/browse/AIRFLOW-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785914#comment-16785914
]
ASF subversion and git services commented on AIRFLOW-4008:
--
Commit 0c4774d605a2786bbf44fb6f5bed15addadeb5e7 in airflow's branch
refs/heads/master from davlum
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=0c4774d ]
[AIRFLOW-3258] K8S executor environment variables section. (#4627)
* [AIRFLOW-3258] K8S executor, optional mount current env in worker pods
* fix(AIRFLOW-3258): fix tests
* fetch config in KubeConfig init
* fix(AIRFLOW-3258): address pr comments
feat(AIRFLOW-3258): move feature to AIRFLOW-4008
fix(AIRFLOW-3258): fix tests
* refactor(AIRFLOW-3258): changes for PR
> Add ability to set a ConfigMap to EnvFrom for pods brought up by the
> Kubernetes Executor
>
>
> Key: AIRFLOW-4008
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4008
> Project: Apache Airflow
> Issue Type: Improvement
> Components: kubernetes
>Reporter: David Lum
>Assignee: David Lum
>Priority: Minor
> Labels: Kubernetes, kubernetes
>
> This ticket is split off from AIRFLOW-3258. This addresses the problem of
> having scheduler and worker pods with the same configuration. Manually
> specifying environment variables in the deployment file and then again in the
> {{airflow.cfg}} is error prone. Two options to fix this are:
> # Add all the environment variables of the scheduler to the pods being
> brought up. This could be set with a boolean flag in the kubernetes section
> of the {{airflow.cfg}} which would to default to false, and have a name such
> as copy_scheduler_enivronement. Any environment variables set in the
> kubernetes_environment_variables or kuberenetes_secrets section, as well as
> those that are hard coded such as AIRFLOW__CORE__EXECUTOR would overwrite
> those present in the current environment when applied to the worker pod.
> # Specify a ConfigMap that the worker pods {{envFrom}} in the
> {{airflow.cfg}} that could act as a shared resource for the scheduler and
> worker pods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
