[jira] [Commented] (AIRFLOW-4235) home page dags table: highlight rows on mouse hover
[ https://issues.apache.org/jira/browse/AIRFLOW-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083692#comment-17083692 ] ASF subversion and git services commented on AIRFLOW-4235: -- Commit 324954c7d37acd12b9593958fdf4b424f8c5d11d in airflow's branch refs/heads/v1-10-test from Nando Quintana [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=324954c ] [AIRFLOW-4235] Add table-hover css class to DAGs table (#5033) > home page dags table: highlight rows on mouse hover > --- > > Key: AIRFLOW-4235 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4235 > Project: Apache Airflow > Issue Type: Improvement > Components: ui >Affects Versions: 1.10.2 >Reporter: Nando Quintana >Assignee: Fokko Driesprong >Priority: Trivial > Labels: easyfix, newbie > Fix For: 1.10.11 > > Attachments: table_dags_table_hover.png > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > In wide screens, home page dags table becomes too wide. There is too much > distance between "DAG" and "Links" columns and it is difficult to appreciate > which is the icon you should click. > It would be very useful to highlight row on mouse hover. > This could be fixed very quickly, adding 'table-hover' css class to > table#dags. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-4235) home page dags table: highlight rows on mouse hover
[ https://issues.apache.org/jira/browse/AIRFLOW-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083586#comment-17083586 ] ASF subversion and git services commented on AIRFLOW-4235: -- Commit 44ddf3da1871d3a3741075d9767da48fb9cd72d6 in airflow's branch refs/heads/v1-10-test from Nando Quintana [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=44ddf3d ] [AIRFLOW-4235] Add table-hover css class to DAGs table (#5033) > home page dags table: highlight rows on mouse hover > --- > > Key: AIRFLOW-4235 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4235 > Project: Apache Airflow > Issue Type: Improvement > Components: ui >Affects Versions: 1.10.2 >Reporter: Nando Quintana >Assignee: Fokko Driesprong >Priority: Trivial > Labels: easyfix, newbie > Fix For: 1.10.11 > > Attachments: table_dags_table_hover.png > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > In wide screens, home page dags table becomes too wide. There is too much > distance between "DAG" and "Links" columns and it is difficult to appreciate > which is the icon you should click. > It would be very useful to highlight row on mouse hover. > This could be fixed very quickly, adding 'table-hover' css class to > table#dags. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-4235) home page dags table: highlight rows on mouse hover
[ https://issues.apache.org/jira/browse/AIRFLOW-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083524#comment-17083524 ] ASF subversion and git services commented on AIRFLOW-4235: -- Commit 5bc2325e0c8a620ce26cad0045fd5fda152e136d in airflow's branch refs/heads/v1-10-test from Nando Quintana [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=5bc2325 ] [AIRFLOW-4235] Add table-hover css class to DAGs table (#5033) > home page dags table: highlight rows on mouse hover > --- > > Key: AIRFLOW-4235 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4235 > Project: Apache Airflow > Issue Type: Improvement > Components: ui >Affects Versions: 1.10.2 >Reporter: Nando Quintana >Assignee: Fokko Driesprong >Priority: Trivial > Labels: easyfix, newbie > Fix For: 1.10.11 > > Attachments: table_dags_table_hover.png > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > In wide screens, home page dags table becomes too wide. There is too much > distance between "DAG" and "Links" columns and it is difficult to appreciate > which is the icon you should click. > It would be very useful to highlight row on mouse hover. > This could be fixed very quickly, adding 'table-hover' css class to > table#dags. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-4235) home page dags table: highlight rows on mouse hover
[ https://issues.apache.org/jira/browse/AIRFLOW-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810773#comment-16810773 ] ASF subversion and git services commented on AIRFLOW-4235: -- Commit 3ad80f29f6a21b5a3df365a5fbbe2004584c554f in airflow's branch refs/heads/master from Nando Quintana [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=3ad80f2 ] [AIRFLOW-4235] Add table-hover css class to DAGs table (#5033) > home page dags table: highlight rows on mouse hover > --- > > Key: AIRFLOW-4235 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4235 > Project: Apache Airflow > Issue Type: Improvement > Components: ui >Affects Versions: 1.10.2 >Reporter: Nando Quintana >Assignee: Nando Quintana >Priority: Trivial > Labels: easyfix, newbie > Fix For: 1.10.3 > > Attachments: table_dags_table_hover.png > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > In wide screens, home page dags table becomes too wide. There is too much > distance between "DAG" and "Links" columns and it is difficult to appreciate > which is the icon you should click. > It would be very useful to highlight row on mouse hover. > This could be fixed very quickly, adding 'table-hover' css class to > table#dags. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-4235) home page dags table: highlight rows on mouse hover
[ https://issues.apache.org/jira/browse/AIRFLOW-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810772#comment-16810772 ] ASF GitHub Bot commented on AIRFLOW-4235: - Fokko commented on pull request #5033: [AIRFLOW-4235] home page dags table: highlight rows on mouse hover URL: https://github.com/apache/airflow/pull/5033 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > home page dags table: highlight rows on mouse hover > --- > > Key: AIRFLOW-4235 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4235 > Project: Apache Airflow > Issue Type: Improvement > Components: ui >Affects Versions: 1.10.2 >Reporter: Nando Quintana >Assignee: Nando Quintana >Priority: Trivial > Labels: easyfix, newbie > Fix For: 1.10.3 > > Attachments: table_dags_table_hover.png > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > In wide screens, home page dags table becomes too wide. There is too much > distance between "DAG" and "Links" columns and it is difficult to appreciate > which is the icon you should click. > It would be very useful to highlight row on mouse hover. > This could be fixed very quickly, adding 'table-hover' css class to > table#dags. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-4235) home page dags table: highlight rows on mouse hover
[
https://issues.apache.org/jira/browse/AIRFLOW-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809570#comment-16809570
]
ASF GitHub Bot commented on AIRFLOW-4235:
-
nandoquintana commented on pull request #5033: [AIRFLOW-4235] home page dags
table: highlight rows on mouse hover
URL: https://github.com/apache/airflow/pull/5033
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
In wide screens, home page dags table becomes too wide. There is too much
distance between "DAG" and "Links" columns and it is difficult to appreciate
which is the icon you should click.
It would be very useful to highlight row on mouse hover.
This could be fixed very quickly, adding 'table-hover' css class to
table#dags.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> home page dags table: highlight rows on mouse hover
> ---
>
> Key: AIRFLOW-4235
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4235
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
>Affects Versions: 1.10.2
>Reporter: Nando Quintana
>Assignee: Nando Quintana
>Priority: Trivial
> Labels: easyfix, newbie
> Fix For: 1.10.3
>
> Attachments: table_dags_table_hover.png
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> In wide screens, home page dags table becomes too wide. There is too much
> distance between "DAG" and "Links" columns and it is difficult to appreciate
> which is the icon you should click.
> It would be very useful to highlight row on mouse hover.
> This could be fixed very quickly, adding 'table-hover' css class to
> table#dags.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
