[jira] [Commented] (AIRFLOW-5566) Invalid deprecation warning for airflow home specification within config file
[
https://issues.apache.org/jira/browse/AIRFLOW-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009051#comment-17009051
]
ASF GitHub Bot commented on AIRFLOW-5566:
-
stale[bot] commented on pull request #6270: [AIRFLOW-5566] Fix false positive
deprecation warning
URL: https://github.com/apache/airflow/pull/6270
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Invalid deprecation warning for airflow home specification within config file
> -
>
> Key: AIRFLOW-5566
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5566
> Project: Apache Airflow
> Issue Type: Bug
> Components: configuration
>Affects Versions: 1.10.5
>Reporter: Ian Friedman
>Assignee: Ian Friedman
>Priority: Minor
>
> [This deprecation
> warning|https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551-L568]
> is run regardless of whether an 'airflow_home' entry exists in the config
> file when the 'AIRFLOW_HOME' environment variables are set.
> Traceback:
> [config entry check |
> https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551]
> ->
> [config.has_option(...)|https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L296-L304]
> -> [get(...)|
> https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L214-L267]
> in get:
> {code:python}
> option = self._get_env_var_option(section, key)
> if option is not None:
> return option
> {code}
> 'get' returns True, then 'has_option' returns True, which triggers the warning
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5566) Invalid deprecation warning for airflow home specification within config file
[
https://issues.apache.org/jira/browse/AIRFLOW-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945517#comment-16945517
]
ASF GitHub Bot commented on AIRFLOW-5566:
-
friedmanCadre commented on pull request #6270: [AIRFLOW-5566] Fix false
positive deprecation warning
URL: https://github.com/apache/airflow/pull/6270
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Invalid deprecation warning for airflow home specification within config file
> -
>
> Key: AIRFLOW-5566
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5566
> Project: Apache Airflow
> Issue Type: Bug
> Components: configuration
>Affects Versions: 1.10.5
>Reporter: Ian Friedman
>Assignee: Ian Friedman
>Priority: Minor
>
> [This deprecation
> warning|https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551-L568]
> is run regardless of whether an 'airflow_home' entry exists in the config
> file when the 'AIRFLOW_HOME' environment variables are set.
> Traceback:
> [config entry check |
> https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551]
> ->
> [config.has_option(...)|https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L296-L304]
> -> [get(...)|
> https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L214-L267]
> in get:
> {code:python}
> option = self._get_env_var_option(section, key)
> if option is not None:
> return option
> {code}
> 'get' returns True, then 'has_option' returns True, which triggers the warning
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5566) Invalid deprecation warning for airflow home specification within config file
[
https://issues.apache.org/jira/browse/AIRFLOW-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945518#comment-16945518
]
ASF GitHub Bot commented on AIRFLOW-5566:
-
friedmanCadre commented on pull request #6270: [AIRFLOW-5566] Fix false
positive deprecation warning
URL: https://github.com/apache/airflow/pull/6270
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
This PR fixes the following issue:
[This deprecation
warning](https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551-L568)
is run regardless of whether an 'airflow_home' entry exists in the config file
when the 'AIRFLOW_HOME' environment variables are set.
Traceback:
[config entry
check](https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551)
->
[config.has_option(...)](https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L296-L304)
-> [get(...)](
https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L214-L267)
in get:
```
option = self._get_env_var_option(section, key)
if option is not None:
return option
```
'get' returns True, then 'has_option' returns True, which triggers the
warning
This PR adds an additional `file_has_option` method to the
`AirflowConfigParser` that does not check the environment variables for the
specified option.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
The additional method in this PR simply provides a way to access Python's
`ConfigParser` `has_option` method, which was overwritten in the
`AirflowConfigParser` class.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Invalid deprecation warning for airflow home specification within config file
> -
>
> Key: AIRFLOW-5566
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5566
> Project: Apache Airflow
> Issue Type: Bug
> Components: configuration
>Affects Versions: 1.10.5
>Reporter: Ian Friedman
>Assignee: Ian Friedman
>Priority: Minor
>
> [This deprecation
> warning|https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551-L568]
> is run regardless of whether an 'airflow_home' entry exists in the config
> file when the 'AIRFLOW_HOME' environment va
[jira] [Commented] (AIRFLOW-5566) Invalid deprecation warning for airflow home specification within config file
[
https://issues.apache.org/jira/browse/AIRFLOW-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945240#comment-16945240
]
ASF GitHub Bot commented on AIRFLOW-5566:
-
friedmanCadre commented on pull request #6270: [AIRFLOW-5566] Fix false
positive deprecation warning
URL: https://github.com/apache/airflow/pull/6270
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
This PR fixes the following issue:
[This deprecation
warning](https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551-L568)
is run regardless of whether an 'airflow_home' entry exists in the config file
when the 'AIRFLOW_HOME' environment variables are set.
Traceback:
[config entry
check](https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551)
->
[config.has_option(...)](https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L296-L304)
-> [get(...)](
https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L214-L267)
in get:
```
option = self._get_env_var_option(section, key)
if option is not None:
return option
```
'get' returns True, then 'has_option' returns True, which triggers the
warning
This PR adds an additional `file_has_option` method to the
`AirflowConfigParser` that does not check the environment variables for the
specified option.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
The additional method in this PR simply provides a way to access Python's
`ConfigParser` `has_option` method, which was overwritten in the
`AirflowConfigParser` class.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Invalid deprecation warning for airflow home specification within config file
> -
>
> Key: AIRFLOW-5566
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5566
> Project: Apache Airflow
> Issue Type: Bug
> Components: configuration
>Affects Versions: 1.10.5
>Reporter: Ian Friedman
>Assignee: Ian Friedman
>Priority: Minor
>
> [This deprecation
> warning|https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551-L568]
> is run regardless of whether an 'airflow_home' entry exists in the config
> file when the 'AIRFLOW_HOME' environment va
[jira] [Commented] (AIRFLOW-5566) Invalid deprecation warning for airflow home specification within config file
[
https://issues.apache.org/jira/browse/AIRFLOW-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942091#comment-16942091
]
Ian Friedman commented on AIRFLOW-5566:
---
Will do
> Invalid deprecation warning for airflow home specification within config file
> -
>
> Key: AIRFLOW-5566
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5566
> Project: Apache Airflow
> Issue Type: Bug
> Components: configuration
>Affects Versions: 1.10.5
>Reporter: Ian Friedman
>Priority: Minor
>
> [This deprecation
> warning|https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551-L568]
> is run regardless of whether an 'airflow_home' entry exists in the config
> file when the 'AIRFLOW_HOME' environment variables are set.
> Traceback:
> [config entry check |
> https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551]
> ->
> [config.has_option(...)|https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L296-L304]
> -> [get(...)|
> https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L214-L267]
> in get:
> {code:python}
> option = self._get_env_var_option(section, key)
> if option is not None:
> return option
> {code}
> 'get' returns True, then 'has_option' returns True, which triggers the warning
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5566) Invalid deprecation warning for airflow home specification within config file
[
https://issues.apache.org/jira/browse/AIRFLOW-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941172#comment-16941172
]
jack commented on AIRFLOW-5566:
---
Can you PR a fix?
> Invalid deprecation warning for airflow home specification within config file
> -
>
> Key: AIRFLOW-5566
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5566
> Project: Apache Airflow
> Issue Type: Bug
> Components: configuration
>Affects Versions: 1.10.5
>Reporter: Ian Friedman
>Priority: Minor
>
> [This deprecation
> warning|https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551-L568]
> is run regardless of whether an 'airflow_home' entry exists in the config
> file when the 'AIRFLOW_HOME' environment variables are set.
> Traceback:
> [config entry check |
> https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L551]
> ->
> [config.has_option(...)|https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L296-L304]
> -> [get(...)|
> https://github.com/apache/airflow/blob/4d4fda75333b1e6ae4e99b407ab2b1edc0d139d8/airflow/configuration.py#L214-L267]
> in get:
> {code:python}
> option = self._get_env_var_option(section, key)
> if option is not None:
> return option
> {code}
> 'get' returns True, then 'has_option' returns True, which triggers the warning
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
