[
https://issues.apache.org/jira/browse/AIRFLOW-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964524#comment-16964524
]
ASF GitHub Bot commented on AIRFLOW-5823:
-
sekikn commented on pull request #6482: [AIRFLOW-5823] Add a new hook for
ingesting data into Apache Pinot
URL: https://github.com/apache/airflow/pull/6482
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5823
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Currently, Airflow has PinotDbApiHook for querying Pinot,
but there's no specific hook for ingesting data into it.
This PR adds a new hook that provides a minimum set of
pinot-admin.sh subcommands required to ingest offline data.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
I added tests.contrib.hooks.test_pinot_hook.TestPinotAdminHook and
implemented the following tests in it:
- test_add_schema
- test_add_table
- test_create_segment
- test_upload_segment
- test_run_cli_success
- test_run_cli_failure_error_message
- test_run_cli_failure_status_code
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a new hook for ingesting data into Apache Pinot
> ---
>
> Key: AIRFLOW-5823
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5823
> Project: Apache Airflow
> Issue Type: New Feature
> Components: hooks
>Affects Versions: 1.10.5
>Reporter: Kengo Seki
>Assignee: Kengo Seki
>Priority: Major
>
> Currently, Airflow has PinotDbApiHook for querying Pinot, but there's no
> specific hook for ingesting data into it. I'd like to add a new hook which
> provides a minimum set of pinot-admin.sh subcommands required to ingest
> offline data.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
