[jira] [Commented] (AIRFLOW-6382) Extract provide/create session to session module

2020-02-26 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045272#comment-17045272
 ] 

ASF subversion and git services commented on AIRFLOW-6382:
--

Commit c16181308b29369356b2d22567dce7929455613b in airflow's branch 
refs/heads/master from Ash Berlin-Taylor
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=c161813 ]

[AIRFLOW-6382] Add reason for pre-commit rule (#7538)



> Extract provide/create session to session module
> 
>
> Key: AIRFLOW-6382
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6382
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6382) Extract provide/create session to session module

2020-02-26 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045269#comment-17045269
 ] 

ASF GitHub Bot commented on AIRFLOW-6382:
-

ashb commented on pull request #7538: [AIRFLOW-6382] Add reason for pre-commit 
rule
URL: https://github.com/apache/airflow/pull/7538
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Extract provide/create session to session module
> 
>
> Key: AIRFLOW-6382
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6382
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6382) Extract provide/create session to session module

2020-02-25 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044949#comment-17044949
 ] 

ASF GitHub Bot commented on AIRFLOW-6382:
-

ashb commented on pull request #7538: [AIRFLOW-6382] Add reason for pre-commit 
rule
URL: https://github.com/apache/airflow/pull/7538
 
 
   [ci-skip]
   
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Extract provide/create session to session module
> 
>
> Key: AIRFLOW-6382
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6382
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6382) Extract provide/create session to session module

2019-12-28 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004556#comment-17004556
 ] 

ASF GitHub Bot commented on AIRFLOW-6382:
-

nuclearpinguin commented on pull request #6938: [AIRFLOW-6382] Extract 
provide/create session to session module
URL: https://github.com/apache/airflow/pull/6938
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Extract provide/create session to session module
> 
>
> Key: AIRFLOW-6382
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6382
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6382) Extract provide/create session to session module

2019-12-28 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004557#comment-17004557
 ] 

ASF subversion and git services commented on AIRFLOW-6382:
--

Commit d2cbf92290ac6b43930acdc58999f5a48640de49 in airflow's branch 
refs/heads/master from Tomasz Urbaszek
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=d2cbf92 ]

[AIRFLOW-6382] Extract provide/create session to session module (#6938)

Extracting provide_session and create_session to separate module
reduces number of cyclic imports and make a disctinction between
session and database

> Extract provide/create session to session module
> 
>
> Key: AIRFLOW-6382
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6382
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6382) Extract provide/create session to session module

2019-12-28 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004508#comment-17004508
 ] 

ASF GitHub Bot commented on AIRFLOW-6382:
-

nuclearpinguin commented on pull request #6938: [AIRFLOW-6382] Extract 
provide/create session to session module
URL: https://github.com/apache/airflow/pull/6938
 
 
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
 - https://issues.apache.org/jira/browse/AIRFLOW-6382
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   Extracting provide_session and create_session to separate module
   reduces number of cyclic imports and make a disctinction between
   session and database.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
 1. Subject is separated from body by a blank line
 1. Subject is limited to 50 characters (not including Jira issue reference)
 1. Subject does not end with a period
 1. Subject uses the imperative mood ("add", not "adding")
 1. Body wraps at 72 characters
 1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
 - All the public functions and the classes in the PR contain docstrings 
that explain what it does
 - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Extract provide/create session to session module
> 
>
> Key: AIRFLOW-6382
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6382
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)