[jira] [Commented] (AIRFLOW-6398) improve flakey test test_mark_success_no_kill
[ https://issues.apache.org/jira/browse/AIRFLOW-6398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005770#comment-17005770 ] ASF subversion and git services commented on AIRFLOW-6398: -- Commit fed4c72cca7c256d140b993315919ec7a0536145 in airflow's branch refs/heads/v1-10-test from Daniel Standish [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=fed4c72 ] [AIRFLOW-6398] improve flakey test test_mark_success_no_kill (#6959) (cherry picked from commit fd345914c39b9e3534ee2986eef3498c24aff57a) > improve flakey test test_mark_success_no_kill > - > > Key: AIRFLOW-6398 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6398 > Project: Apache Airflow > Issue Type: Bug > Components: tests >Affects Versions: 1.10.7 >Reporter: Daniel Standish >Assignee: Daniel Standish >Priority: Major > > test test_mark_success_no_kill fails regularly > part of the problem is that it depends on timing of a subprocess and database > operations > we can reduce complexity by using python operator instead of bash operator. > currently it uses bash operator to call {{sleep 600}} > this introduces an unnecessary layer of multiprocessing. there is also a bug > in bash operator which was exacerbating the problem [AIRFLOW-6397] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6398) improve flakey test test_mark_success_no_kill
[ https://issues.apache.org/jira/browse/AIRFLOW-6398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005497#comment-17005497 ] ASF GitHub Bot commented on AIRFLOW-6398: - potiuk commented on pull request #6959: [AIRFLOW-6398] improve flakey test test_mark_success_no_kill URL: https://github.com/apache/airflow/pull/6959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > improve flakey test test_mark_success_no_kill > - > > Key: AIRFLOW-6398 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6398 > Project: Apache Airflow > Issue Type: Bug > Components: tests >Affects Versions: 1.10.7 >Reporter: Daniel Standish >Assignee: Daniel Standish >Priority: Major > > test test_mark_success_no_kill fails regularly > part of the problem is that it depends on timing of a subprocess and database > operations > we can reduce complexity by using python operator instead of bash operator. > currently it uses bash operator to call {{sleep 600}} > this introduces an unnecessary layer of multiprocessing. there is also a bug > in bash operator which was exacerbating the problem [AIRFLOW-6397] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6398) improve flakey test test_mark_success_no_kill
[ https://issues.apache.org/jira/browse/AIRFLOW-6398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005498#comment-17005498 ] ASF subversion and git services commented on AIRFLOW-6398: -- Commit fd345914c39b9e3534ee2986eef3498c24aff57a in airflow's branch refs/heads/master from Daniel Standish [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=fd34591 ] [AIRFLOW-6398] improve flakey test test_mark_success_no_kill (#6959) > improve flakey test test_mark_success_no_kill > - > > Key: AIRFLOW-6398 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6398 > Project: Apache Airflow > Issue Type: Bug > Components: tests >Affects Versions: 1.10.7 >Reporter: Daniel Standish >Assignee: Daniel Standish >Priority: Major > > test test_mark_success_no_kill fails regularly > part of the problem is that it depends on timing of a subprocess and database > operations > we can reduce complexity by using python operator instead of bash operator. > currently it uses bash operator to call {{sleep 600}} > this introduces an unnecessary layer of multiprocessing. there is also a bug > in bash operator which was exacerbating the problem [AIRFLOW-6397] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6398) improve flakey test test_mark_success_no_kill
[ https://issues.apache.org/jira/browse/AIRFLOW-6398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005070#comment-17005070 ] ASF GitHub Bot commented on AIRFLOW-6398: - dstandish commented on pull request #6959: [AIRFLOW-6398] improve flakey test test_mark_success_no_kill URL: https://github.com/apache/airflow/pull/6959 test `test_mark_success_no_kill` fails regularly part of the problem is that it depends on timing of a subprocess and database operations. currently it uses bash operator to call sleep 600. this introduces an unnecessary layer of multiprocessing. there is also a bug in bash operator which was exacerbating the problem [AIRFLOW-6397](https://issues.apache.org/jira/browse/AIRFLOW-6397) we can reduce complexity by using python operator instead of bash operator. Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR" - https://issues.apache.org/jira/browse/AIRFLOW-6398 - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue. - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)). - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain docstrings that explain what it does - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > improve flakey test test_mark_success_no_kill > - > > Key: AIRFLOW-6398 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6398 > Project: Apache Airflow > Issue Type: Bug > Components: tests >Affects Versions: 1.10.7 >Reporter: Daniel Standish >Assignee: Daniel Standish >Priority: Major > > test test_mark_success_no_kill fails regularly > part of the problem is that it depends on timing of a subprocess and database > operations > we can reduce complexity by using python operator instead of bash operator. > currently it uses bash operator to call {{sleep 600}} > this introduces an unnecessary layer of multiprocessing. there is also a bug > in bash operator which was exacerbating the problem [AIRFLOW-6397] -- This message was sent by Atlassian Jira (v8.3.4#803005)