[jira] [Commented] (AIRFLOW-6400) pytest not working on Windows
[
https://issues.apache.org/jira/browse/AIRFLOW-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005351#comment-17005351
]
ASF subversion and git services commented on AIRFLOW-6400:
--
Commit 4c62f7b7616b0cdaa421d9e363c3f687208991bd in airflow's branch
refs/heads/v1-10-test from Bjorn Olsen
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=4c62f7b ]
[AIRFLOW-6400] Fix pytest not working on Windows (#6964)
(cherry picked from commit 6dc59d507b6e57603fce2bb2eca91c4f671758e4)
> pytest not working on Windows
> -
>
> Key: AIRFLOW-6400
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6400
> Project: Apache Airflow
> Issue Type: Bug
> Components: tests
>Affects Versions: 1.10.7
>Reporter: Bjorn Olsen
>Assignee: Bjorn Olsen
>Priority: Minor
> Fix For: 1.10.8
>
>
> While Windows isn't supported I am using it to do development and testing.
> This line in conftest.py is causing problems because "HOME" is not an
> environment variable on Windows.
> home = os.environ.get("HOME")
> It can easily be changed to be cross-platform.
> Edit: The same issue is causing test discovery to fail on Windows 10.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6400) pytest not working on Windows
[
https://issues.apache.org/jira/browse/AIRFLOW-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005298#comment-17005298
]
ASF subversion and git services commented on AIRFLOW-6400:
--
Commit 6dc59d507b6e57603fce2bb2eca91c4f671758e4 in airflow's branch
refs/heads/master from Bjorn Olsen
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=6dc59d5 ]
[AIRFLOW-6400] Fix pytest not working on Windows (#6964)
> pytest not working on Windows
> -
>
> Key: AIRFLOW-6400
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6400
> Project: Apache Airflow
> Issue Type: Bug
> Components: tests
>Affects Versions: 1.10.7
>Reporter: Bjorn Olsen
>Assignee: Bjorn Olsen
>Priority: Minor
>
> While Windows isn't supported I am using it to do development and testing.
> This line in conftest.py is causing problems because "HOME" is not an
> environment variable on Windows.
> home = os.environ.get("HOME")
> It can easily be changed to be cross-platform.
> Edit: The same issue is causing test discovery to fail on Windows 10.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6400) pytest not working on Windows
[
https://issues.apache.org/jira/browse/AIRFLOW-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005297#comment-17005297
]
ASF GitHub Bot commented on AIRFLOW-6400:
-
potiuk commented on pull request #6964: [AIRFLOW-6400] Fix pytest not working
on Windows
URL: https://github.com/apache/airflow/pull/6964
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> pytest not working on Windows
> -
>
> Key: AIRFLOW-6400
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6400
> Project: Apache Airflow
> Issue Type: Bug
> Components: tests
>Affects Versions: 1.10.7
>Reporter: Bjorn Olsen
>Assignee: Bjorn Olsen
>Priority: Minor
>
> While Windows isn't supported I am using it to do development and testing.
> This line in conftest.py is causing problems because "HOME" is not an
> environment variable on Windows.
> home = os.environ.get("HOME")
> It can easily be changed to be cross-platform.
> Edit: The same issue is causing test discovery to fail on Windows 10.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6400) pytest not working on Windows
[
https://issues.apache.org/jira/browse/AIRFLOW-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005225#comment-17005225
]
ASF GitHub Bot commented on AIRFLOW-6400:
-
baolsen commented on pull request #6964: [AIRFLOW-6400] Fix pytest not working
on Windows
URL: https://github.com/apache/airflow/pull/6964
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
Pytest wasn't working on Windows as described in JIRA, now it is working.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Minor fix, tested manually on Windows 10. Windows isn't supported anyway so
no need to do further detailed testing.
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> pytest not working on Windows
> -
>
> Key: AIRFLOW-6400
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6400
> Project: Apache Airflow
> Issue Type: Bug
> Components: tests
>Affects Versions: 1.10.7
>Reporter: Bjorn Olsen
>Assignee: Bjorn Olsen
>Priority: Minor
>
> While Windows isn't supported I am using it to do development and testing.
> This line in conftest.py is causing problems because "HOME" is not an
> environment variable on Windows.
> home = os.environ.get("HOME")
> It can easily be changed to be cross-platform.
> Edit: The same issue is causing test discovery to fail on Windows 10.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
