[jira] [Commented] (AIRFLOW-6472) Some of the options we have are long options with single -
[
https://issues.apache.org/jira/browse/AIRFLOW-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048597#comment-17048597
]
ASF subversion and git services commented on AIRFLOW-6472:
--
Commit f85cb8709b4e27f24ccee24e90cfdc779192186d in airflow's branch
refs/heads/master from Jiajie Zhong
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=f85cb87 ]
[AIRFLOW-6472] Correct short and long option in cli (#7148)
* [AIRFLOW-6472] Correct short and long option in cli
* Make Airflow cli short options be single character only
* Make Airflow cli long options be kebab-case style
* Add test for airflow/bin
* Update UPDATING.md
> Some of the options we have are long options with single -
> --
>
> Key: AIRFLOW-6472
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6472
> Project: Apache Airflow
> Issue Type: Improvement
> Components: cli
>Affects Versions: 2.0.0, 1.10.7
>Reporter: Jarek Potiuk
>Assignee: zhongjiajie
>Priority: Major
>
> We have some "short" options that are really "long" ones: namely -int and -sd
> in the run task. This is against the idea of short and long options in Unix
> (and argparse follows that). The main reason to have short options is that
> you can combine short options:
> {{airflow task run -iAlm}}
> When you have more than one letter "short" options this might become quickly
> ambiguous. We do not have -s yet but if we add few more options this might
> become a problem.
> Also in the argparse documentation
> [https://docs.python.org/2/library/argparse.html] it's mentioned that short
> options should be single character only.\
> This should be fixed.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6472) Some of the options we have are long options with single -
[
https://issues.apache.org/jira/browse/AIRFLOW-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048595#comment-17048595
]
ASF GitHub Bot commented on AIRFLOW-6472:
-
potiuk commented on pull request #7148: [AIRFLOW-6472] Correct short and long
option in cli
URL: https://github.com/apache/airflow/pull/7148
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Some of the options we have are long options with single -
> --
>
> Key: AIRFLOW-6472
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6472
> Project: Apache Airflow
> Issue Type: Improvement
> Components: cli
>Affects Versions: 2.0.0, 1.10.7
>Reporter: Jarek Potiuk
>Assignee: zhongjiajie
>Priority: Major
>
> We have some "short" options that are really "long" ones: namely -int and -sd
> in the run task. This is against the idea of short and long options in Unix
> (and argparse follows that). The main reason to have short options is that
> you can combine short options:
> {{airflow task run -iAlm}}
> When you have more than one letter "short" options this might become quickly
> ambiguous. We do not have -s yet but if we add few more options this might
> become a problem.
> Also in the argparse documentation
> [https://docs.python.org/2/library/argparse.html] it's mentioned that short
> options should be single character only.\
> This should be fixed.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6472) Some of the options we have are long options with single -
[
https://issues.apache.org/jira/browse/AIRFLOW-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048596#comment-17048596
]
ASF subversion and git services commented on AIRFLOW-6472:
--
Commit f85cb8709b4e27f24ccee24e90cfdc779192186d in airflow's branch
refs/heads/master from Jiajie Zhong
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=f85cb87 ]
[AIRFLOW-6472] Correct short and long option in cli (#7148)
* [AIRFLOW-6472] Correct short and long option in cli
* Make Airflow cli short options be single character only
* Make Airflow cli long options be kebab-case style
* Add test for airflow/bin
* Update UPDATING.md
> Some of the options we have are long options with single -
> --
>
> Key: AIRFLOW-6472
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6472
> Project: Apache Airflow
> Issue Type: Improvement
> Components: cli
>Affects Versions: 2.0.0, 1.10.7
>Reporter: Jarek Potiuk
>Assignee: zhongjiajie
>Priority: Major
>
> We have some "short" options that are really "long" ones: namely -int and -sd
> in the run task. This is against the idea of short and long options in Unix
> (and argparse follows that). The main reason to have short options is that
> you can combine short options:
> {{airflow task run -iAlm}}
> When you have more than one letter "short" options this might become quickly
> ambiguous. We do not have -s yet but if we add few more options this might
> become a problem.
> Also in the argparse documentation
> [https://docs.python.org/2/library/argparse.html] it's mentioned that short
> options should be single character only.\
> This should be fixed.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6472) Some of the options we have are long options with single -
[
https://issues.apache.org/jira/browse/AIRFLOW-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047167#comment-17047167
]
zhongjiajie commented on AIRFLOW-6472:
--
Related dev mail list
[https://lists.apache.org/thread.html/r95c53953499a236466e0b762dfdadd5ca2ba9d6e2a3516c699a14380%40%3Cdev.airflow.apache.org%3E]
> Some of the options we have are long options with single -
> --
>
> Key: AIRFLOW-6472
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6472
> Project: Apache Airflow
> Issue Type: Improvement
> Components: cli
>Affects Versions: 2.0.0, 1.10.7
>Reporter: Jarek Potiuk
>Assignee: zhongjiajie
>Priority: Major
>
> We have some "short" options that are really "long" ones: namely -int and -sd
> in the run task. This is against the idea of short and long options in Unix
> (and argparse follows that). The main reason to have short options is that
> you can combine short options:
> {{airflow task run -iAlm}}
> When you have more than one letter "short" options this might become quickly
> ambiguous. We do not have -s yet but if we add few more options this might
> become a problem.
> Also in the argparse documentation
> [https://docs.python.org/2/library/argparse.html] it's mentioned that short
> options should be single character only.\
> This should be fixed.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6472) Some of the options we have are long options with single -
[
https://issues.apache.org/jira/browse/AIRFLOW-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014033#comment-17014033
]
ASF GitHub Bot commented on AIRFLOW-6472:
-
zhongjiajie commented on pull request #7148: [AIRFLOW-6472][WIP] Correct short
option in cli
URL: https://github.com/apache/airflow/pull/7148
* Make Airflow cli short options be single character only
* Add test for airflow/bin
* Update UPDATING.md
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- =
JIRA ID*
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
* For document-only changes commit message can start with
`[AIRFLOW-]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Some of the options we have are long options with single -
> --
>
> Key: AIRFLOW-6472
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6472
> Project: Apache Airflow
> Issue Type: Improvement
> Components: cli
>Affects Versions: 2.0.0, 1.10.7
>Reporter: Jarek Potiuk
>Assignee: zhongjiajie
>Priority: Major
>
> We have some "short" options that are really "long" ones: namely -int and -sd
> in the run task. This is against the idea of short and long options in Unix
> (and argparse follows that). The main reason to have short options is that
> you can combine short options:
> {{airflow task run -iAlm}}
> When you have more than one letter "short" options this might become quickly
> ambiguous. We do not have -s yet but if we add few more options this might
> become a problem.
> Also in the argparse documentation
> [https://docs.python.org/2/library/argparse.html] it's mentioned that short
> options should be single character only.\
> This should be fixed.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6472) Some of the options we have are long options with single -
[
https://issues.apache.org/jira/browse/AIRFLOW-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009031#comment-17009031
]
Jarek Potiuk commented on AIRFLOW-6472:
---
Feel free :)!
> Some of the options we have are long options with single -
> --
>
> Key: AIRFLOW-6472
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6472
> Project: Apache Airflow
> Issue Type: Improvement
> Components: cli
>Affects Versions: 2.0.0, 1.10.7
>Reporter: Jarek Potiuk
>Assignee: zhongjiajie
>Priority: Major
>
> We have some "short" options that are really "long" ones: namely -int and -sd
> in the run task. This is against the idea of short and long options in Unix
> (and argparse follows that). The main reason to have short options is that
> you can combine short options:
> {{airflow task run -iAlm}}
> When you have more than one letter "short" options this might become quickly
> ambiguous. We do not have -s yet but if we add few more options this might
> become a problem.
> Also in the argparse documentation
> [https://docs.python.org/2/library/argparse.html] it's mentioned that short
> options should be single character only.\
> This should be fixed.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6472) Some of the options we have are long options with single -
[
https://issues.apache.org/jira/browse/AIRFLOW-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008993#comment-17008993
]
zhongjiajie commented on AIRFLOW-6472:
--
If you don't mind, I will create a PR for this issues [~potiuk]
> Some of the options we have are long options with single -
> --
>
> Key: AIRFLOW-6472
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6472
> Project: Apache Airflow
> Issue Type: Improvement
> Components: cli
>Affects Versions: 2.0.0, 1.10.7
>Reporter: Jarek Potiuk
>Assignee: zhongjiajie
>Priority: Major
>
> We have some "short" options that are really "long" ones: namely -int and -sd
> in the run task. This is against the idea of short and long options in Unix
> (and argparse follows that). The main reason to have short options is that
> you can combine short options:
> {{airflow task run -iAlm}}
> When you have more than one letter "short" options this might become quickly
> ambiguous. We do not have -s yet but if we add few more options this might
> become a problem.
> Also in the argparse documentation
> [https://docs.python.org/2/library/argparse.html] it's mentioned that short
> options should be single character only.\
> This should be fixed.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
