[jira] [Commented] (AIRFLOW-6949) SparkSubitOperator ignores explicit spark.kubernetes.namespace config option

2020-03-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061146#comment-17061146
 ] 

ASF subversion and git services commented on AIRFLOW-6949:
--

Commit 7c1d46a62368d96cd9845b8b77c3cc64b4b041cb in airflow's branch 
refs/heads/v1-10-test from Ash Berlin-Taylor
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=7c1d46a ]

[AIRFLOW-6949] Respect explicit conf to SparkSubmitOperator (#7575)

cherry-picked from b59042b5a


> SparkSubitOperator ignores explicit spark.kubernetes.namespace config option
> 
>
> Key: AIRFLOW-6949
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6949
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: hooks
>Affects Versions: 1.10.9
>Reporter: Ash Berlin-Taylor
>Assignee: Ash Berlin-Taylor
>Priority: Minor
> Fix For: 1.10.10
>
>
> If a user explicitly passes {{spark.kubernetes.namespace}} in the config 
> attribute, we should respect that over what is given in the connection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-6949) SparkSubitOperator ignores explicit spark.kubernetes.namespace config option

2020-03-03 Thread Jarek Potiuk (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050618#comment-17050618
 ] 

Jarek Potiuk commented on AIRFLOW-6949:
---

I removed the cherry-picked commit as it was failing with missing conn_data:

 

commit f8a83a7188c83113c69b9711b9a42e69d2fc6ba7 (polidea/v1-10-test, 
origin/v1-10-test)
Author: Ash Berlin-Taylor 
Date: Fri Feb 28 11:14:21 2020 +

[AIRFLOW-6949] Respect explicit `spark.kubernetes.namespace` conf to 
SparkSubmitOperator (#7575)
 
 This means the value from the Operator/dag file takes precedence over
 the connection
 
 The previous behaviour was to emit one line from the conf arg, but then
 a later one from the connection:
 
 ```
 --conf spark.kubernetes.namespace=airflow \
 --conf spark.kubernetes.namespace=default \
 ```
 
 (cherry picked from commit b59042b5ab083c77ba08ba804df76b7c728815dc)

> SparkSubitOperator ignores explicit spark.kubernetes.namespace config option
> 
>
> Key: AIRFLOW-6949
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6949
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: hooks
>Affects Versions: 1.10.9
>Reporter: Ash Berlin-Taylor
>Assignee: Ash Berlin-Taylor
>Priority: Minor
> Fix For: 1.10.10
>
>
> If a user explicitly passes {{spark.kubernetes.namespace}} in the config 
> attribute, we should respect that over what is given in the connection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-6949) SparkSubitOperator ignores explicit spark.kubernetes.namespace config option

2020-02-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047492#comment-17047492
 ] 

ASF subversion and git services commented on AIRFLOW-6949:
--

Commit f8a83a7188c83113c69b9711b9a42e69d2fc6ba7 in airflow's branch 
refs/heads/v1-10-test from Ash Berlin-Taylor
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=f8a83a7 ]

[AIRFLOW-6949] Respect explicit `spark.kubernetes.namespace` conf to 
SparkSubmitOperator (#7575)

This means the value from the Operator/dag file takes precedence over
the connection

The previous behaviour was to emit one line from the conf arg, but then
a later one from the connection:

```
--conf spark.kubernetes.namespace=airflow \
--conf spark.kubernetes.namespace=default \
```

(cherry picked from commit b59042b5ab083c77ba08ba804df76b7c728815dc)


> SparkSubitOperator ignores explicit spark.kubernetes.namespace config option
> 
>
> Key: AIRFLOW-6949
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6949
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: hooks
>Affects Versions: 1.10.9
>Reporter: Ash Berlin-Taylor
>Assignee: Ash Berlin-Taylor
>Priority: Minor
> Fix For: 1.10.10
>
>
> If a user explicitly passes {{spark.kubernetes.namespace}} in the config 
> attribute, we should respect that over what is given in the connection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-6949) SparkSubitOperator ignores explicit spark.kubernetes.namespace config option

2020-02-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047470#comment-17047470
 ] 

ASF subversion and git services commented on AIRFLOW-6949:
--

Commit 7978bf778fb26f3393fa6456ca5594635a870877 in airflow's branch 
refs/heads/v1-10-test from Fokko Driesprong
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=7978bf7 ]

[AIRFLOW-6949] Respect explicit `spark.kubernetes.namespace` conf to 
SparkSubmitOperator (#7575)

This means the value from the Operator/dag file takes precedence over
the connection

The previous behaviour was to emit one line from the conf arg, but then
a later one from the connection:

```
--conf spark.kubernetes.namespace=airflow \
--conf spark.kubernetes.namespace=default \
```


> SparkSubitOperator ignores explicit spark.kubernetes.namespace config option
> 
>
> Key: AIRFLOW-6949
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6949
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: hooks
>Affects Versions: 1.10.9
>Reporter: Ash Berlin-Taylor
>Assignee: Ash Berlin-Taylor
>Priority: Minor
> Fix For: 1.10.10
>
>
> If a user explicitly passes {{spark.kubernetes.namespace}} in the config 
> attribute, we should respect that over what is given in the connection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-6949) SparkSubitOperator ignores explicit spark.kubernetes.namespace config option

2020-02-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047466#comment-17047466
 ] 

ASF subversion and git services commented on AIRFLOW-6949:
--

Commit b59042b5ab083c77ba08ba804df76b7c728815dc in airflow's branch 
refs/heads/master from Ash Berlin-Taylor
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=b59042b ]

[AIRFLOW-6949] Respect explicit `spark.kubernetes.namespace` conf to 
SparkSubmitOperator (#7575)

This means the value from the Operator/dag file takes precedence over
the connection

The previous behaviour was to emit one line from the conf arg, but then
a later one from the connection:

```
--conf spark.kubernetes.namespace=airflow \
--conf spark.kubernetes.namespace=default \
```

> SparkSubitOperator ignores explicit spark.kubernetes.namespace config option
> 
>
> Key: AIRFLOW-6949
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6949
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: hooks
>Affects Versions: 1.10.9
>Reporter: Ash Berlin-Taylor
>Assignee: Ash Berlin-Taylor
>Priority: Minor
> Fix For: 1.10.10
>
>
> If a user explicitly passes {{spark.kubernetes.namespace}} in the config 
> attribute, we should respect that over what is given in the connection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-6949) SparkSubitOperator ignores explicit spark.kubernetes.namespace config option

2020-02-28 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047462#comment-17047462
 ] 

ASF GitHub Bot commented on AIRFLOW-6949:
-

Fokko commented on pull request #7575: [AIRFLOW-6949] Respect explicit 
`spark.kubernetes.namespace` conf to SparkSubmitOperator
URL: https://github.com/apache/airflow/pull/7575
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SparkSubitOperator ignores explicit spark.kubernetes.namespace config option
> 
>
> Key: AIRFLOW-6949
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6949
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: hooks
>Affects Versions: 1.10.9
>Reporter: Ash Berlin-Taylor
>Assignee: Ash Berlin-Taylor
>Priority: Minor
> Fix For: 1.10.10
>
>
> If a user explicitly passes {{spark.kubernetes.namespace}} in the config 
> attribute, we should respect that over what is given in the connection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AIRFLOW-6949) SparkSubitOperator ignores explicit spark.kubernetes.namespace config option

2020-02-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046981#comment-17046981
 ] 

ASF GitHub Bot commented on AIRFLOW-6949:
-

ashb commented on pull request #7575: [AIRFLOW-6949] Respect explicit 
`spark.kubernetes.namespace` conf to SparkSubmitOperator
URL: https://github.com/apache/airflow/pull/7575
 
 
   This means the value from the Operator/dag file takes precedence over
   the connection
   
   The previous behaviour was to emit one line from the conf arg, but then
   a later one from the connection:
   
   ```
   --conf spark.kubernetes.namespace=airflow \
   --conf spark.kubernetes.namespace=default \
   ```
   
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SparkSubitOperator ignores explicit spark.kubernetes.namespace config option
> 
>
> Key: AIRFLOW-6949
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6949
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: hooks
>Affects Versions: 1.10.9
>Reporter: Ash Berlin-Taylor
>Assignee: Ash Berlin-Taylor
>Priority: Minor
> Fix For: 1.10.10
>
>
> If a user explicitly passes {{spark.kubernetes.namespace}} in the config 
> attribute, we should respect that over what is given in the connection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)