Re: [PR] Yet another attempt to fix flakey `test_disable_logging` test [airflow]

2023-12-27 Thread via GitHub


potiuk commented on PR #36455:
URL: https://github.com/apache/airflow/pull/36455#issuecomment-1870729433

   Looks like the fix worked . Good one @Taragolis ! (though we still do not 
know why it happened :). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Yet another attempt to fix flakey `test_disable_logging` test [airflow]

2023-12-27 Thread via GitHub


potiuk commented on PR #36455:
URL: https://github.com/apache/airflow/pull/36455#issuecomment-1870646930

   merged. Let's see in main first ad then re-apply the GCP backcompat in main 
:) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Yet another attempt to fix flakey `test_disable_logging` test [airflow]

2023-12-27 Thread via GitHub


potiuk merged PR #36455:
URL: https://github.com/apache/airflow/pull/36455


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Yet another attempt to fix flakey `test_disable_logging` test [airflow]

2023-12-27 Thread via GitHub


potiuk commented on PR #36455:
URL: https://github.com/apache/airflow/pull/36455#issuecomment-1870616824

   Reopened with full tests needed 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Yet another attempt to fix flakey `test_disable_logging` test [airflow]

2023-12-27 Thread via GitHub


potiuk closed pull request #36455: Yet another attempt to fix flakey 
`test_disable_logging` test
URL: https://github.com/apache/airflow/pull/36455


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Yet another attempt to fix flakey `test_disable_logging` test [airflow]

2023-12-27 Thread via GitHub


potiuk commented on PR #36455:
URL: https://github.com/apache/airflow/pull/36455#issuecomment-1870582363

   Strange thing it only happened in main and not in any PR and I have no idea 
why yet. But I will also take a look later today to see what difference was 
there 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Yet another attempt to fix flakey `test_disable_logging` test [airflow]

2023-12-27 Thread via GitHub


potiuk commented on PR #36455:
URL: https://github.com/apache/airflow/pull/36455#issuecomment-1870581813

   Let's see. We can merge it and retry the GCP change 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org