[jira] [Created] (AIRFLOW-5643) S3Hook logic is duplicated and could be clearer

2019-10-12 Thread Louis Guitton (Jira)
Louis Guitton created AIRFLOW-5643:
--

 Summary: S3Hook logic is duplicated and could be clearer
 Key: AIRFLOW-5643
 URL: https://issues.apache.org/jira/browse/AIRFLOW-5643
 Project: Apache Airflow
  Issue Type: Improvement
  Components: aws, hooks
Affects Versions: 1.10.5
Reporter: Louis Guitton
Assignee: Louis Guitton


S3Hook.load_bytes is duplicating the logic of S3Hook.load_file_obj

[https://github.com/apache/airflow/blob/master/airflow/hooks/S3_hook.py#L464-L539|https://github.com/apache/airflow/blob/master/airflow/hooks/S3_hook.py#L465-L539]

Instead, we should stay consistent : S3Hook.load_string is already delegating 
the logic to S3Hook.load_bytes, so we can use the same approach to delegate to 
S3Hook.load_file_obj



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work started] (AIRFLOW-5643) S3Hook logic is duplicated and could be clearer

2019-10-12 Thread Louis Guitton (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on AIRFLOW-5643 started by Louis Guitton.
--
> S3Hook logic is duplicated and could be clearer
> ---
>
> Key: AIRFLOW-5643
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5643
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: aws, hooks
>Affects Versions: 1.10.5
>Reporter: Louis Guitton
>Assignee: Louis Guitton
>Priority: Trivial
>
> S3Hook.load_bytes is duplicating the logic of S3Hook.load_file_obj
> [https://github.com/apache/airflow/blob/master/airflow/hooks/S3_hook.py#L464-L539|https://github.com/apache/airflow/blob/master/airflow/hooks/S3_hook.py#L465-L539]
> Instead, we should stay consistent : S3Hook.load_string is already delegating 
> the logic to S3Hook.load_bytes, so we can use the same approach to delegate 
> to S3Hook.load_file_obj



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (AIRFLOW-5742) Move Cloud Vision to providers package

2019-10-24 Thread Louis Guitton (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Louis Guitton reassigned AIRFLOW-5742:
--

Assignee: Louis Guitton

> Move Cloud Vision to providers package
> --
>
> Key: AIRFLOW-5742
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5742
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Assignee: Louis Guitton
>Priority: Minor
>
> Move:
> airflow.gcp.operators.vision -> 
> airflow.providers.google.cloud.operators.vision
> airflow.gcp.hooks.vision -> airflow.providers.google.cloud.hooks.vision
> and also relevant tests and example DAGs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (AIRFLOW-5735) Move airflow.contrib.operators.s3_to_gcs_operator to core

2019-10-27 Thread Louis Guitton (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Louis Guitton reassigned AIRFLOW-5735:
--

Assignee: Louis Guitton

> Move airflow.contrib.operators.s3_to_gcs_operator to core
> -
>
> Key: AIRFLOW-5735
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5735
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Assignee: Louis Guitton
>Priority: Minor
>
> Reference 
> [https://wiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths]
> Move airflow/contrib/operators/s3_to_gcs_operator -> airflow/operators



--
This message was sent by Atlassian Jira
(v8.3.4#803005)