[GitHub] eladkal commented on issue #4325: [AIRFLOW-3528] handle socket exception with SFTPOperator
eladkal commented on issue #4325: [AIRFLOW-3528] handle socket exception with SFTPOperator URL: https://github.com/apache/incubator-airflow/pull/4325#issuecomment-447751519 Can one of the committers please restart the last test? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eladkal commented on issue #4325: [AIRFLOW-3528] handle socket exception with SFTPOperator
eladkal commented on issue #4325: [AIRFLOW-3528] handle socket exception with SFTPOperator URL: https://github.com/apache/incubator-airflow/pull/4325#issuecomment-448238601 > This fix I don't think will do what we want, as I think now this will end up ultimately logging this as a message: > > > Error while transferring None, error: Error while connecting client, error: socket timed out > > (I took a guess at what might be in the OSError). > > Which means we probably need to add some tests, via mocking, that makes `open_sftp` fail with an exception. And then once we have tests we can be sure the error is reported right in this case. I'm not sure what you mean... Since Python 3.3 socket.error is deprecated. It raised OSError instead. https://docs.python.org/3/library/socket.html#socket.error This PR doesn't attempt to solve the problem regarding why the connection fails. It only fix the message in order to avoid confusion. This problem was reported on Slack. @XD-DENG said that he will try to investigate about why the connection fails. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eladkal commented on issue #4325: [AIRFLOW-3528] handle socket exception with SFTPOperator
eladkal commented on issue #4325: [AIRFLOW-3528] handle socket exception with SFTPOperator URL: https://github.com/apache/incubator-airflow/pull/4325#issuecomment-448245307 OK. Got it. In this case I'll leave this to @XD-DENG or whoever wants to pick this up. From what was reported regardless of the error handling the operator doesn't seem to work. This exceed from the scope of what I can help with at this point. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
