[jira] [Commented] (AIRFLOW-1011) Fix bug in BackfillJob._execute() for SubDAGs
[ https://issues.apache.org/jira/browse/AIRFLOW-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954623#comment-15954623 ] ASF subversion and git services commented on AIRFLOW-1011: -- Commit 2bebeaf9554d35710de6eb1b4006157e105ac79b in incubator-airflow's branch refs/heads/v1-8-test from [~jschmid] [ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=2bebeaf ] [AIRFLOW-1011] Fix bug in BackfillJob._execute() for SubDAGs BackfillJob._execute() checks that the next run date is less than or equal to the end date before creating a DAG run and task instances. For SubDAGs, the next run date is not relevant, i.e. schedule_interval can be anything other than None or '@once' and should be ignored. However, current code calculates the next run date for a SubDAG and the condition check mentioned above always fails for SubDAG triggered manually. This change adds a simple check to determine if this is a SubDAG and, if so, sets next run date to DAG run's start date. Closes #2179 from joeschmid/AIRFLOW-1011-fix-bug- backfill-execute-for-subdags (cherry picked from commit 56501e6062df9456f7ac4efe94e21940734dd5bc) Signed-off-by: Bolke de Bruin > Fix bug in BackfillJob._execute() for SubDAGs > - > > Key: AIRFLOW-1011 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1011 > Project: Apache Airflow > Issue Type: Bug > Components: backfill, subdag >Affects Versions: 1.8.0 >Reporter: Joe Schmid >Priority: Blocker > Fix For: 1.8.1 > > Attachments: 1-TopLevelDAGTaskInstancesShownCorrectly.png, > 2-ZoomedSubDAG-NoTaskInstances-v1.8.png, > 3-ZoomedSubDAG-TaskInstances-v1.7.1.3.png, subdag_task_instance_logs.txt, > test_subdag.py > > > The attached test SubDAG is not executed when the parent DAG is triggered > manually. Attached is a simple test DAG that exhibits the issue along with > screenshots showing the UI differences between v1.8 and v1.7.1.3. > Note that if the DAG is run via backfill from command line (e.g. "airflow > backfill Test_SubDAG -s 2017-03-18 -e 2017-03-18") the task instances show up > successfully. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (AIRFLOW-1011) Fix bug in BackfillJob._execute() for SubDAGs
[ https://issues.apache.org/jira/browse/AIRFLOW-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954624#comment-15954624 ] ASF subversion and git services commented on AIRFLOW-1011: -- Commit 2bebeaf9554d35710de6eb1b4006157e105ac79b in incubator-airflow's branch refs/heads/v1-8-test from [~jschmid] [ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=2bebeaf ] [AIRFLOW-1011] Fix bug in BackfillJob._execute() for SubDAGs BackfillJob._execute() checks that the next run date is less than or equal to the end date before creating a DAG run and task instances. For SubDAGs, the next run date is not relevant, i.e. schedule_interval can be anything other than None or '@once' and should be ignored. However, current code calculates the next run date for a SubDAG and the condition check mentioned above always fails for SubDAG triggered manually. This change adds a simple check to determine if this is a SubDAG and, if so, sets next run date to DAG run's start date. Closes #2179 from joeschmid/AIRFLOW-1011-fix-bug- backfill-execute-for-subdags (cherry picked from commit 56501e6062df9456f7ac4efe94e21940734dd5bc) Signed-off-by: Bolke de Bruin > Fix bug in BackfillJob._execute() for SubDAGs > - > > Key: AIRFLOW-1011 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1011 > Project: Apache Airflow > Issue Type: Bug > Components: backfill, subdag >Affects Versions: 1.8.0 >Reporter: Joe Schmid >Priority: Blocker > Fix For: 1.8.1 > > Attachments: 1-TopLevelDAGTaskInstancesShownCorrectly.png, > 2-ZoomedSubDAG-NoTaskInstances-v1.8.png, > 3-ZoomedSubDAG-TaskInstances-v1.7.1.3.png, subdag_task_instance_logs.txt, > test_subdag.py > > > The attached test SubDAG is not executed when the parent DAG is triggered > manually. Attached is a simple test DAG that exhibits the issue along with > screenshots showing the UI differences between v1.8 and v1.7.1.3. > Note that if the DAG is run via backfill from command line (e.g. "airflow > backfill Test_SubDAG -s 2017-03-18 -e 2017-03-18") the task instances show up > successfully. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (AIRFLOW-1011) Fix bug in BackfillJob._execute() for SubDAGs
[ https://issues.apache.org/jira/browse/AIRFLOW-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954620#comment-15954620 ] ASF subversion and git services commented on AIRFLOW-1011: -- Commit 56501e6062df9456f7ac4efe94e21940734dd5bc in incubator-airflow's branch refs/heads/master from [~jschmid] [ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=56501e6 ] [AIRFLOW-1011] Fix bug in BackfillJob._execute() for SubDAGs BackfillJob._execute() checks that the next run date is less than or equal to the end date before creating a DAG run and task instances. For SubDAGs, the next run date is not relevant, i.e. schedule_interval can be anything other than None or '@once' and should be ignored. However, current code calculates the next run date for a SubDAG and the condition check mentioned above always fails for SubDAG triggered manually. This change adds a simple check to determine if this is a SubDAG and, if so, sets next run date to DAG run's start date. Closes #2179 from joeschmid/AIRFLOW-1011-fix-bug- backfill-execute-for-subdags > Fix bug in BackfillJob._execute() for SubDAGs > - > > Key: AIRFLOW-1011 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1011 > Project: Apache Airflow > Issue Type: Bug > Components: backfill, subdag >Affects Versions: 1.8.0 >Reporter: Joe Schmid >Priority: Blocker > Fix For: 1.8.1 > > Attachments: 1-TopLevelDAGTaskInstancesShownCorrectly.png, > 2-ZoomedSubDAG-NoTaskInstances-v1.8.png, > 3-ZoomedSubDAG-TaskInstances-v1.7.1.3.png, subdag_task_instance_logs.txt, > test_subdag.py > > > The attached test SubDAG is not executed when the parent DAG is triggered > manually. Attached is a simple test DAG that exhibits the issue along with > screenshots showing the UI differences between v1.8 and v1.7.1.3. > Note that if the DAG is run via backfill from command line (e.g. "airflow > backfill Test_SubDAG -s 2017-03-18 -e 2017-03-18") the task instances show up > successfully. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (AIRFLOW-1011) Fix bug in BackfillJob._execute() for SubDAGs
[ https://issues.apache.org/jira/browse/AIRFLOW-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954621#comment-15954621 ] ASF subversion and git services commented on AIRFLOW-1011: -- Commit 56501e6062df9456f7ac4efe94e21940734dd5bc in incubator-airflow's branch refs/heads/master from [~jschmid] [ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=56501e6 ] [AIRFLOW-1011] Fix bug in BackfillJob._execute() for SubDAGs BackfillJob._execute() checks that the next run date is less than or equal to the end date before creating a DAG run and task instances. For SubDAGs, the next run date is not relevant, i.e. schedule_interval can be anything other than None or '@once' and should be ignored. However, current code calculates the next run date for a SubDAG and the condition check mentioned above always fails for SubDAG triggered manually. This change adds a simple check to determine if this is a SubDAG and, if so, sets next run date to DAG run's start date. Closes #2179 from joeschmid/AIRFLOW-1011-fix-bug- backfill-execute-for-subdags > Fix bug in BackfillJob._execute() for SubDAGs > - > > Key: AIRFLOW-1011 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1011 > Project: Apache Airflow > Issue Type: Bug > Components: backfill, subdag >Affects Versions: 1.8.0 >Reporter: Joe Schmid >Priority: Blocker > Fix For: 1.8.1 > > Attachments: 1-TopLevelDAGTaskInstancesShownCorrectly.png, > 2-ZoomedSubDAG-NoTaskInstances-v1.8.png, > 3-ZoomedSubDAG-TaskInstances-v1.7.1.3.png, subdag_task_instance_logs.txt, > test_subdag.py > > > The attached test SubDAG is not executed when the parent DAG is triggered > manually. Attached is a simple test DAG that exhibits the issue along with > screenshots showing the UI differences between v1.8 and v1.7.1.3. > Note that if the DAG is run via backfill from command line (e.g. "airflow > backfill Test_SubDAG -s 2017-03-18 -e 2017-03-18") the task instances show up > successfully. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
