[jira] [Commented] (AIRFLOW-2402) Airflow 1.10 Logs UI throws oops error

2018-09-02 Thread Apache Spark (JIRA) 


[ 
https://issues.apache.org/jira/browse/AIRFLOW-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601472#comment-16601472
 ] 

Apache Spark commented on AIRFLOW-2402:
---

User 'yrqls21' has created a pull request for this issue:
https://github.com/apache/incubator-airflow/pull/3319

> Airflow 1.10 Logs UI throws oops error
> --
>
> Key: AIRFLOW-2402
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2402
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: authentication, ui
>Affects Versions: 1.10.0
>Reporter: Ramki Subramanian
>Assignee: Kevin Yang
>Priority: Major
> Fix For: 2.0.0
>
>
> Hi,
> I am getting an error at
> [incubator-airflow/airflow/www_rbac/views.py|https://github.com/apache/incubator-airflow/blob/4d64ad4928f0188f7532936e8da6612f5ec7170d/airflow/www_rbac/views.py#L454]
> Line 454 in 
> [4d64ad4|https://github.com/apache/incubator-airflow/commit/4d64ad4928f0188f7532936e8da6612f5ec7170d]
> | |logs[i] = log.decode('utf-8')|
>  
> {{/home/user/lib/python2.7/site-packages/airflow/www_rbac/views.py", line 
> 454, in log logs[i] = log.decode('utf-8') AttributeError: 'list' object has 
> no attribute 'decode' }}
> Not sure if someone is already looking into this, or I am missing some config?
> Branch : 1.10_test
> More Info here:
> [https://github.com/apache/incubator-airflow/commit/05e1861e24de42f9a2c649cd93041c5c744504e1#diff-77df5adb32d964f37748c4557ffb3c4c]
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AIRFLOW-2402) Airflow 1.10 Logs UI throws oops error

2018-05-03 Thread Ramki Subramanian (JIRA) 

[ 
https://issues.apache.org/jira/browse/AIRFLOW-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463157#comment-16463157
 ] 

Ramki Subramanian commented on AIRFLOW-2402:


I believe the 'read' method of file task handler returns logs and metadatas. 
https://github.com/apache/incubator-airflow/blob/master/airflow/utils/log/file_task_handler.py#L168

But in www_rbac/views.py
https://github.com/apache/incubator-airflow/blob/master/airflow/www_rbac/views.py#L447
I believe just by changing like below, things work smooth.

```
 logs, metadatas = handler.read(ti)
```

> Airflow 1.10 Logs UI throws oops error
> --
>
> Key: AIRFLOW-2402
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2402
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: authentication, ui
>Affects Versions: 1.10.0
>Reporter: Ramki Subramanian
>Assignee: Ramki Subramanian
>Priority: Major
> Fix For: 1.10.0
>
>
> Hi,
> I am getting an error at
> [incubator-airflow/airflow/www_rbac/views.py|https://github.com/apache/incubator-airflow/blob/4d64ad4928f0188f7532936e8da6612f5ec7170d/airflow/www_rbac/views.py#L454]
> Line 454 in 
> [4d64ad4|https://github.com/apache/incubator-airflow/commit/4d64ad4928f0188f7532936e8da6612f5ec7170d]
> | |logs[i] = log.decode('utf-8')|
>  
> {{/home/user/lib/python2.7/site-packages/airflow/www_rbac/views.py", line 
> 454, in log logs[i] = log.decode('utf-8') AttributeError: 'list' object has 
> no attribute 'decode' }}
> Not sure if someone is already looking into this, or I am missing some config?
> Branch : 1.10_test
> More Info here:
> [https://github.com/apache/incubator-airflow/commit/05e1861e24de42f9a2c649cd93041c5c744504e1#diff-77df5adb32d964f37748c4557ffb3c4c]
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AIRFLOW-2402) Airflow 1.10 Logs UI throws oops error

2018-05-03 Thread Kevin Yang (JIRA) 

[ 
https://issues.apache.org/jira/browse/AIRFLOW-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463393#comment-16463393
 ] 

Kevin Yang commented on AIRFLOW-2402:
-

Hi [~rsubra13], I believe the problem was introduced by my previous 
[PR|[https://github.com/apache/incubator-airflow/pull/3214],] I think you can 
copy/paste the changesin the PR on www/views.py into www_rbac/views.py

 

I don't have rbac set up on my side but if you want me to do it you can assign 
this ticket to me and I'll follow through. Otherwise you can tag be in the PR, 
I'll review in on a high priority base.

 

Cheers,

Kevin Y

> Airflow 1.10 Logs UI throws oops error
> --
>
> Key: AIRFLOW-2402
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2402
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: authentication, ui
>Affects Versions: 1.10.0
>Reporter: Ramki Subramanian
>Assignee: Ramki Subramanian
>Priority: Major
> Fix For: 1.10.0
>
>
> Hi,
> I am getting an error at
> [incubator-airflow/airflow/www_rbac/views.py|https://github.com/apache/incubator-airflow/blob/4d64ad4928f0188f7532936e8da6612f5ec7170d/airflow/www_rbac/views.py#L454]
> Line 454 in 
> [4d64ad4|https://github.com/apache/incubator-airflow/commit/4d64ad4928f0188f7532936e8da6612f5ec7170d]
> | |logs[i] = log.decode('utf-8')|
>  
> {{/home/user/lib/python2.7/site-packages/airflow/www_rbac/views.py", line 
> 454, in log logs[i] = log.decode('utf-8') AttributeError: 'list' object has 
> no attribute 'decode' }}
> Not sure if someone is already looking into this, or I am missing some config?
> Branch : 1.10_test
> More Info here:
> [https://github.com/apache/incubator-airflow/commit/05e1861e24de42f9a2c649cd93041c5c744504e1#diff-77df5adb32d964f37748c4557ffb3c4c]
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AIRFLOW-2402) Airflow 1.10 Logs UI throws oops error

2018-05-29 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/AIRFLOW-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494137#comment-16494137
 ] 

ASF subversion and git services commented on AIRFLOW-2402:
--

Commit 7c34354427f8c047b2cfb3f472a38bc50fe91d45 in incubator-airflow's branch 
refs/heads/master from [~kevinyang]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=7c34354 ]

[AIRFLOW-2402] Fix RBAC task log

Closes #3319 from yrqls21/kevin_yang_fix_rbac_view


> Airflow 1.10 Logs UI throws oops error
> --
>
> Key: AIRFLOW-2402
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2402
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: authentication, ui
>Affects Versions: 1.10.0
>Reporter: Ramki Subramanian
>Assignee: Kevin Yang
>Priority: Major
> Fix For: 2.0.0
>
>
> Hi,
> I am getting an error at
> [incubator-airflow/airflow/www_rbac/views.py|https://github.com/apache/incubator-airflow/blob/4d64ad4928f0188f7532936e8da6612f5ec7170d/airflow/www_rbac/views.py#L454]
> Line 454 in 
> [4d64ad4|https://github.com/apache/incubator-airflow/commit/4d64ad4928f0188f7532936e8da6612f5ec7170d]
> | |logs[i] = log.decode('utf-8')|
>  
> {{/home/user/lib/python2.7/site-packages/airflow/www_rbac/views.py", line 
> 454, in log logs[i] = log.decode('utf-8') AttributeError: 'list' object has 
> no attribute 'decode' }}
> Not sure if someone is already looking into this, or I am missing some config?
> Branch : 1.10_test
> More Info here:
> [https://github.com/apache/incubator-airflow/commit/05e1861e24de42f9a2c649cd93041c5c744504e1#diff-77df5adb32d964f37748c4557ffb3c4c]
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)