[GitHub] [ambari-metrics] lucasbak commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics
lucasbak commented on PR #75: URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1330627068 For the version, the 2.1.4 in `pom.xml` comes from commit forwarding, we can set `2.1.4` everywhere -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
[GitHub] [ambari-metrics] lucasbak commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics
lucasbak commented on PR #75: URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1330504350 It comes from the parse-package-release id plugin ``` regex: ^([0-9]+)\.([0-9]+)\.([0-9]+)\.([0-9]+)(\.|-)((([a-zA-Z]+)?([0-9]+))|(SNAPSHOT)).* version: 2.0.0.0-SNAPSHOT replacement: $7 ``` @timyuer I propose we replace the regex by `^([0-9]+)\.([0-9]+)\.([0-9]+)\.([0-9]+)((\.|-)(([0-9]+)|(SNAPSHOT)|(techwin)).*)?` as in `Ambari`. so replacement $7 matches the release (Snapshot here) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
[GitHub] [ambari-metrics] lucasbak commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics
lucasbak commented on PR #75: URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1330473563 @timyuer it's because you need to specify which release it is. For example for releasing 2.7.0.0 It's from rpm-maven-plugin ```bash mvn clean install rpm:rpm -Dpackage-release=2.7.7 -DskipTests` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
[GitHub] [ambari-metrics] lucasbak commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics
lucasbak commented on PR #75: URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1328342958 @timyuer thanks for the example, I have added in both files the Apache License -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
[GitHub] [ambari-metrics] lucasbak commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics
lucasbak commented on PR #75: URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1328091417 thanks for the review @timyuer in which format should I add the license ? the [](https://opensource.org/licenses/Apache-2.0) badge is in the README.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@ambari.apache.org For additional commands, e-mail: commits-h...@ambari.apache.org
