ambari git commit: AMBARI-18075. Add UT for widgets configs (onechiporenko)

2016-09-14 Thread onechiporenko 
Repository: ambari
Updated Branches:
  refs/heads/branch-2.5 d4cec42ee -> 1b25a463d


AMBARI-18075. Add UT for widgets configs (onechiporenko)


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/1b25a463
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/1b25a463
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/1b25a463

Branch: refs/heads/branch-2.5
Commit: 1b25a463d55c2f1b5236b5834fbddf51327e4566
Parents: d4cec42
Author: Oleg Nechiporenko 
Authored: Tue Aug 9 11:12:13 2016 +0300
Committer: Oleg Nechiporenko 
Committed: Wed Sep 14 14:31:21 2016 +0300

--
 .../configs/widgets/config_widget_view_test.js  | 313 +++
 1 file changed, 313 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/ambari/blob/1b25a463/ambari-web/test/views/common/configs/widgets/config_widget_view_test.js
--
diff --git 
a/ambari-web/test/views/common/configs/widgets/config_widget_view_test.js 
b/ambari-web/test/views/common/configs/widgets/config_widget_view_test.js
index f7efd7f..abbc262 100644
--- a/ambari-web/test/views/common/configs/widgets/config_widget_view_test.js
+++ b/ambari-web/test/views/common/configs/widgets/config_widget_view_test.js
@@ -43,6 +43,8 @@ describe('App.ConfigWidgetView', function () {
 
   App.TestAliases.testAsComputedOr(getView(), 'doNotShowWidget', 
['isPropertyUndefined', 'config.showAsTextBox']);
 
+  App.TestAliases.testAsComputedEqual(getView(), 'isPropertyUndefined', 
'config.value', 'Undefined');
+
   describe('#undoAllowed', function () {
 
 Em.A([
@@ -319,4 +321,315 @@ describe('App.ConfigWidgetView', function () {
 
   });
 
+  describe('#showFinalConfig', function () {
+
+[
+  {
+config: {
+  isFinal: true,
+  isNotEditable: true,
+  isHover: true
+},
+e: true
+  },
+  {
+config: {
+  isFinal: true,
+  isNotEditable: false,
+  isHover: true
+},
+e: true
+  },{
+config: {
+  isFinal: true,
+  isNotEditable: true,
+  isHover: false
+},
+e: true
+  },{
+config: {
+  isFinal: true,
+  isNotEditable: false,
+  isHover: false
+},
+e: true
+  },
+  {
+config: {
+  isFinal: false,
+  isNotEditable: true,
+  isHover: true
+},
+e: false
+  },
+  {
+config: {
+  isFinal: false,
+  isNotEditable: false,
+  isHover: true
+},
+e: false
+  },{
+  config: {
+isFinal: false,
+isNotEditable: true,
+isHover: false
+  },
+  e: false
+},{
+  config: {
+isFinal: false,
+isNotEditable: false,
+isHover: false
+  },
+  e: false
+}
+].forEach(function (test) {
+
+  it(JSON.stringify(test.config), function () {
+view.set('config', Em.Object.create(test.config));
+expect(view.get('showFinalConfig')).to.be.equal(test.e);
+  });
+
+})
+
+  });
+
+  describe('#toggleFinalFlag', function () {
+
+[
+  {isNotEditable: true, isFinal: false},
+  {isNotEditable: false, isFinal: true}
+].forEach(function (test) {
+  it('config.isNotEditable ' + test.isNotEditable, function () {
+var config = Em.Object.create({isNotEditable: test.isNotEditable, 
isFinal: false});
+view.toggleFinalFlag({context: config});
+expect(config.get('isFinal')).to.be.equal(test.isFinal);
+  });
+});
+
+  });
+
+  describe('#issueView', function () {
+
+beforeEach(function () {
+  this.issueView = getView().get('issueView').create({config: 
Em.Object.create()});
+  sinon.stub(App, 'tooltip', Em.K);
+});
+
+afterEach(function () {
+  App.tooltip.restore();
+});
+
+describe('#didInsertElement', function () {
+
+  beforeEach(function () {
+this.issueView.errorLevelObserver = Em.K;
+sinon.spy(this.issueView, 'addObserver');
+  });
+
+  afterEach(function () {
+this.issueView.addObserver.restore();
+  });
+
+  [
+'issuedConfig.warnMessage',
+'issuedConfig.errorMessage',
+'parentView.isPropertyUndefined'
+  ].forEach(function (field) {
+it('add observer for ' + field, function () {
+  this.issueView.didInsertElement();
+  expect(this.issueView.addObserver.calledWith(field, this.issueView, 
this.issueView.errorLevelObserver)).to.be.true;
+});
+  });
+
+});
+
+describe('#willDestroyElement', function () {
+
+  beforeEach(function () {
+

ambari git commit: AMBARI-18075. Add UT for widgets configs (onechiporenko)

2016-08-09 Thread onechiporenko 
Repository: ambari
Updated Branches:
  refs/heads/trunk 81797a69f -> 12e207218


AMBARI-18075. Add UT for widgets configs (onechiporenko)


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/12e20721
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/12e20721
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/12e20721

Branch: refs/heads/trunk
Commit: 12e20721897abcc7c5edc9bf1cf1b89eb4e64bb1
Parents: 81797a6
Author: Oleg Nechiporenko 
Authored: Tue Aug 9 11:12:13 2016 +0300
Committer: Oleg Nechiporenko 
Committed: Tue Aug 9 11:12:13 2016 +0300

--
 .../configs/widgets/config_widget_view_test.js  | 313 +++
 1 file changed, 313 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/ambari/blob/12e20721/ambari-web/test/views/common/configs/widgets/config_widget_view_test.js
--
diff --git 
a/ambari-web/test/views/common/configs/widgets/config_widget_view_test.js 
b/ambari-web/test/views/common/configs/widgets/config_widget_view_test.js
index f7efd7f..abbc262 100644
--- a/ambari-web/test/views/common/configs/widgets/config_widget_view_test.js
+++ b/ambari-web/test/views/common/configs/widgets/config_widget_view_test.js
@@ -43,6 +43,8 @@ describe('App.ConfigWidgetView', function () {
 
   App.TestAliases.testAsComputedOr(getView(), 'doNotShowWidget', 
['isPropertyUndefined', 'config.showAsTextBox']);
 
+  App.TestAliases.testAsComputedEqual(getView(), 'isPropertyUndefined', 
'config.value', 'Undefined');
+
   describe('#undoAllowed', function () {
 
 Em.A([
@@ -319,4 +321,315 @@ describe('App.ConfigWidgetView', function () {
 
   });
 
+  describe('#showFinalConfig', function () {
+
+[
+  {
+config: {
+  isFinal: true,
+  isNotEditable: true,
+  isHover: true
+},
+e: true
+  },
+  {
+config: {
+  isFinal: true,
+  isNotEditable: false,
+  isHover: true
+},
+e: true
+  },{
+config: {
+  isFinal: true,
+  isNotEditable: true,
+  isHover: false
+},
+e: true
+  },{
+config: {
+  isFinal: true,
+  isNotEditable: false,
+  isHover: false
+},
+e: true
+  },
+  {
+config: {
+  isFinal: false,
+  isNotEditable: true,
+  isHover: true
+},
+e: false
+  },
+  {
+config: {
+  isFinal: false,
+  isNotEditable: false,
+  isHover: true
+},
+e: false
+  },{
+  config: {
+isFinal: false,
+isNotEditable: true,
+isHover: false
+  },
+  e: false
+},{
+  config: {
+isFinal: false,
+isNotEditable: false,
+isHover: false
+  },
+  e: false
+}
+].forEach(function (test) {
+
+  it(JSON.stringify(test.config), function () {
+view.set('config', Em.Object.create(test.config));
+expect(view.get('showFinalConfig')).to.be.equal(test.e);
+  });
+
+})
+
+  });
+
+  describe('#toggleFinalFlag', function () {
+
+[
+  {isNotEditable: true, isFinal: false},
+  {isNotEditable: false, isFinal: true}
+].forEach(function (test) {
+  it('config.isNotEditable ' + test.isNotEditable, function () {
+var config = Em.Object.create({isNotEditable: test.isNotEditable, 
isFinal: false});
+view.toggleFinalFlag({context: config});
+expect(config.get('isFinal')).to.be.equal(test.isFinal);
+  });
+});
+
+  });
+
+  describe('#issueView', function () {
+
+beforeEach(function () {
+  this.issueView = getView().get('issueView').create({config: 
Em.Object.create()});
+  sinon.stub(App, 'tooltip', Em.K);
+});
+
+afterEach(function () {
+  App.tooltip.restore();
+});
+
+describe('#didInsertElement', function () {
+
+  beforeEach(function () {
+this.issueView.errorLevelObserver = Em.K;
+sinon.spy(this.issueView, 'addObserver');
+  });
+
+  afterEach(function () {
+this.issueView.addObserver.restore();
+  });
+
+  [
+'issuedConfig.warnMessage',
+'issuedConfig.errorMessage',
+'parentView.isPropertyUndefined'
+  ].forEach(function (field) {
+it('add observer for ' + field, function () {
+  this.issueView.didInsertElement();
+  expect(this.issueView.addObserver.calledWith(field, this.issueView, 
this.issueView.errorLevelObserver)).to.be.true;
+});
+  });
+
+});
+
+describe('#willDestroyElement', function () {
+
+  beforeEach(function () {
+this.issueView.errorLevelObserver =