[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 43785d6b97c Updating config from bot 43785d6b97c is described below commit 43785d6b97c3f0f5a73160e726e5e0e0b9f3ea78 Author: github-actions AuthorDate: Wed Apr 6 07:04:50 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new bb9f5483bc0 Updating config from bot bb9f5483bc0 is described below commit bb9f5483bc086a61515391351c5ce40930cf159b Author: github-actions AuthorDate: Wed Apr 6 07:34:28 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 14f59846aa4 Updating config from bot 14f59846aa4 is described below commit 14f59846aa403dc63a24e7c219a1ea942c89c911 Author: github-actions AuthorDate: Wed Apr 6 08:10:12 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 43679187f88 Updating config from bot 43679187f88 is described below commit 43679187f887f821df6a2633278bdd0bc7fc9114 Author: github-actions AuthorDate: Wed Apr 6 08:38:53 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new d25734540d5 Updating config from bot d25734540d5 is described below commit d25734540d5446a48769401e669fe22c19b7c8ff Author: github-actions AuthorDate: Wed Apr 6 09:09:23 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 621cddfb7c1 Updating config from bot 621cddfb7c1 is described below commit 621cddfb7c146d67f5938b6c8feebca84af92d47 Author: github-actions AuthorDate: Wed Apr 6 09:49:15 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 0335433a22d Updating config from bot 0335433a22d is described below commit 0335433a22d9ddcee7ad685b59b28a7741b9be3a Author: github-actions AuthorDate: Wed Apr 6 10:09:45 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 3b1a17a635d Updating config from bot 3b1a17a635d is described below commit 3b1a17a635d0e72513c44ab5a761ae197c0ef9ac Author: github-actions AuthorDate: Wed Apr 6 10:38:39 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 21a27ecc7c0 Updating config from bot 21a27ecc7c0 is described below commit 21a27ecc7c0db6aba383ff737a14aec6933deae1 Author: github-actions AuthorDate: Wed Apr 6 11:09:13 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 3cc1e9c848c Updating config from bot 3cc1e9c848c is described below commit 3cc1e9c848cd24e440105f855d2dfda92a8b853f Author: github-actions AuthorDate: Wed Apr 6 11:34:00 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new a39c5ca4755 Updating config from bot a39c5ca4755 is described below commit a39c5ca4755cb3086e2255859a3dff182397d7d3 Author: github-actions AuthorDate: Wed Apr 6 12:10:44 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 24ad8d3e2b0 Updating config from bot 24ad8d3e2b0 is described below commit 24ad8d3e2b04b3835385afbadb6c2d6241884e11 Author: github-actions AuthorDate: Wed Apr 6 12:50:16 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 9b1663c6dee Updating config from bot 9b1663c6dee is described below commit 9b1663c6deee8c62efb0321b58f55a15ff4919df Author: github-actions AuthorDate: Wed Apr 6 12:57:06 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 074633fd86c Updating config from bot 074633fd86c is described below commit 074633fd86cf03af922bdcf8c5642d21a3cd0acf Author: github-actions AuthorDate: Wed Apr 6 13:16:24 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new f0a7b6f2249 Updating config from bot f0a7b6f2249 is described below commit f0a7b6f2249158f2e3c39e30aeb25ea1d527af60 Author: github-actions AuthorDate: Wed Apr 6 13:42:24 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 89c551e0e2c Updating config from bot 89c551e0e2c is described below commit 89c551e0e2c174dda967e5c5f19ed2792b8434fd Author: github-actions AuthorDate: Wed Apr 6 14:08:32 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 11914b9389c Updating config from bot 11914b9389c is described below commit 11914b9389cf0d153e5755736ae19deb2b354241 Author: github-actions AuthorDate: Wed Apr 6 15:09:46 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 132ccfd8c05 Updating config from bot 132ccfd8c05 is described below commit 132ccfd8c052ac94f0cbeb36e1699b4ccc934aac Author: github-actions AuthorDate: Wed Apr 6 15:38:54 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 7211958ca10 Updating config from bot 7211958ca10 is described below commit 7211958ca100b1d647ebfbf05c287b10df07c676 Author: github-actions AuthorDate: Wed Apr 6 15:49:00 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 4d15d18d275 Updating config from bot 4d15d18d275 is described below commit 4d15d18d2751b60ad0ed2bfdb3e4442adf6bfbd7 Author: github-actions AuthorDate: Wed Apr 6 15:50:49 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 8d6afc62ff7 Updating config from bot 8d6afc62ff7 is described below commit 8d6afc62ff748be761cf13d318806a8f608e5fe7 Author: github-actions AuthorDate: Wed Apr 6 16:09:25 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new bf8daac624a Updating config from bot bf8daac624a is described below commit bf8daac624a39aaa2225a9128d05f76f1df93c3f Author: github-actions AuthorDate: Wed Apr 6 16:42:47 2022 + Updating config from bot --- scripts/ci/pr-bot/state/pr-state/pr-17285.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ci/pr-bot/state/pr-state/pr-17285.json b/scripts/ci/pr-bot/state/pr-state/pr-17285.json index aa3638a74ec..2deda2c6f85 100644 --- a/scripts/ci/pr-bot/state/pr-state/pr-17285.json +++ b/scripts/ci/pr-bot/state/pr-state/pr-17285.json @@ -1,7 +1,7 @@ { "commentedAboutFailingChecks": false, "reviewersAssignedForLabels": { -"go": "riteshghorse" +"go": "damccorm" }, "nextAction": "Reviewers", "stopReviewerNotifications": false,
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 671b3d7a332 Updating config from bot 671b3d7a332 is described below commit 671b3d7a332858e3acb3b533b6d5450f51408c59 Author: github-actions AuthorDate: Wed Apr 6 16:42:49 2022 + Updating config from bot --- scripts/ci/pr-bot/state/reviewers-for-label-go.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ci/pr-bot/state/reviewers-for-label-go.json b/scripts/ci/pr-bot/state/reviewers-for-label-go.json index b7221b287c5..73c92f099e4 100644 --- a/scripts/ci/pr-bot/state/reviewers-for-label-go.json +++ b/scripts/ci/pr-bot/state/reviewers-for-label-go.json @@ -4,7 +4,7 @@ "lostluck": 1649099335060, "jrmccluskey": 1649084918234, "youngoli": 1649099329583, -"damccorm": 1649095934698, +"damccorm": 1649263365896, "riteshghorse": 1649185461994 } } \ No newline at end of file
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 6dd3008cbab Updating config from bot 6dd3008cbab is described below commit 6dd3008cbab362e742a4ab60c1fc2602607489ef Author: github-actions AuthorDate: Wed Apr 6 16:42:52 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 860775be24a Updating config from bot 860775be24a is described below commit 860775be24aa40cd95f647ace5142dd5843459ad Author: github-actions AuthorDate: Wed Apr 6 16:46:34 2022 + Updating config from bot --- scripts/ci/pr-bot/state/pr-state/pr-17285.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ci/pr-bot/state/pr-state/pr-17285.json b/scripts/ci/pr-bot/state/pr-state/pr-17285.json index 2deda2c6f85..7c0d6dd803d 100644 --- a/scripts/ci/pr-bot/state/pr-state/pr-17285.json +++ b/scripts/ci/pr-bot/state/pr-state/pr-17285.json @@ -4,7 +4,7 @@ "go": "damccorm" }, "nextAction": "Reviewers", - "stopReviewerNotifications": false, + "stopReviewerNotifications": true, "remindAfterTestsPass": [], "committerAssigned": false } \ No newline at end of file
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new da214a22010 Updating config from bot da214a22010 is described below commit da214a22010233533ea0b56fef53cbe6eed8 Author: github-actions AuthorDate: Wed Apr 6 17:11:16 2022 + Updating config from bot
[beam] branch master updated: Avoid pr-bot state desync (#17299)
This is an automated email from the ASF dual-hosted git repository. lostluck pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new 3f601400fc8 Avoid pr-bot state desync (#17299) 3f601400fc8 is described below commit 3f601400fc88961533313e908527ccb73bc6d07c Author: Danny McCormick AuthorDate: Wed Apr 6 13:15:54 2022 -0400 Avoid pr-bot state desync (#17299) --- scripts/ci/pr-bot/processNewPrs.ts | 2 ++ scripts/ci/pr-bot/shared/persistentState.ts | 9 +++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/scripts/ci/pr-bot/processNewPrs.ts b/scripts/ci/pr-bot/processNewPrs.ts index 84351adc0ca..d3d0b2d5524 100644 --- a/scripts/ci/pr-bot/processNewPrs.ts +++ b/scripts/ci/pr-bot/processNewPrs.ts @@ -225,6 +225,8 @@ async function processPull( return; } } +// If none of the approvers were assigned to the pr, no-op. +return; } let checkState = await getChecksStatus(REPO_OWNER, REPO, pull.head.sha); diff --git a/scripts/ci/pr-bot/shared/persistentState.ts b/scripts/ci/pr-bot/shared/persistentState.ts index e440d2ae3d8..e2bf2f9354e 100644 --- a/scripts/ci/pr-bot/shared/persistentState.ts +++ b/scripts/ci/pr-bot/shared/persistentState.ts @@ -115,12 +115,9 @@ export class PersistentState { console.log( "Couldnt find branch pr-bot-state in origin, trying to create it" ); - try { -await exec.exec("git checkout -b pr-bot-state"); - } catch { -console.log("Creating branch failed, trying a simple checkout."); -await exec.exec("git checkout pr-bot-state"); - } + await exec.exec("git checkout -b pr-bot-state"); + // Ensure that if we've created or just checked out the branch that we can also push to it + await exec.exec("git push origin pr-bot-state"); } this.switchedBranch = true; }
[beam] branch master updated: [BEAM-14259] Clean up staticcheck warnings in the exec package (#17285)
This is an automated email from the ASF dual-hosted git repository. lostluck pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new 2a8a1ac0f2d [BEAM-14259] Clean up staticcheck warnings in the exec package (#17285) 2a8a1ac0f2d is described below commit 2a8a1ac0f2db04c64b9e655a73b673e61e02de2c Author: Jack McCluskey <34928439+jrmcclus...@users.noreply.github.com> AuthorDate: Wed Apr 6 13:34:26 2022 -0400 [BEAM-14259] Clean up staticcheck warnings in the exec package (#17285) --- sdks/go/pkg/beam/core/runtime/exec/coder.go | 4 ++-- sdks/go/pkg/beam/core/runtime/exec/datasource.go | 2 +- sdks/go/pkg/beam/core/runtime/exec/dynsplit_test.go | 16 sdks/go/pkg/beam/core/runtime/exec/fn_test.go| 6 ++ sdks/go/pkg/beam/core/runtime/exec/fullvalue_test.go | 6 -- sdks/go/pkg/beam/core/runtime/exec/pardo.go | 2 +- sdks/go/pkg/beam/core/runtime/exec/pardo_test.go | 4 7 files changed, 14 insertions(+), 26 deletions(-) diff --git a/sdks/go/pkg/beam/core/runtime/exec/coder.go b/sdks/go/pkg/beam/core/runtime/exec/coder.go index 145209a492c..75cb1cca231 100644 --- a/sdks/go/pkg/beam/core/runtime/exec/coder.go +++ b/sdks/go/pkg/beam/core/runtime/exec/coder.go @@ -336,7 +336,7 @@ type boolDecoder struct{} func (*boolDecoder) DecodeTo(r io.Reader, fv *FullValue) error { // Encoding: false = 0, true = 1 - b := make([]byte, 1, 1) + b := make([]byte, 1) if err := ioutilx.ReadNBufUnsafe(r, b); err != nil { if err == io.EOF { return err @@ -1148,7 +1148,7 @@ func (d *intervalWindowDecoder) Decode(r io.Reader) ([]typex.Window, error) { n, err := coder.DecodeInt32(r) // #windows - ret := make([]typex.Window, n, n) + ret := make([]typex.Window, n) for i := int32(0); i < n; i++ { w, err := d.DecodeSingle(r) if err != nil { diff --git a/sdks/go/pkg/beam/core/runtime/exec/datasource.go b/sdks/go/pkg/beam/core/runtime/exec/datasource.go index 2e8f25d41d3..4b7ada9995a 100644 --- a/sdks/go/pkg/beam/core/runtime/exec/datasource.go +++ b/sdks/go/pkg/beam/core/runtime/exec/datasource.go @@ -62,7 +62,7 @@ func (n *DataSource) InitSplittable() { if n.Out == nil { return } - if u, ok := n.Out.(*ProcessSizedElementsAndRestrictions); ok == true { + if u, ok := n.Out.(*ProcessSizedElementsAndRestrictions); ok { n.su = u.SU } } diff --git a/sdks/go/pkg/beam/core/runtime/exec/dynsplit_test.go b/sdks/go/pkg/beam/core/runtime/exec/dynsplit_test.go index 2c87a3be29c..64355a84c1f 100644 --- a/sdks/go/pkg/beam/core/runtime/exec/dynsplit_test.go +++ b/sdks/go/pkg/beam/core/runtime/exec/dynsplit_test.go @@ -44,7 +44,7 @@ func TestDynamicSplit(t *testing.T) { name string // driver is a function determining how the processing and splitting // threads are created and coordinated. - driver func(*Plan, DataContext, *splitTestSdf) (error, splitResult) + driver func(*Plan, DataContext, *splitTestSdf) (splitResult, error) }{ { // Complete a split before beginning processing. @@ -81,7 +81,7 @@ func TestDynamicSplit(t *testing.T) { dc := DataContext{Data: &TestDataManager{R: pr}} // Call driver to coordinate processing & splitting threads. - procRes, splitRes := test.driver(plan, dc, sdf) + splitRes, procRes := test.driver(plan, dc, sdf) // Validate we get a valid split result, aside from split elements. if splitRes.err != nil { @@ -141,7 +141,7 @@ func TestDynamicSplit(t *testing.T) { // nonBlockingDriver performs a split before starting processing, so no thread // is forced to wait on a mutex. -func nonBlockingDriver(plan *Plan, dc DataContext, sdf *splitTestSdf) (procRes error, splitRes splitResult) { +func nonBlockingDriver(plan *Plan, dc DataContext, sdf *splitTestSdf) (splitRes splitResult, procRes error) { // Begin processing pipeline. procResCh := make(chan error) go processPlan(plan, dc, procResCh) @@ -161,12 +161,12 @@ func nonBlockingDriver(plan *Plan, dc DataContext, sdf *splitTestSdf) (procRes e <-rt.endClaim procRes = <-procResCh - return procRes, splitRes + return splitRes, procRes } // splitBlockingDriver blocks on a split request so that the SDF attempts to // claim while the split is occurring. -func splitBlockingDriver(plan *Plan, dc DataContext, sdf *splitTestSdf) (procRes error, splitRes splitResult) { +func splitBlockingDriver(plan *Plan, dc DataContext, sdf *splitTestSdf) (splitRes splitResult, procRes err
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new e08484791e3 Updating config from bot e08484791e3 is described below commit e08484791e36ecbb470556c98c786143286848db Author: github-actions AuthorDate: Wed Apr 6 17:36:15 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 46d0ee2da57 Updating config from bot 46d0ee2da57 is described below commit 46d0ee2da5707b8b738adb25f8e4cdd8723d5516 Author: github-actions AuthorDate: Wed Apr 6 18:04:50 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 831163ffd3f Updating config from bot 831163ffd3f is described below commit 831163ffd3f38837660fe115b56ea0d25f236955 Author: github-actions AuthorDate: Wed Apr 6 18:37:38 2022 + Updating config from bot
[beam] branch master updated (2a8a1ac0f2d -> 862f236c4ee)
This is an automated email from the ASF dual-hosted git repository. bhulette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git from 2a8a1ac0f2d [BEAM-14259] Clean up staticcheck warnings in the exec package (#17285) add 862f236c4ee Minor: Prefer registered schema in SQL docs (#17298) No new revisions were added by this update. Summary of changes: .../content/en/documentation/dsls/sql/walkthrough.md| 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-)
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 064f88856e5 Updating config from bot 064f88856e5 is described below commit 064f88856e58beae605958a44579aa8049d19a13 Author: github-actions AuthorDate: Wed Apr 6 19:04:23 2022 + Updating config from bot --- scripts/ci/pr-bot/state/pr-state/pr-17301.json | 10 ++ 1 file changed, 10 insertions(+) diff --git a/scripts/ci/pr-bot/state/pr-state/pr-17301.json b/scripts/ci/pr-bot/state/pr-state/pr-17301.json new file mode 100644 index 000..97c0bcb8849 --- /dev/null +++ b/scripts/ci/pr-bot/state/pr-state/pr-17301.json @@ -0,0 +1,10 @@ +{ + "commentedAboutFailingChecks": false, + "reviewersAssignedForLabels": { +"go": "youngoli" + }, + "nextAction": "Reviewers", + "stopReviewerNotifications": false, + "remindAfterTestsPass": [], + "committerAssigned": false +} \ No newline at end of file
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new a79a84d6be3 Updating config from bot a79a84d6be3 is described below commit a79a84d6be3f8f54c252f9def8fc317988e9a868 Author: github-actions AuthorDate: Wed Apr 6 19:04:28 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 003196ad83e Updating config from bot 003196ad83e is described below commit 003196ad83ea418b3c983b9f433223ba7ed3d887 Author: github-actions AuthorDate: Wed Apr 6 19:04:25 2022 + Updating config from bot --- scripts/ci/pr-bot/state/reviewers-for-label-go.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ci/pr-bot/state/reviewers-for-label-go.json b/scripts/ci/pr-bot/state/reviewers-for-label-go.json index 73c92f099e4..acb87c4f2f8 100644 --- a/scripts/ci/pr-bot/state/reviewers-for-label-go.json +++ b/scripts/ci/pr-bot/state/reviewers-for-label-go.json @@ -3,7 +3,7 @@ "dateOfLastReviewAssignment": { "lostluck": 1649099335060, "jrmccluskey": 1649084918234, -"youngoli": 1649099329583, +"youngoli": 1649271861723, "damccorm": 1649263365896, "riteshghorse": 1649185461994 }
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 5bf531f3b8f Updating config from bot 5bf531f3b8f is described below commit 5bf531f3b8f141b4322f8811ebf1614e9a8967b9 Author: github-actions AuthorDate: Wed Apr 6 19:33:30 2022 + Updating config from bot --- scripts/ci/pr-bot/state/pr-state/pr-17302.json | 10 ++ 1 file changed, 10 insertions(+) diff --git a/scripts/ci/pr-bot/state/pr-state/pr-17302.json b/scripts/ci/pr-bot/state/pr-state/pr-17302.json new file mode 100644 index 000..8ea94810368 --- /dev/null +++ b/scripts/ci/pr-bot/state/pr-state/pr-17302.json @@ -0,0 +1,10 @@ +{ + "commentedAboutFailingChecks": false, + "reviewersAssignedForLabels": { +"go": "lostluck" + }, + "nextAction": "Reviewers", + "stopReviewerNotifications": false, + "remindAfterTestsPass": [], + "committerAssigned": false +} \ No newline at end of file
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 03245333256 Updating config from bot 03245333256 is described below commit 032453332567239f504c3dece4ae42f21a77936d Author: github-actions AuthorDate: Wed Apr 6 19:33:35 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 42d747a587d Updating config from bot 42d747a587d is described below commit 42d747a587d8f87fa6be864296ac412aa1499ff8 Author: github-actions AuthorDate: Wed Apr 6 19:33:32 2022 + Updating config from bot --- scripts/ci/pr-bot/state/reviewers-for-label-go.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ci/pr-bot/state/reviewers-for-label-go.json b/scripts/ci/pr-bot/state/reviewers-for-label-go.json index acb87c4f2f8..6da8e161bdc 100644 --- a/scripts/ci/pr-bot/state/reviewers-for-label-go.json +++ b/scripts/ci/pr-bot/state/reviewers-for-label-go.json @@ -1,7 +1,7 @@ { "label": "go", "dateOfLastReviewAssignment": { -"lostluck": 1649099335060, +"lostluck": 1649273609426, "jrmccluskey": 1649084918234, "youngoli": 1649271861723, "damccorm": 1649263365896,
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 1eb70ea479f Updating config from bot 1eb70ea479f is described below commit 1eb70ea479fff7d8f9df1d43d1d9675525700065 Author: github-actions AuthorDate: Wed Apr 6 19:45:05 2022 + Updating config from bot --- scripts/ci/pr-bot/state/pr-state/pr-17304.json | 8 1 file changed, 8 insertions(+) diff --git a/scripts/ci/pr-bot/state/pr-state/pr-17304.json b/scripts/ci/pr-bot/state/pr-state/pr-17304.json new file mode 100644 index 000..9c2aa5aa212 --- /dev/null +++ b/scripts/ci/pr-bot/state/pr-state/pr-17304.json @@ -0,0 +1,8 @@ +{ + "commentedAboutFailingChecks": false, + "reviewersAssignedForLabels": {}, + "nextAction": "Author", + "stopReviewerNotifications": true, + "remindAfterTestsPass": [], + "committerAssigned": false +} \ No newline at end of file
[beam] branch master updated: [Playground] add meta tags (#17207)
This is an automated email from the ASF dual-hosted git repository. pabloem pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new 8a71bcbf82a [Playground] add meta tags (#17207) 8a71bcbf82a is described below commit 8a71bcbf82a58d003f3a9e7c27621d21cc1abe7c Author: Aydar Farrakhov AuthorDate: Wed Apr 6 22:54:13 2022 +0300 [Playground] add meta tags (#17207) * playground add meta tags * playground fix meta tags --- playground/frontend/web/index.html | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/playground/frontend/web/index.html b/playground/frontend/web/index.html index 41109b8a243..cb7ab505253 100644 --- a/playground/frontend/web/index.html +++ b/playground/frontend/web/index.html @@ -37,7 +37,9 @@ - + + https://fonts.googleapis.com";> @@ -59,7 +61,8 @@ textarea ~ grammarly-extension { display: none; } - + +
[beam] branch release-2.38.0 updated (47a9d8f3c42 -> 93ac2a0db02)
This is an automated email from the ASF dual-hosted git repository. danoliveira pushed a change to branch release-2.38.0 in repository https://gitbox.apache.org/repos/asf/beam.git from 47a9d8f3c42 Merge pull request #17241: [cherry-pick][release-2.38.0][BEAM-14179] Fix possibly null value add 49549098fd2 [BEAM-13519] Solve race issues when the server responds with an error before the GrpcStateClient finishes being constructed. (#17240) new 93ac2a0db02 Merge pull request #17295: [cherry-pick][release-2.38.0][BEAM-13519] Solve race issues when the server responds with an error before the GrpcStateClient finishes being constructed. (#17240) The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../harness/state/BeamFnStateGrpcClientCache.java | 105 ++--- .../state/BeamFnStateGrpcClientCacheTest.java | 81 +--- 2 files changed, 117 insertions(+), 69 deletions(-)
[beam] 01/01: Merge pull request #17295: [cherry-pick][release-2.38.0][BEAM-13519] Solve race issues when the server responds with an error before the GrpcStateClient finishes being constructed. (#172
This is an automated email from the ASF dual-hosted git repository. danoliveira pushed a commit to branch release-2.38.0 in repository https://gitbox.apache.org/repos/asf/beam.git commit 93ac2a0db020841c1b34736721adba731735cbca Merge: 47a9d8f3c42 49549098fd2 Author: Daniel Oliveira AuthorDate: Wed Apr 6 12:57:13 2022 -0700 Merge pull request #17295: [cherry-pick][release-2.38.0][BEAM-13519] Solve race issues when the server responds with an error before the GrpcStateClient finishes being constructed. (#17240) [cherry-pick][release-2.38.0][BEAM-13519] Solve race issues when the server responds with an error before the GrpcStateClient finishes being constructed. (#17240) .../harness/state/BeamFnStateGrpcClientCache.java | 105 ++--- .../state/BeamFnStateGrpcClientCacheTest.java | 81 +--- 2 files changed, 117 insertions(+), 69 deletions(-)
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 42cbad7e34a Updating config from bot 42cbad7e34a is described below commit 42cbad7e34aa235151a8fc0700fd9c18ebe85d39 Author: github-actions AuthorDate: Wed Apr 6 20:05:31 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 951a021226b Updating config from bot 951a021226b is described below commit 951a021226b93cfed0731520886874ebd23282cd Author: github-actions AuthorDate: Wed Apr 6 20:34:21 2022 + Updating config from bot
[beam] branch master updated (8a71bcbf82a -> 372978533e7)
This is an automated email from the ASF dual-hosted git repository. lostluck pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git from 8a71bcbf82a [Playground] add meta tags (#17207) add 372978533e7 fixes golint and deprecated issues in recent Go SDK import (#17304) No new revisions were added by this update. Summary of changes: sdks/go/pkg/beam/core/graph/coder/coder.go | 2 ++ sdks/go/pkg/beam/core/runtime/harness/worker_status.go | 1 + sdks/go/pkg/beam/core/runtime/harness/worker_status_test.go | 4 +++- sdks/go/pkg/beam/core/typex/special.go | 2 +- 4 files changed, 7 insertions(+), 2 deletions(-)
[beam] branch master updated (372978533e7 -> 48bdce3d764)
This is an automated email from the ASF dual-hosted git repository. ibzib pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git from 372978533e7 fixes golint and deprecated issues in recent Go SDK import (#17304) new 96f775fe4d1 [BEAM-14262] Update plugins for Dockerized Jenkins. new f1c4003301a Add ansicolor and ws-cleanup plugins. new 48bdce3d764 Merge pull request #17303 from ibzib/update-plugins The 35202 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .test-infra/dockerized-jenkins/plugins.txt | 121 + 1 file changed, 55 insertions(+), 66 deletions(-)
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 531bfbb97c6 Updating config from bot 531bfbb97c6 is described below commit 531bfbb97c67542c412f1e09c2dc702d74c51804 Author: github-actions AuthorDate: Wed Apr 6 21:04:53 2022 + Updating config from bot
[beam] branch master updated (48bdce3d764 -> f90379a67f9)
This is an automated email from the ASF dual-hosted git repository. lostluck pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/beam.git from 48bdce3d764 Merge pull request #17303 from ibzib/update-plugins add f90379a67f9 [BEAM-14266] Replace deprecated ptypes package uses (#17302) No new revisions were added by this update. Summary of changes: sdks/go/pkg/beam/core/runtime/graphx/translate.go | 10 +- sdks/go/pkg/beam/core/runtime/harness/logging.go | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-)
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 7f163f8d7d9 Updating config from bot 7f163f8d7d9 is described below commit 7f163f8d7d93c65cf4a19e932a4a4ed2abf5e7e9 Author: github-actions AuthorDate: Wed Apr 6 21:34:26 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new fad7e9fbd68 Updating config from bot fad7e9fbd68 is described below commit fad7e9fbd68e6b3d2c956d00fab066bed3a53f15 Author: github-actions AuthorDate: Wed Apr 6 22:04:42 2022 + Updating config from bot
[beam] branch asf-site updated: Publishing website 2022/04/06 22:15:27 at commit f90379a
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/asf-site by this push: new 2a83b631383 Publishing website 2022/04/06 22:15:27 at commit f90379a 2a83b631383 is described below commit 2a83b631383bc7fe7cacfc5340c904514a7d9e1b Author: jenkins AuthorDate: Wed Apr 6 22:15:28 2022 + Publishing website 2022/04/06 22:15:27 at commit f90379a --- .../documentation/dsls/sql/walkthrough/index.html| 12 +--- website/generated-content/sitemap.xml| 2 +- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/website/generated-content/documentation/dsls/sql/walkthrough/index.html b/website/generated-content/documentation/dsls/sql/walkthrough/index.html index a49a68786d9..dbba7175489 100644 --- a/website/generated-content/documentation/dsls/sql/walkthrough/index.html +++ b/website/generated-content/documentation/dsls/sql/walkthrough/index.html @@ -18,13 +18,11 @@ function addPlaceholder(){$('input:text').attr('placeholder',"What are you looking for?");} function endSearch(){var search=document.querySelector(".searchBar");search.classList.add("disappear");var icons=document.querySelector("#iconsBar");icons.classList.remove("disappear");} function blockScroll(){$("body").toggleClass("fixedPosition");} -function openMenu(){addPlaceholder();blockScroll();}LanguagesJavaJava SDK overvi [...] -be in Row format. A Row represents a single, immutable record in a Beam SQL -PCollection. The names and types of the fields/columns in the row are defined -by its associated https://beam.apache.org/releases/javadoc/2.37.0/index.html?org/apache/beam/sdk/schemas/Schema.html>Schema. -You can use the https://beam.apache.org/releases/javadoc/2.37.0/index.html?org/apache/beam/sdk/schemas/Schema.html>Schema.builder() to create -Schemas. See Data -Types for more details on supported primitive data types.A PCollectioncan be obtained multiple ways, for example:From in-memory data (typically for unit testing).Note: you have to explicitly specify the Row coder. In this example we’re doing it by calling Create.of(..):LanguagesJavaJava SDK overvi [...] +where T has a schema registered, or a PCollection
. See the +schema documentation in +the Beam Programming Guide for details on registering a schema for a type T.If you don’t have an existing type T, a PCollection
can be obtained +multiple ways, for example:From in-memory data (typically for unit testing).Note: you have to explicitly specify the Row coder. In this example we’re doing it by calling Create.of(..):Schema appSchema = Schema .builder() diff --git a/website/generated-content/sitemap.xml b/website/generated-content/sitemap.xml index cd49c6480fa..978a152f2e1 100644 --- a/website/generated-content/sitemap.xml +++ b/website/generated-content/sitemap.xml @@ -1 +1 @@ -http://www.sitemaps.org/schemas/sitemap/0.9"; xmlns:xhtml="http://www.w3.org/1999/xhtml";>/blog/beam-2.37.0/2022-03-04T10:14:02-08:00/categories/blog/2022-03-28T08:41:34-07:00/blog/2022-03-28T08:41:34-07:00/categories/2022-03-28T08:41:34-07:00/blog/u [...] \ No newline at end of file +http://www.sitemaps.org/schemas/sitemap/0.9"; xmlns:xhtml="http://www.w3.org/1999/xhtml";>/blog/beam-2.37.0/2022-03-04T10:14:02-08:00/categories/blog/2022-03-28T08:41:34-07:00/blog/2022-03-28T08:41:34-07:00/categories/2022-03-28T08:41:34-07:00/blog/u [...] \ No newline at end of file
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 16204c7381d Updating config from bot 16204c7381d is described below commit 16204c7381d34c089862839fc10b716bb138ab60 Author: github-actions AuthorDate: Wed Apr 6 22:35:42 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 6a494a0b41e Updating config from bot 6a494a0b41e is described below commit 6a494a0b41ef141eca9004193b5f633aa20b4c79 Author: github-actions AuthorDate: Wed Apr 6 23:04:53 2022 + Updating config from bot
[beam] branch master updated: [BEAM-11936] Fix rawtypes warnings in SnowflakeIO (#17257)
This is an automated email from the ASF dual-hosted git repository. bhulette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new a2391149eae [BEAM-11936] Fix rawtypes warnings in SnowflakeIO (#17257) a2391149eae is described below commit a2391149eaed5e3e7d86fd4f1f146ab9d6848e30 Author: Kamil Breguła AuthorDate: Thu Apr 7 01:15:15 2022 +0200 [BEAM-11936] Fix rawtypes warnings in SnowflakeIO (#17257) * [BEAM-10556] Fix rawtypes warnings in SnowflakeIO * fixup! [BEAM-10556] Fix rawtypes warnings in SnowflakeIO --- .../apache/beam/sdk/io/snowflake/SnowflakeIO.java | 167 ++--- .../crosslanguage/SnowflakeTransformRegistrar.java | 1 + .../io/snowflake/crosslanguage/WriteBuilder.java | 10 +- .../io/snowflake/data/SnowflakeTableSchema.java| 3 +- .../services/SnowflakeBatchServiceConfig.java | 2 +- .../services/SnowflakeBatchServiceImpl.java| 15 +- ...nowflakeService.java => SnowflakeServices.java} | 18 ++- ...lakeService.java => SnowflakeServicesImpl.java} | 15 +- .../services/SnowflakeStreamingServiceConfig.java | 2 +- .../services/SnowflakeStreamingServiceImpl.java| 5 +- .../test/FakeSnowflakeBatchServiceImpl.java| 5 +- .../snowflake/test/FakeSnowflakeServicesImpl.java} | 20 ++- .../test/FakeSnowflakeStreamingServiceImpl.java| 7 +- .../beam/sdk/io/snowflake/test/TestUtils.java | 34 ++--- .../test/unit/data/SnowflakeDataTypeValidTest.java | 5 +- .../test/unit/read/SnowflakeIOReadTest.java| 46 +++--- .../test/unit/write/CreateDispositionTest.java | 21 ++- .../unit/write/QueryDispositionLocationTest.java | 17 +-- .../test/unit/write/SchemaDispositionTest.java | 17 +-- .../test/unit/write/SnowflakeIOWriteTest.java | 23 ++- .../test/unit/write/StreamingWriteTest.java| 19 +-- 21 files changed, 217 insertions(+), 235 deletions(-) diff --git a/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java b/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java index 90bc9ee188b..44180bcd534 100644 --- a/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java +++ b/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java @@ -56,9 +56,9 @@ import org.apache.beam.sdk.io.snowflake.enums.StreamingLogLevel; import org.apache.beam.sdk.io.snowflake.enums.WriteDisposition; import org.apache.beam.sdk.io.snowflake.services.SnowflakeBatchServiceConfig; import org.apache.beam.sdk.io.snowflake.services.SnowflakeBatchServiceImpl; -import org.apache.beam.sdk.io.snowflake.services.SnowflakeService; +import org.apache.beam.sdk.io.snowflake.services.SnowflakeServices; +import org.apache.beam.sdk.io.snowflake.services.SnowflakeServicesImpl; import org.apache.beam.sdk.io.snowflake.services.SnowflakeStreamingServiceConfig; -import org.apache.beam.sdk.io.snowflake.services.SnowflakeStreamingServiceImpl; import org.apache.beam.sdk.options.ValueProvider; import org.apache.beam.sdk.transforms.Combine; import org.apache.beam.sdk.transforms.Create; @@ -83,8 +83,8 @@ import org.apache.beam.sdk.transforms.windowing.Repeatedly; import org.apache.beam.sdk.transforms.windowing.Window; import org.apache.beam.sdk.values.PBegin; import org.apache.beam.sdk.values.PCollection; -import org.apache.beam.sdk.values.PCollectionView; import org.apache.beam.sdk.values.PDone; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.annotations.VisibleForTesting; import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Joiner; import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Splitter; import org.joda.time.Duration; @@ -176,7 +176,6 @@ import org.slf4j.LoggerFactory; */ @Experimental @SuppressWarnings({ - "rawtypes", // TODO(https://issues.apache.org/jira/browse/BEAM-10556) "nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402) }) public class SnowflakeIO { @@ -192,14 +191,15 @@ public class SnowflakeIO { static final Duration DEFAULT_SLEEP_STREAMING_LOGS = Duration.standardSeconds(5000); /** - * Read data from Snowflake via COPY statement using user-defined {@link SnowflakeService}. + * Read data from Snowflake via COPY statement using user-defined {@link SnowflakeServices}. * - * @param snowflakeService user-defined {@link SnowflakeService} + * @param snowflakeServices user-defined {@link SnowflakeServices} * @param Type of the data to be read. */ - public static Read read(SnowflakeService snowflakeService) { + @VisibleForTesting + public static Read read(SnowflakeServices snowflakeServices) { return new AutoValue_SnowflakeIO_Read.Builder() -.setSnowflakeService(snowflakeService) +.setSnowflakeServices(snowflakeServices)
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 2b4dd2eedeb Updating config from bot 2b4dd2eedeb is described below commit 2b4dd2eedeb712253b7cfba8b47cc98d44c2453a Author: github-actions AuthorDate: Wed Apr 6 23:35:16 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new ff9112e6d22 Updating config from bot ff9112e6d22 is described below commit ff9112e6d22b473a9f3d3f9f2a0e77ede7fb6e9d Author: github-actions AuthorDate: Thu Apr 7 00:15:05 2022 + Updating config from bot
[beam] branch master updated: Merge pull request #17262: [BEAM-14244] Use the supplied output timestamp for processing time timers rather than the input watermark
This is an automated email from the ASF dual-hosted git repository. reuvenlax pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/master by this push: new e596abf7660 Merge pull request #17262: [BEAM-14244] Use the supplied output timestamp for processing time timers rather than the input watermark e596abf7660 is described below commit e596abf76606cb83cffbe5928119413374daa312 Author: Steven Niemitz AuthorDate: Wed Apr 6 20:30:00 2022 -0400 Merge pull request #17262: [BEAM-14244] Use the supplied output timestamp for processing time timers rather than the input watermark --- .../apache/beam/runners/core/SimpleDoFnRunner.java | 60 +++--- .../wrappers/streaming/DoFnOperator.java | 15 +- 2 files changed, 33 insertions(+), 42 deletions(-) diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java index 9a8ec278e8e..a73dd521f86 100644 --- a/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java +++ b/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java @@ -58,6 +58,7 @@ import org.apache.beam.sdk.values.PCollectionView; import org.apache.beam.sdk.values.Row; import org.apache.beam.sdk.values.TupleTag; import org.apache.beam.sdk.values.WindowingStrategy; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Preconditions; import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.FluentIterable; import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables; import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Sets; @@ -197,28 +198,10 @@ public class SimpleDoFnRunner implements DoFnRunner argumentProvider = -new OnTimerArgumentProvider<>( -timerId, key, window, timestamp, effectiveTimestamp, timeDomain); +new OnTimerArgumentProvider<>(timerId, key, window, timestamp, outputTimestamp, timeDomain); invoker.invokeOnTimer(timerId, timerFamilyId, argumentProvider); } @@ -1217,7 +1200,7 @@ public class SimpleDoFnRunner implements DoFnRunner implements DoFnRunner - * Ensures that: - * Users can't set {@code outputTimestamp} for processing time timers. - * Event time timers' {@code outputTimestamp} is set before window expiration. - * + * Ensures that a timer's {@code outputTimestamp} is set at or after the current input timestamp + * (minus allowed timestamp skew if set) and before the max timestamp of the window (plus + * allowed lateness). + * If the outputTimestamp is not set, it is defaulted to either: + * The firing timestamp for timers in the {@link TimeDomain#EVENT_TIME} + * The current element timestamp for other time domains. */ private void setAndVerifyOutputTimestamp() { if (outputTimestamp != null) { @@ -1261,7 +1243,7 @@ public class SimpleDoFnRunner implements DoFnRunner= Integer.MAX_VALUE @@ -1269,22 +1251,18 @@ public class SimpleDoFnRunner implements DoFnRunner checkArgument(namespace instanceof WindowNamespace); BoundedWindow window = ((WindowNamespace) namespace).getWindow(); timerInternals.onFiredOrDeletedTimer(timerData); +Instant effectiveOutputTimestamp; + +if (timerData.getDomain() == TimeDomain.EVENT_TIME) { + effectiveOutputTimestamp = timerData.getOutputTimestamp(); +} else { + // Flink does not set a watermark hold for the timer's output timestamp, and previous to + // https://github.com/apache/beam/pull/17262 processing time timers did not correctly emit + // elements at their output timestamp. In this case we need to continue doing the wrong thing + // and using the output watermark rather than the firing timestamp. Once flink correctly sets + // a watermark hold for the output timestamp, this should be changed back. + effectiveOutputTimestamp = timerInternals.currentOutputWatermarkTime(); +} + pushbackDoFnRunner.onTimer( timerData.getTimerId(), timerData.getTimerFamilyId(), keyedStateInternals.getKey(), window, timerData.getTimestamp(), -timerData.getOutputTimestamp(), +effectiveOutputTimestamp, timerData.getDomain()); }
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 18acbda4698 Updating config from bot 18acbda4698 is described below commit 18acbda469824257def9782b59cc7f28a7761651 Author: github-actions AuthorDate: Thu Apr 7 00:48:35 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 37312f4ef0f Updating config from bot 37312f4ef0f is described below commit 37312f4ef0fed82e476430ea8b32714a1bbe22f7 Author: github-actions AuthorDate: Thu Apr 7 01:32:01 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 854efb3d611 Updating config from bot 854efb3d611 is described below commit 854efb3d61151fa68fcdda61c02fd15b48499dd2 Author: github-actions AuthorDate: Thu Apr 7 02:32:00 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new eec5c996daa Updating config from bot eec5c996daa is described below commit eec5c996daa045823577d073cf7debd55f7583eb Author: github-actions AuthorDate: Thu Apr 7 03:20:09 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 7ee637d5a8b Updating config from bot 7ee637d5a8b is described below commit 7ee637d5a8bc60897b3ebabcf7db2183da662218 Author: github-actions AuthorDate: Thu Apr 7 03:40:49 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new e4611ff8b94 Updating config from bot e4611ff8b94 is described below commit e4611ff8b9448ec2b4a35bff4371335ced4ad1bb Author: github-actions AuthorDate: Thu Apr 7 04:04:43 2022 + Updating config from bot
[beam] branch nightly-refs/heads/master updated (9317462f73c -> e596abf7660)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch nightly-refs/heads/master in repository https://gitbox.apache.org/repos/asf/beam.git from 9317462f73c [BEAM-13829] Expose status API from Go SDK Harness (#16957) add 3f601400fc8 Avoid pr-bot state desync (#17299) add 2a8a1ac0f2d [BEAM-14259] Clean up staticcheck warnings in the exec package (#17285) add 862f236c4ee Minor: Prefer registered schema in SQL docs (#17298) add 8a71bcbf82a [Playground] add meta tags (#17207) add 372978533e7 fixes golint and deprecated issues in recent Go SDK import (#17304) add 96f775fe4d1 [BEAM-14262] Update plugins for Dockerized Jenkins. add f1c4003301a Add ansicolor and ws-cleanup plugins. add 48bdce3d764 Merge pull request #17303 from ibzib/update-plugins add f90379a67f9 [BEAM-14266] Replace deprecated ptypes package uses (#17302) add a2391149eae [BEAM-11936] Fix rawtypes warnings in SnowflakeIO (#17257) add e596abf7660 Merge pull request #17262: [BEAM-14244] Use the supplied output timestamp for processing time timers rather than the input watermark No new revisions were added by this update. Summary of changes: .test-infra/dockerized-jenkins/plugins.txt | 121 +++ playground/frontend/web/index.html | 10 +- .../apache/beam/runners/core/SimpleDoFnRunner.java | 60 +++- .../wrappers/streaming/DoFnOperator.java | 15 +- scripts/ci/pr-bot/processNewPrs.ts | 2 + scripts/ci/pr-bot/shared/persistentState.ts| 9 +- sdks/go/pkg/beam/core/graph/coder/coder.go | 2 + sdks/go/pkg/beam/core/runtime/exec/coder.go| 4 +- sdks/go/pkg/beam/core/runtime/exec/datasource.go | 2 +- .../go/pkg/beam/core/runtime/exec/dynsplit_test.go | 16 +- sdks/go/pkg/beam/core/runtime/exec/fn_test.go | 6 +- .../pkg/beam/core/runtime/exec/fullvalue_test.go | 6 - sdks/go/pkg/beam/core/runtime/exec/pardo.go| 2 +- sdks/go/pkg/beam/core/runtime/exec/pardo_test.go | 4 - sdks/go/pkg/beam/core/runtime/graphx/translate.go | 10 +- sdks/go/pkg/beam/core/runtime/harness/logging.go | 4 +- .../pkg/beam/core/runtime/harness/worker_status.go | 1 + .../core/runtime/harness/worker_status_test.go | 4 +- sdks/go/pkg/beam/core/typex/special.go | 2 +- .../apache/beam/sdk/io/snowflake/SnowflakeIO.java | 167 ++--- .../crosslanguage/SnowflakeTransformRegistrar.java | 1 + .../io/snowflake/crosslanguage/WriteBuilder.java | 10 +- .../io/snowflake/data/SnowflakeTableSchema.java| 3 +- .../services/SnowflakeBatchServiceConfig.java | 2 +- .../services/SnowflakeBatchServiceImpl.java| 15 +- .../{ServiceConfig.java => SnowflakeServices.java} | 25 ++- ...lakeService.java => SnowflakeServicesImpl.java} | 15 +- .../services/SnowflakeStreamingServiceConfig.java | 2 +- .../services/SnowflakeStreamingServiceImpl.java| 5 +- .../test/FakeSnowflakeBatchServiceImpl.java| 5 +- ...Manager.java => FakeSnowflakeServicesImpl.java} | 19 +-- .../test/FakeSnowflakeStreamingServiceImpl.java| 7 +- .../beam/sdk/io/snowflake/test/TestUtils.java | 34 ++--- .../test/unit/data/SnowflakeDataTypeValidTest.java | 5 +- .../test/unit/read/SnowflakeIOReadTest.java| 46 +++--- .../test/unit/write/CreateDispositionTest.java | 21 ++- .../unit/write/QueryDispositionLocationTest.java | 17 +-- .../test/unit/write/SchemaDispositionTest.java | 17 +-- .../test/unit/write/SnowflakeIOWriteTest.java | 23 ++- .../test/unit/write/StreamingWriteTest.java| 19 +-- .../en/documentation/dsls/sql/walkthrough.md | 17 +-- 41 files changed, 351 insertions(+), 404 deletions(-) rename sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/{ServiceConfig.java => SnowflakeServices.java} (58%) rename sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/{SnowflakeService.java => SnowflakeServicesImpl.java} (75%) copy sdks/java/io/snowflake/src/test/java/org/apache/beam/sdk/io/snowflake/test/{FakeSnowflakeIngestManager.java => FakeSnowflakeServicesImpl.java} (70%)
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new 49f714d2391 Updating config from bot 49f714d2391 is described below commit 49f714d2391d77bee332ccbfb350cbdf62a88e73 Author: github-actions AuthorDate: Thu Apr 7 04:39:53 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new f624a39407a Updating config from bot f624a39407a is described below commit f624a39407a4b1dfcbf9ce1f72b1a99bdb323752 Author: github-actions AuthorDate: Thu Apr 7 05:04:37 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new f8904204d37 Updating config from bot f8904204d37 is described below commit f8904204d37170f1ba1a804a4121ff59b04453cd Author: github-actions AuthorDate: Thu Apr 7 05:34:10 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new e80e6176302 Updating config from bot e80e6176302 is described below commit e80e61763024d7bdaf73e3c61b3b74b041488f9f Author: github-actions AuthorDate: Thu Apr 7 06:06:54 2022 + Updating config from bot
[beam] branch pr-bot-state updated: Updating config from bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch pr-bot-state in repository https://gitbox.apache.org/repos/asf/beam.git The following commit(s) were added to refs/heads/pr-bot-state by this push: new e1955c26a61 Updating config from bot e1955c26a61 is described below commit e1955c26a617033654f3ba18ea33c4c419b7ca49 Author: github-actions AuthorDate: Thu Apr 7 06:39:04 2022 + Updating config from bot