[jira] [Commented] (BEAM-3632) Table partioning in DynamicDestination is lost with project is not set in Table Destination

2018-02-06 Thread Blaquiere Guillaume (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354652#comment-16354652
 ] 

Blaquiere Guillaume commented on BEAM-3632:
---

Pull request: https://github.com/apache/beam/pull/4622

> Table partioning in DynamicDestination is lost with project is not set in 
> Table Destination
> ---
>
> Key: BEAM-3632
> URL: https://issues.apache.org/jira/browse/BEAM-3632
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-gcp
>Affects Versions: 2.2.0, 2.3.0
>Reporter: Blaquiere Guillaume
>Assignee: Chamikara Jayalath
>Priority: Major
>   Original Estimate: 10m
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the following class 
> https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/*WriteTables.java*
> line 140
> When the project is not set in table name, a new TableDestination is created 
> but all the time partitioning parameter is lost.
> Fix is very easy. Add a get time partitioning on the new creation:
>  tableDestination = new TableDestination(tableReference, 
> tableDestination.getTableDescription()*{color:#ff},tableDestination{color}**{color:#ff}.getTimePartitioning(){color}*);
>   
>  Should be enought :P



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (BEAM-3632) Table partioning in DynamicDestination is lost with project is not set in Table Destination

2018-02-06 Thread Blaquiere Guillaume (JIRA)

 [ 
https://issues.apache.org/jira/browse/BEAM-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blaquiere Guillaume updated BEAM-3632:
--
Description: 
In the following class 
https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/*WriteTables.java*

line 140

When the project is not set in table name, a new TableDestination is created 
but all the time partitioning parameter is lost.

Fix is very easy. Add a get time partitioning on the new creation:
 tableDestination = new TableDestination(tableReference, 
tableDestination.getTableDescription()*{color:#ff},tableDestination{color}**{color:#ff}.getTimePartitioning(){color}*);
  
 Should be enought :P

  was:
In the following class 
[beam|https://github.com/apache/beam]/[sdks|https://github.com/apache/beam/tree/master/sdks]/[java|https://github.com/apache/beam/tree/master/sdks/java]/[io|https://github.com/apache/beam/tree/master/sdks/java/io]/[google-cloud-platform|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform]/[src|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src]/[main|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main]/[java|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java]/[org|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org]/[apache|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache]/[beam|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam]/[sdk|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk]/[io|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io]/[gcp|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp]/[bigquery|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery]/*WriteTables.java*

line 140

When the project is not set in table name, a new TableDestination is created 
but all the time partitioning parameter is lost.

Fix is very easy. Add a get time partitioning on the new creation:
tableDestination = new TableDestination(tableReference, 
tableDestination.getTableDescription()*{color:#FF},tableDestination{color}**{color:#FF}.getTimePartitioning(){color}*);
 
Should be enought :P


> Table partioning in DynamicDestination is lost with project is not set in 
> Table Destination
> ---
>
> Key: BEAM-3632
> URL: https://issues.apache.org/jira/browse/BEAM-3632
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-gcp
>Affects Versions: 2.2.0, 2.3.0
>Reporter: Blaquiere Guillaume
>Assignee: Chamikara Jayalath
>Priority: Major
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> In the following class 
> https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/*WriteTables.java*
> line 140
> When the project is not set in table name, a new TableDestination is created 
> but all the time partitioning parameter is lost.
> Fix is very easy. Add a get time partitioning on the new creation:
>  tableDestination = new TableDestination(tableReference, 
> tableDestination.getTableDescription()*{color:#ff},tableDestination{color}**{color:#ff}.getTimePartitioning(){color}*);
>   
>  Should be enought :P



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (BEAM-3632) Table partioning in DynamicDestination is lost with project is not set in Table Destination

2018-02-06 Thread Blaquiere Guillaume (JIRA)
Blaquiere Guillaume created BEAM-3632:
-

 Summary: Table partioning in DynamicDestination is lost with 
project is not set in Table Destination
 Key: BEAM-3632
 URL: https://issues.apache.org/jira/browse/BEAM-3632
 Project: Beam
  Issue Type: Bug
  Components: sdk-java-gcp
Affects Versions: 2.2.0, 2.3.0
Reporter: Blaquiere Guillaume
Assignee: Chamikara Jayalath


In the following class 
[beam|https://github.com/apache/beam]/[sdks|https://github.com/apache/beam/tree/master/sdks]/[java|https://github.com/apache/beam/tree/master/sdks/java]/[io|https://github.com/apache/beam/tree/master/sdks/java/io]/[google-cloud-platform|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform]/[src|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src]/[main|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main]/[java|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java]/[org|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org]/[apache|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache]/[beam|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam]/[sdk|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk]/[io|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io]/[gcp|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp]/[bigquery|https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery]/*WriteTables.java*

line 140

When the project is not set in table name, a new TableDestination is created 
but all the time partitioning parameter is lost.

Fix is very easy. Add a get time partitioning on the new creation:
tableDestination = new TableDestination(tableReference, 
tableDestination.getTableDescription()*{color:#FF},tableDestination{color}**{color:#FF}.getTimePartitioning(){color}*);
 
Should be enought :P



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)