[jira] [Created] (BEAM-4422) 'gradlew check' build fails
Colm O hEigeartaigh created BEAM-4422: - Summary: 'gradlew check' build fails Key: BEAM-4422 URL: https://issues.apache.org/jira/browse/BEAM-4422 Project: Beam Issue Type: Task Components: build-system Reporter: Colm O hEigeartaigh Assignee: Luke Cwik The following fails for me with "./gradlew check": Execution failed for task ':beam-sdks-go:vet'. > Build failed due to return code 1 of: Command: /home/coheig/.gradle/go/binary/1.10/go/bin/go tool vet /home/coheig/src/apache/beam/sdks/go/test /home/coheig/src/apache/beam/sdks/go/pkg /home/coheig/src/apache/beam/sdks/go/data /home/coheig/src/apache/beam/sdks/go/cmd /home/coheig/src/apache/beam/sdks/go/build /home/coheig/src/apache/beam/sdks/go/examples /home/coheig/src/apache/beam/sdks/go/container Env: GOEXE= GOPATH=/home/coheig/src/apache/beam/sdks/go/.gogradle/project_gopath GOROOT=/home/coheig/.gradle/go/binary/1.10/go GOOS=linux GOARCH=amd64 [~herohde] provided more information on the mailing list: the error is "go vet" itself failing due to analyzing our dependencies under vendor: /Users/herohde/go/src/[github.com/apache/beam/sdks/go/test/vendor/github.com/coreos/etcd/tools/etcd-test-proxy/main.go:47|http://github.com/apache/beam/sdks/go/test/vendor/github.com/coreos/etcd/tools/etcd-test-proxy/main.go:47]: Fprintln arg list ends with redundant newline /Users/herohde/go/src/[github.com/apache/beam/sdks/go/test/vendor/github.com/dgrijalva/jwt-go/errors.go:54|http://github.com/apache/beam/sdks/go/test/vendor/github.com/dgrijalva/jwt-go/errors.go:54]: unreachable code /Users/herohde/go/src/[github.com/apache/beam/sdks/go/test/vendor/github.com/ghodss/yaml/yaml.go:276|http://github.com/apache/beam/sdks/go/test/vendor/github.com/ghodss/yaml/yaml.go:276]: unreachable code [...] Not sure whether this is something we can fix in our configuration or whether it's rather a bug in the gogradle plugin. Given that there are no go vet problems in our code, we'd want that check to pass. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-4086) KafkaIO is flaky with gradle build
[ https://issues.apache.org/jira/browse/BEAM-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439218#comment-16439218 ] Colm O hEigeartaigh commented on BEAM-4086: --- I've also noticed it hanging with maven intermittently on my machine, so I think the problem is not with gradle. > KafkaIO is flaky with gradle build > -- > > Key: BEAM-4086 > URL: https://issues.apache.org/jira/browse/BEAM-4086 > Project: Beam > Issue Type: Sub-task > Components: io-java-kafka >Affects Versions: 2.5.0 >Reporter: Ismaël Mejía >Priority: Major > > Noticed this while trying to do a simple change in KafkaIO this morning and > corroborated with other contributors. If you run `./gradlew -p > sdks/java/io/kafka/ clean build` it blocks indefinitely at least 1/3 of the > times. However it passes ok with Maven. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-3946) Python SDK tests are failing if no GOOGLE_APPLICATION_CREDENTIALS was set
[
https://issues.apache.org/jira/browse/BEAM-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426712#comment-16426712
]
Colm O hEigeartaigh commented on BEAM-3946:
---
I can confirm the issue is fixed - thanks!
> Python SDK tests are failing if no GOOGLE_APPLICATION_CREDENTIALS was set
> -
>
> Key: BEAM-3946
> URL: https://issues.apache.org/jira/browse/BEAM-3946
> Project: Beam
> Issue Type: Bug
> Components: examples-python
>Reporter: Alexey Romanenko
>Assignee: Mark Liu
>Priority: Major
> Fix For: Not applicable
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Running locally mvn clean install fails on following Apache Beam :: SDKs ::
> Python tests:
> {{ERROR: test_message_matcher_mismatch
> (apache_beam.io.gcp.tests.pubsub_matcher_test.PubSubMatcherTest)}}
> {{ERROR: test_message_matcher_success
> (apache_beam.io.gcp.tests.pubsub_matcher_test.PubSubMatcherTest)}}
> {{ERROR: test_message_metcher_timeout
> (apache_beam.io.gcp.tests.pubsub_matcher_test.PubSubMatcherTest)}}
>
> with an error:
> DefaultCredentialsError: Could not automatically determine credentials.
> Please set GOOGLE_APPLICATION_CREDENTIALS or
> explicitly create credential and re-run the application. For more
> information, please see
>
> [https://developers.google.com/accounts/docs/application-default-credentials].
> >> begin captured logging <<
> google.auth.transport._http_client: DEBUG: Making request: GET
> [http://169.254.169.254|http://169.254.169.254/]
> google.auth.compute_engine._metadata: INFO: Compute Engine Metadata server
> unavailable.
> - >> end captured logging << -
>
> It looks like it's a regression and it was caused by this commit:
> [301853647f2c726c04c5bdb02cab6ff6b39f09d0|https://github.com/apache/beam/commit/301853647f2c726c04c5bdb02cab6ff6b39f09d0]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (BEAM-3946) Python SDK tests are failing if no GOOGLE_APPLICATION_CREDENTIALS was set
[
https://issues.apache.org/jira/browse/BEAM-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425498#comment-16425498
]
Colm O hEigeartaigh commented on BEAM-3946:
---
Would it be possible to revert the original commit until further investigation
is complete? The master build is broken for me for over a week now.
> Python SDK tests are failing if no GOOGLE_APPLICATION_CREDENTIALS was set
> -
>
> Key: BEAM-3946
> URL: https://issues.apache.org/jira/browse/BEAM-3946
> Project: Beam
> Issue Type: Bug
> Components: examples-python
>Reporter: Alexey Romanenko
>Assignee: Mark Liu
>Priority: Major
>
> Running locally mvn clean install fails on following Apache Beam :: SDKs ::
> Python tests:
> {{ERROR: test_message_matcher_mismatch
> (apache_beam.io.gcp.tests.pubsub_matcher_test.PubSubMatcherTest)}}
> {{ERROR: test_message_matcher_success
> (apache_beam.io.gcp.tests.pubsub_matcher_test.PubSubMatcherTest)}}
> {{ERROR: test_message_metcher_timeout
> (apache_beam.io.gcp.tests.pubsub_matcher_test.PubSubMatcherTest)}}
>
> with an error:
> DefaultCredentialsError: Could not automatically determine credentials.
> Please set GOOGLE_APPLICATION_CREDENTIALS or
> explicitly create credential and re-run the application. For more
> information, please see
>
> [https://developers.google.com/accounts/docs/application-default-credentials].
> >> begin captured logging <<
> google.auth.transport._http_client: DEBUG: Making request: GET
> [http://169.254.169.254|http://169.254.169.254/]
> google.auth.compute_engine._metadata: INFO: Compute Engine Metadata server
> unavailable.
> - >> end captured logging << -
>
> It looks like it's a regression and it was caused by this commit:
> [301853647f2c726c04c5bdb02cab6ff6b39f09d0|https://github.com/apache/beam/commit/301853647f2c726c04c5bdb02cab6ff6b39f09d0]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (BEAM-3575) Update contribution guidelines to add the option of cloning from a fork
[ https://issues.apache.org/jira/browse/BEAM-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh closed BEAM-3575. - > Update contribution guidelines to add the option of cloning from a fork > --- > > Key: BEAM-3575 > URL: https://issues.apache.org/jira/browse/BEAM-3575 > Project: Beam > Issue Type: Improvement > Components: website >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Major > Fix For: 2.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The contribution guidelines currently show how to clone Beam from the GitHub > read-only mirror and then to add the user's own GitHub repo as a remote. > However, it's also possible (and common) to fork the repo manually and then > to clone the forked repository and work with the original repo as a remote. > We should update the contribution guidelines to show this as an alternative. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (BEAM-3575) Update contribution guidelines to add the option of cloning from a fork
[ https://issues.apache.org/jira/browse/BEAM-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh resolved BEAM-3575. --- Resolution: Won't Fix Fix Version/s: 2.4.0 Marking as "Won't fix" due to comments on PR. > Update contribution guidelines to add the option of cloning from a fork > --- > > Key: BEAM-3575 > URL: https://issues.apache.org/jira/browse/BEAM-3575 > Project: Beam > Issue Type: Improvement > Components: website >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Major > Fix For: 2.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The contribution guidelines currently show how to clone Beam from the GitHub > read-only mirror and then to add the user's own GitHub repo as a remote. > However, it's also possible (and common) to fork the repo manually and then > to clone the forked repository and work with the original repo as a remote. > We should update the contribution guidelines to show this as an alternative. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (BEAM-3624) Remove collapsible if statements
Colm O hEigeartaigh created BEAM-3624: - Summary: Remove collapsible if statements Key: BEAM-3624 URL: https://issues.apache.org/jira/browse/BEAM-3624 Project: Beam Issue Type: Improvement Components: sdk-java-core Reporter: Colm O hEigeartaigh Assignee: Colm O hEigeartaigh Fix For: 2.4.0 There are a few instances in the code where we could collapse if statements to make the code more concise. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (BEAM-3618) Remove extraneous "return" statement
Colm O hEigeartaigh created BEAM-3618: - Summary: Remove extraneous "return" statement Key: BEAM-3618 URL: https://issues.apache.org/jira/browse/BEAM-3618 Project: Beam Issue Type: Improvement Components: testing Reporter: Colm O hEigeartaigh Assignee: Colm O hEigeartaigh Fix For: 2.4.0 There is an extraneous "return" statement in one of the tests that could be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (BEAM-3593) Remove methods that just call super()
Colm O hEigeartaigh created BEAM-3593: - Summary: Remove methods that just call super() Key: BEAM-3593 URL: https://issues.apache.org/jira/browse/BEAM-3593 Project: Beam Issue Type: Improvement Components: beam-model Reporter: Colm O hEigeartaigh Assignee: Colm O hEigeartaigh Fix For: 2.4.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (BEAM-3575) Update contribution guidelines to add the option of cloning from a fork
Colm O hEigeartaigh created BEAM-3575: - Summary: Update contribution guidelines to add the option of cloning from a fork Key: BEAM-3575 URL: https://issues.apache.org/jira/browse/BEAM-3575 Project: Beam Issue Type: Improvement Components: website Reporter: Colm O hEigeartaigh Assignee: Colm O hEigeartaigh The contribution guidelines currently show how to clone Beam from the GitHub read-only mirror and then to add the user's own GitHub repo as a remote. However, it's also possible (and common) to fork the repo manually and then to clone the forked repository and work with the original repo as a remote. We should update the contribution guidelines to show this as an alternative. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (BEAM-3560) Switch to use BigInteger/BigDecimal.ZERO/ONE/TEN
Colm O hEigeartaigh created BEAM-3560: - Summary: Switch to use BigInteger/BigDecimal.ZERO/ONE/TEN Key: BEAM-3560 URL: https://issues.apache.org/jira/browse/BEAM-3560 Project: Beam Issue Type: Improvement Components: beam-model Reporter: Colm O hEigeartaigh Assignee: Colm O hEigeartaigh Currently there are some instances of "new BigInteger/BigDecimal(0)" (or 1 or 10) in the code. Instead it's better to use BigInteger.ZERO etc. to avoid creating new objects that are not required. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (BEAM-3533) Replace hard-coded UTF-8 Strings
Colm O hEigeartaigh created BEAM-3533: - Summary: Replace hard-coded UTF-8 Strings Key: BEAM-3533 URL: https://issues.apache.org/jira/browse/BEAM-3533 Project: Beam Issue Type: Improvement Components: beam-model Reporter: Colm O hEigeartaigh Assignee: Kenneth Knowles Fix For: 2.3.0 This task is to replace hard-coded UTF-8 Strings in the code with StandardCharsets.UTF_8 instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
