[jira] [Assigned] (BEAM-419) Non-transient non-serializable instance field in CombineFnUtil$NonSerializableBoundedKeyedCombineFn
[ https://issues.apache.org/jira/browse/BEAM-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-419: Assignee: (was: Neelesh Srinivas Salian) > Non-transient non-serializable instance field in > CombineFnUtil$NonSerializableBoundedKeyedCombineFn > --- > > Key: BEAM-419 > URL: https://issues.apache.org/jira/browse/BEAM-419 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > SE_BAD_FIELD|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L363]: > Non-transient non-serializable instance field in serializable class > Applies to: > [CombineFnUtil$NonSerializableBoundedKeyedCombineFn.context|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CombineFnUtil.java#L170]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-409) Incorrect use of Math.ceil in ApproximateQuantiles
[ https://issues.apache.org/jira/browse/BEAM-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-409: Assignee: (was: Neelesh Srinivas Salian) > Incorrect use of Math.ceil in ApproximateQuantiles > -- > > Key: BEAM-409 > URL: https://issues.apache.org/jira/browse/BEAM-409 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L274]: > Integral value cast to double and then passed to Math.ceil > Applies to: > [ApproximateQuanitles|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L349]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-407) Inconsistent synchronization in OffsetRangeTracker.copy
[ https://issues.apache.org/jira/browse/BEAM-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-407: Assignee: (was: Neelesh Srinivas Salian) > Inconsistent synchronization in OffsetRangeTracker.copy > --- > > Key: BEAM-407 > URL: https://issues.apache.org/jira/browse/BEAM-407 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > IS2_INCONSISTENT_SYNC|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L148]: > Inconsistent synchronization > Applies to: > [OffsetRangeTracker.copy|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/OffsetRangeTracker.java#L263]. > Its mutating methods are all marked synchronized otherwise. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-410) ApproximateQuantiles$QuantileBuffer defines compareTo but not equals
[ https://issues.apache.org/jira/browse/BEAM-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-410: Assignee: (was: Neelesh Srinivas Salian) > ApproximateQuantiles$QuantileBuffer defines compareTo but not equals > > > Key: BEAM-410 > URL: https://issues.apache.org/jira/browse/BEAM-410 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > EQ_COMPARETO_USE_OBJECT_EQUALS|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L280]: > Class defines compareTo(...) and uses Object.equals() > Applies to: > [ApproximateQuanitles$QuantileBuffer|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L627]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-400) Direct/InProcess runner should use Pubsub publish time timestamp if timestampLabel is not set
[ https://issues.apache.org/jira/browse/BEAM-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-400: Assignee: (was: Neelesh Srinivas Salian) > Direct/InProcess runner should use Pubsub publish time timestamp if > timestampLabel is not set > - > > Key: BEAM-400 > URL: https://issues.apache.org/jira/browse/BEAM-400 > Project: Beam > Issue Type: Bug > Components: sdk-java-gcp >Reporter: Daniel Mills >Priority: Minor > Labels: newbie, starter > > When using system-provided timestamps for PubsubIO, the timestamp should be > the time at which the message was published to Pubsub, not when it was > received by the pipeline. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-420) Non-transient non-serializable instance field in WatermarkHold
[ https://issues.apache.org/jira/browse/BEAM-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-420: Assignee: (was: Neelesh Srinivas Salian) > Non-transient non-serializable instance field in WatermarkHold > -- > > Key: BEAM-420 > URL: https://issues.apache.org/jira/browse/BEAM-420 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > SE_BAD_FIELD|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L477]: > Non-transient non-serializable instance field in serializable class > Applies to: > [WatermarkHold.timerInternals|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/runners/core-java/src/main/java/org/apache/beam/sdk/util/WatermarkHold.java#L81]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-421) StateTags$CombiningValueStateTag inherits equals from super class but without incorporating its state
[ https://issues.apache.org/jira/browse/BEAM-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-421: Assignee: (was: Neelesh Srinivas Salian) > StateTags$CombiningValueStateTag inherits equals from super class but without > incorporating its state > - > > Key: BEAM-421 > URL: https://issues.apache.org/jira/browse/BEAM-421 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > EQ_DOESNT_OVERRIDE_EQUALS|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L555]: > Class doesn't override equals in superclass > Applies to: > [StateTags$CombiningValueStateTag|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateTags.java#L344]. > CombiningValueStateTag inherits its equals implementation from its parent > class, KeyedCombiningValueStateTag. CombiningValueStateTag has additional > fields which are not included in the equality implementation, which may be > incorrect. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-526) Mismatched pipelines give unclear error
[ https://issues.apache.org/jira/browse/BEAM-526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-526: Assignee: (was: Neelesh Srinivas Salian) > Mismatched pipelines give unclear error > --- > > Key: BEAM-526 > URL: https://issues.apache.org/jira/browse/BEAM-526 > Project: Beam > Issue Type: Bug > Components: sdk-py >Reporter: Ahmet Altay >Priority: Minor > Labels: starter > > Mistakenly mixing two pipeline gives an unclear error. This is an error, > however we should improve the error message. > This could be reproduced by trying to flatten two things from different > pipelines. > Improve the message for this assert: > https://github.com/aaltay/incubator-beam/blob/python-sdk/sdks/python/apache_beam/transforms/util.py#L135 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-659) WindowFn#isCompatible should provide a meaningful reason
[
https://issues.apache.org/jira/browse/BEAM-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neelesh Srinivas Salian reassigned BEAM-659:
Assignee: (was: Neelesh Srinivas Salian)
> WindowFn#isCompatible should provide a meaningful reason
>
>
> Key: BEAM-659
> URL: https://issues.apache.org/jira/browse/BEAM-659
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
>Reporter: Kenneth Knowles
>Priority: Minor
> Labels: easy, easyfix, starter
>
> {{WindowFn#isCompatible(...)}} returns a true/false answer without any
> explanation of why; it suffers from a form of [boolean
> blindness|https://existentialtype.wordpress.com/2011/03/15/boolean-blindness/].
> We alleviated this for {{Coder#isDeterministic()}} by switching to
> {{Coder#verifyDeterministic()}} which can raise an exception describing why
> it is not deterministic (it could just as easily have been a return value).
> We should do the same for {{WindowFn#isCompatible(...)}}.
> See here:
> http://stackoverflow.com/questions/39617897/inputs-to-flatten-had-incompatible-window-windowfns-when-cogroupbykey-with-calen
> (a decent {{toString}} would go a long way, for immediate and trivial
> improvement)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (BEAM-1129) Umbrella JIRA for Fixing Findbugs
[ https://issues.apache.org/jira/browse/BEAM-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-1129: - Assignee: (was: Neelesh Srinivas Salian) > Umbrella JIRA for Fixing Findbugs > - > > Key: BEAM-1129 > URL: https://issues.apache.org/jira/browse/BEAM-1129 > Project: Beam > Issue Type: Bug > Components: project-management >Reporter: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-454) Validate Pubsub Topic exists when reading
[ https://issues.apache.org/jira/browse/BEAM-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-454: Assignee: (was: Neelesh Srinivas Salian) > Validate Pubsub Topic exists when reading > - > > Key: BEAM-454 > URL: https://issues.apache.org/jira/browse/BEAM-454 > Project: Beam > Issue Type: Improvement > Components: sdk-java-gcp >Reporter: Frances Perry >Priority: Minor > Labels: newbie, starter > > When reading from Pubsub, we should validate the pubsub topic exists at graph > construction time (similar to the way we validate a BQ dataset and table > exist). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (BEAM-1105) Adding Beam's pico Wordcount to the existing examples.
[ https://issues.apache.org/jira/browse/BEAM-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963215#comment-15963215 ] Neelesh Srinivas Salian edited comment on BEAM-1105 at 4/10/17 5:18 PM: Not working on it. Feel free to grab [~altay] was (Author: nssalian): Feel free to grab [~altay] > Adding Beam's pico Wordcount to the existing examples. > --- > > Key: BEAM-1105 > URL: https://issues.apache.org/jira/browse/BEAM-1105 > Project: Beam > Issue Type: Wish > Components: examples-java >Reporter: Neelesh Srinivas Salian >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: examples > > http://www.jesse-anderson.com/2016/12/beams-pico-wordcount/ > Is a good explanation for the WordCount that would encourage users. > Adding this to the examples and subsequently the docs is a good step to help > new users start from a good foundation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-1105) Adding Beam's pico Wordcount to the existing examples.
[ https://issues.apache.org/jira/browse/BEAM-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963215#comment-15963215 ] Neelesh Srinivas Salian commented on BEAM-1105: --- Feel free to grab [~altay] > Adding Beam's pico Wordcount to the existing examples. > --- > > Key: BEAM-1105 > URL: https://issues.apache.org/jira/browse/BEAM-1105 > Project: Beam > Issue Type: Wish > Components: examples-java >Reporter: Neelesh Srinivas Salian >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: examples > > http://www.jesse-anderson.com/2016/12/beams-pico-wordcount/ > Is a good explanation for the WordCount that would encourage users. > Adding this to the examples and subsequently the docs is a good step to help > new users start from a good foundation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (BEAM-526) Mismatched pipelines give unclear error
[ https://issues.apache.org/jira/browse/BEAM-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959452#comment-15959452 ] Neelesh Srinivas Salian commented on BEAM-526: -- Hi [~altay], apologies for the delay. I'll write it up this weekend if that's alright. > Mismatched pipelines give unclear error > --- > > Key: BEAM-526 > URL: https://issues.apache.org/jira/browse/BEAM-526 > Project: Beam > Issue Type: Bug > Components: sdk-py >Reporter: Ahmet Altay >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: starter > > Mistakenly mixing two pipeline gives an unclear error. This is an error, > however we should improve the error message. > This could be reproduced by trying to flatten two things from different > pipelines. > Improve the message for this assert: > https://github.com/aaltay/incubator-beam/blob/python-sdk/sdks/python/apache_beam/transforms/util.py#L135 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (BEAM-1664) Support Kafka0.8.x client in KafkaIO
[ https://issues.apache.org/jira/browse/BEAM-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian updated BEAM-1664: -- Summary: Support Kafka0.8.x client in KafkaIO (was: Support Kafka0.8.x client in KakaIO) > Support Kafka0.8.x client in KafkaIO > - > > Key: BEAM-1664 > URL: https://issues.apache.org/jira/browse/BEAM-1664 > Project: Beam > Issue Type: Improvement > Components: sdk-java-extensions >Reporter: JiJun Tang >Assignee: Davor Bonaci > > Kafka-0.8 is not supported yet, these's a big change from 0.8 to 0.9. So we > need to create a specific KafkaIO moudle for 0.8. After complete this > moudle,we will consider to extract common code to kafkaio-common moudle. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-301) Add a Beam SQL DSL
[
https://issues.apache.org/jira/browse/BEAM-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neelesh Srinivas Salian reassigned BEAM-301:
Assignee: Xu Mingmin (was: Neelesh Srinivas Salian)
> Add a Beam SQL DSL
> --
>
> Key: BEAM-301
> URL: https://issues.apache.org/jira/browse/BEAM-301
> Project: Beam
> Issue Type: New Feature
> Components: sdk-ideas
>Reporter: Jean-Baptiste Onofré
>Assignee: Xu Mingmin
>
> The SQL DSL helps developers to build a Beam pipeline from SQL statement in
> String directly.
> In Phase I, it starts to support INSERT/SELECT queries with FILTERs, one
> example SQL as below:
> {code}
> INSERT INTO `SUB_USEREVENT` (`SITEID`, `PAGEID`, `PAGENAME`, `EVENTTIMESTAMP`)
> (SELECT STREAM `USEREVENT`.`SITEID`, `USEREVENT`.`PAGEID`,
> `USEREVENT`.`PAGENAME`, `USEREVENT`.`EVENTTIMESTAMP`
> FROM `USEREVENT` AS `USEREVENT`
> WHERE `USEREVENT`.`SITEID` > 10)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (BEAM-1078) Modifying the links in JavaDocs to point to the Beam github repo rather than GCP
[ https://issues.apache.org/jira/browse/BEAM-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-1078: - Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Modifying the links in JavaDocs to point to the Beam github repo rather than > GCP > - > > Key: BEAM-1078 > URL: https://issues.apache.org/jira/browse/BEAM-1078 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core >Reporter: Neelesh Srinivas Salian >Assignee: Neelesh Srinivas Salian > Fix For: Not applicable > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-421) StateTags$CombiningValueStateTag inherits equals from super class but without incorporating its state
[ https://issues.apache.org/jira/browse/BEAM-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-421: Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > StateTags$CombiningValueStateTag inherits equals from super class but without > incorporating its state > - > > Key: BEAM-421 > URL: https://issues.apache.org/jira/browse/BEAM-421 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > EQ_DOESNT_OVERRIDE_EQUALS|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L555]: > Class doesn't override equals in superclass > Applies to: > [StateTags$CombiningValueStateTag|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateTags.java#L344]. > CombiningValueStateTag inherits its equals implementation from its parent > class, KeyedCombiningValueStateTag. CombiningValueStateTag has additional > fields which are not included in the equality implementation, which may be > incorrect. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-526) Mismatched pipelines give unclear error
[ https://issues.apache.org/jira/browse/BEAM-526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-526: Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Mismatched pipelines give unclear error > --- > > Key: BEAM-526 > URL: https://issues.apache.org/jira/browse/BEAM-526 > Project: Beam > Issue Type: Bug > Components: sdk-py >Reporter: Ahmet Altay >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: starter > > Mistakenly mixing two pipeline gives an unclear error. This is an error, > however we should improve the error message. > This could be reproduced by trying to flatten two things from different > pipelines. > Improve the message for this assert: > https://github.com/aaltay/incubator-beam/blob/python-sdk/sdks/python/apache_beam/transforms/util.py#L135 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-659) WindowFn#isCompatible should provide a meaningful reason
[
https://issues.apache.org/jira/browse/BEAM-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neelesh Srinivas Salian reassigned BEAM-659:
Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian)
> WindowFn#isCompatible should provide a meaningful reason
>
>
> Key: BEAM-659
> URL: https://issues.apache.org/jira/browse/BEAM-659
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
>Reporter: Kenneth Knowles
>Assignee: Neelesh Srinivas Salian
>Priority: Minor
> Labels: easy, easyfix, starter
>
> {{WindowFn#isCompatible(...)}} returns a true/false answer without any
> explanation of why; it suffers from a form of [boolean
> blindness|https://existentialtype.wordpress.com/2011/03/15/boolean-blindness/].
> We alleviated this for {{Coder#isDeterministic()}} by switching to
> {{Coder#verifyDeterministic()}} which can raise an exception describing why
> it is not deterministic (it could just as easily have been a return value).
> We should do the same for {{WindowFn#isCompatible(...)}}.
> See here:
> http://stackoverflow.com/questions/39617897/inputs-to-flatten-had-incompatible-window-windowfns-when-cogroupbykey-with-calen
> (a decent {{toString}} would go a long way, for immediate and trivial
> improvement)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (BEAM-1129) Umbrella JIRA for Fixing Findbugs
[ https://issues.apache.org/jira/browse/BEAM-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-1129: - Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Umbrella JIRA for Fixing Findbugs > - > > Key: BEAM-1129 > URL: https://issues.apache.org/jira/browse/BEAM-1129 > Project: Beam > Issue Type: Bug > Components: project-management >Reporter: Neelesh Srinivas Salian >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-454) Validate Pubsub Topic exists when reading
[ https://issues.apache.org/jira/browse/BEAM-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-454: Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Validate Pubsub Topic exists when reading > - > > Key: BEAM-454 > URL: https://issues.apache.org/jira/browse/BEAM-454 > Project: Beam > Issue Type: Improvement > Components: sdk-java-gcp >Reporter: Frances Perry >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: newbie, starter > > When reading from Pubsub, we should validate the pubsub topic exists at graph > construction time (similar to the way we validate a BQ dataset and table > exist). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-1083) Deleting the Weblink for the DatastoreWordCount based on BEAM-498
[ https://issues.apache.org/jira/browse/BEAM-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-1083: - Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Deleting the Weblink for the DatastoreWordCount based on BEAM-498 > - > > Key: BEAM-1083 > URL: https://issues.apache.org/jira/browse/BEAM-1083 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-gcp >Reporter: Neelesh Srinivas Salian >Assignee: Neelesh Srinivas Salian >Priority: Minor > Fix For: Not applicable > > > Since BEAM-498 removes the DatastoreWordCount, it makes sense to remove the > GCP link from the README as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-1105) Adding Beam's pico Wordcount to the existing examples.
[ https://issues.apache.org/jira/browse/BEAM-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-1105: - Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Adding Beam's pico Wordcount to the existing examples. > --- > > Key: BEAM-1105 > URL: https://issues.apache.org/jira/browse/BEAM-1105 > Project: Beam > Issue Type: Wish > Components: examples-java >Reporter: Neelesh Srinivas Salian >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: examples > > http://www.jesse-anderson.com/2016/12/beams-pico-wordcount/ > Is a good explanation for the WordCount that would encourage users. > Adding this to the examples and subsequently the docs is a good step to help > new users start from a good foundation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-651) Add public TypedPValue.setTypeDescriptor
[ https://issues.apache.org/jira/browse/BEAM-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-651: Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Add public TypedPValue.setTypeDescriptor > > > Key: BEAM-651 > URL: https://issues.apache.org/jira/browse/BEAM-651 > Project: Beam > Issue Type: New Feature > Components: sdk-java-core >Reporter: Kenneth Knowles >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: easy, easyfix, starter > Fix For: 0.4.0 > > > This would give fairly pithy answers to StackOverflow questions sometimes. > When choosing between .getOutputCoder() and .getOutputTypeDescriptor() for a > transform/DoFn we often choose the type, so the coder registry can do its > thing. > This would also give a similar choice between .setCoder(...) and > .setTypeDescriptor(...). > And anyhow we have the intention of removing our practice of the "*Internal" > suffix, so this one might be most easily solved by making it public. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-420) Non-transient non-serializable instance field in WatermarkHold
[ https://issues.apache.org/jira/browse/BEAM-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-420: Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Non-transient non-serializable instance field in WatermarkHold > -- > > Key: BEAM-420 > URL: https://issues.apache.org/jira/browse/BEAM-420 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > SE_BAD_FIELD|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L477]: > Non-transient non-serializable instance field in serializable class > Applies to: > [WatermarkHold.timerInternals|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/runners/core-java/src/main/java/org/apache/beam/sdk/util/WatermarkHold.java#L81]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-410) ApproximateQuantiles$QuantileBuffer defines compareTo but not equals
[ https://issues.apache.org/jira/browse/BEAM-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-410: Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > ApproximateQuantiles$QuantileBuffer defines compareTo but not equals > > > Key: BEAM-410 > URL: https://issues.apache.org/jira/browse/BEAM-410 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > EQ_COMPARETO_USE_OBJECT_EQUALS|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L280]: > Class defines compareTo(...) and uses Object.equals() > Applies to: > [ApproximateQuanitles$QuantileBuffer|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L627]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-400) Direct/InProcess runner should use Pubsub publish time timestamp if timestampLabel is not set
[ https://issues.apache.org/jira/browse/BEAM-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-400: Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Direct/InProcess runner should use Pubsub publish time timestamp if > timestampLabel is not set > - > > Key: BEAM-400 > URL: https://issues.apache.org/jira/browse/BEAM-400 > Project: Beam > Issue Type: Bug > Components: sdk-java-gcp >Reporter: Daniel Mills >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: newbie, starter > > When using system-provided timestamps for PubsubIO, the timestamp should be > the time at which the message was published to Pubsub, not when it was > received by the pipeline. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-409) Incorrect use of Math.ceil in ApproximateQuantiles
[ https://issues.apache.org/jira/browse/BEAM-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-409: Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Incorrect use of Math.ceil in ApproximateQuantiles > -- > > Key: BEAM-409 > URL: https://issues.apache.org/jira/browse/BEAM-409 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L274]: > Integral value cast to double and then passed to Math.ceil > Applies to: > [ApproximateQuanitles|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L349]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-419) Non-transient non-serializable instance field in CombineFnUtil$NonSerializableBoundedKeyedCombineFn
[ https://issues.apache.org/jira/browse/BEAM-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-419: Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Non-transient non-serializable instance field in > CombineFnUtil$NonSerializableBoundedKeyedCombineFn > --- > > Key: BEAM-419 > URL: https://issues.apache.org/jira/browse/BEAM-419 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Scott Wegner >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs > SE_BAD_FIELD|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L363]: > Non-transient non-serializable instance field in serializable class > Applies to: > [CombineFnUtil$NonSerializableBoundedKeyedCombineFn.context|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CombineFnUtil.java#L170]. > This is a good starter bug. When fixing, please remove the corresponding > entries from > [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] > and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-239) Rename RemoveDuplicates to Distinct
[ https://issues.apache.org/jira/browse/BEAM-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-239: Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Rename RemoveDuplicates to Distinct > --- > > Key: BEAM-239 > URL: https://issues.apache.org/jira/browse/BEAM-239 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core >Reporter: Jesse Anderson >Assignee: Neelesh Srinivas Salian >Priority: Minor > Labels: backward-incompatible, newbie, starter > Fix For: 0.4.0 > > > I had a really tough time finding this transform in the docs. I suggest > changing this class' name to Distinct instead of RemoveDuplicates. At the > very least, the JavaDoc for RemoveDuplicates should have the word distinct in > it to make this more findable/searchable. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-879) Renaming DeDupExample to DistinctExample
[ https://issues.apache.org/jira/browse/BEAM-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-879: Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Renaming DeDupExample to DistinctExample > > > Key: BEAM-879 > URL: https://issues.apache.org/jira/browse/BEAM-879 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-core >Reporter: Neelesh Srinivas Salian >Assignee: Neelesh Srinivas Salian >Priority: Trivial > Fix For: 0.4.0 > > > In BEAM-239, we renamed DeDupExampleTest to DistinctExampleTest. > Need to modify DeDupExample to DistinctExample as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (BEAM-29) Bound Instant values used as timestamps at TIMESTAMP_MIN_VALUE and TIMESTAMP_MAX_VALUE
[ https://issues.apache.org/jira/browse/BEAM-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neelesh Srinivas Salian reassigned BEAM-29: --- Assignee: Neelesh Srinivas Salian (was: Neelesh Srinivas Salian) > Bound Instant values used as timestamps at TIMESTAMP_MIN_VALUE and > TIMESTAMP_MAX_VALUE > -- > > Key: BEAM-29 > URL: https://issues.apache.org/jira/browse/BEAM-29 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Kenneth Knowles >Assignee: Neelesh Srinivas Salian >Priority: Minor > > Today the Java SDK allows arbitrary Instant values. If large magnitude > Instant values reach a runner with greater precision but the same modulus for > its representation, overflow will occur. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
