[GitHub] beam pull request #4095: [BEAM-3156] Fix BigTableIO to use non-deprecated Fu...
GitHub user rniemo-g opened a pull request: https://github.com/apache/beam/pull/4095 [BEAM-3156] Fix BigTableIO to use non-deprecated Futures.addCallback function Follow this checklist to help us incorporate your contribution quickly and easily: - [ x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ x] Each commit in the pull request should have a meaningful subject line and body. - [ x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue. - [x ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). Jira issue: https://issues.apache.org/jira/browse/BEAM-3156 This PR changes which Futures.addCallback() overload we call. This is because the overload we're using is being deprecated. --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/rniemo-g/beam master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/4095.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4095 commit 961bd22d1ae4f7a9b4dc87e7b3c30a26ce1878cd Author: Ryan Niemocienski Date: 2017-10-31T20:56:15Z Fix BigTableIO to use non-deprecated Futures.addCallback function ---
[GitHub] beam pull request #3933: [BEAM-1936] Add ability to provide function to extr...
Github user rniemo-g closed the pull request at: https://github.com/apache/beam/pull/3933 ---
[GitHub] beam pull request #3933: [BEAM-1936] Add ability to provide function to extr...
GitHub user rniemo-g opened a pull request: https://github.com/apache/beam/pull/3933 [BEAM-1936] Add ability to provide function to extract timestamp from payload in ⦠What: This pull request adds the ability to extract timestamps from Pubsub message bodies. Why: Currently an attribute name containing timestamps can be provided, but in the case where message publisher isn't controlled by the user, correct windowing requires a way to pull timestamps from the message payload. How: Instead of passing a timestamp attribute (String) through PubsubIO -> PubsubClient, this has been generalized to a PubsubTimestampExtractor which is instantiated 3 ways: 1) empty constructor. This means the default publish time is used as the message timestamp 2) with a String timestamp attribute name. This works the same as the current approach. 3) with a Function extractor. This function extractor takes in the message payload as a string, and returns the parsed timestamp. In the case the returned timestamp isn't a timestamp, an exception is thrown saying the timestamp cannot be interpreted (same behavior as when a timestamp attribute can't be interpreted as a timestamp) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rniemo-g/beam pubsub-timestamp-extraction Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/3933.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3933 commit 611b81b360ecce8e2955bbd4e77d02bf84e8ec30 Author: Ryan Niemocienski Date: 2017-10-02T19:09:01Z Add ability to provide function to extract timestamp from payload in PubsubIO ---
