[GitHub] [beam] pabloem commented on issue #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource

2020-03-23 Thread GitBox
pabloem commented on issue #11040: [BEAM-9305] Allow value provider query 
strings in _CustomBigQuerySource
URL: https://github.com/apache/beam/pull/11040#issuecomment-602847544
 
 
   Thanks @EDjur for the contribution! Thanks @kamilwu for reviewing


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [beam] pabloem commented on issue #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource

2020-03-11 Thread GitBox
pabloem commented on issue #11040: [BEAM-9305] Allow value provider query 
strings in _CustomBigQuerySource
URL: https://github.com/apache/beam/pull/11040#issuecomment-597930882
 
 
   ah good catch. Yes, that would make it a bug..


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [beam] pabloem commented on issue #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource

2020-03-11 Thread GitBox
pabloem commented on issue #11040: [BEAM-9305] Allow value provider query 
strings in _CustomBigQuerySource
URL: https://github.com/apache/beam/pull/11040#issuecomment-597869174
 
 
   I'm srry @EDjur - the `expand` method runs at template construction, so the 
change currently will not work with parameters provided at execution time. 
You'd need to call `get` on the valueprovider in estimate_size/split/etc like 
we had discussed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services