[GitHub] beam pull request #2836: [BEAM-1316] Remove the usage of mock from ptransfor...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/2836


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2836: [BEAM-1316] Remove the usage of mock from ptransfor...

[sb2nov]

GitHub user sb2nov opened a pull request:

https://github.com/apache/beam/pull/2836

[BEAM-1316] Remove the usage of mock from ptransform tests

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`.
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf).

---

Mock patch creates problems if we try to pickle the DoFn so remove it and 
clean up the tests

R: @aaltay PTAL

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sb2nov/beam BEAM-1316-improve-ptransform-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2836.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2836


commit 0eeb33bd1c41d1fe19ca71ce2b54485a9d7b717a
Author: Sourabh Bajaj 
Date:   2017-05-02T18:48:19Z

[BEAM-1316] Remove the usage of mock from ptransform tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---