[GitHub] beam pull request #3568: [BEAM-2612] Variance builtin aggregation functions

2017-08-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/3568


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] beam pull request #3568: [BEAM-2612] Variance builtin aggregation functions

2017-08-28 Thread vectorijk
GitHub user vectorijk reopened a pull request:

https://github.com/apache/beam/pull/3568

[BEAM-2612] Variance builtin aggregation functions

implement var_pop, var_samp builtin aggregation functions


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vectorijk/beam beam-2612-variance

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/3568.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3568


commit 8fbb9006dd479b42a0798fe1c1eaf0e509649bc2
Author: Kai Jiang 
Date:   2017-08-16T23:13:26Z

var_pop and var_samp

two builtin aggregation functions

commit 53612b5f9e256248212c5d743ea5410a8eeffd5f
Author: Kai Jiang 
Date:   2017-08-17T00:26:04Z

fix checkstyle

commit 1256f63b2686c0e7d1d0c2a5863945cff9c79fea
Author: Kai Jiang 
Date:   2017-08-28T20:06:36Z

address comments

change type of sum in class VarAgg to BigDecimal
move isSamp field to Var
rename VarPop -> Var to make more generic
move logic to prepareOutput() both for Avg and Var
set MathContext to handle potential exception with BigDecimal divide.

commit 27b84cb4702e9d8960d1bfc5b59e48d8e5f446dd
Author: Kai Jiang 
Date:   2017-08-28T20:13:38Z

newlines

commit 7db3f490aeeb34f01b9064e274feacacbfa67092
Author: Kai Jiang 
Date:   2017-08-28T20:18:09Z

Merge branch 'DSL_SQL' into beam-2612-variance

commit fb0b05c163f6de2760c13af05abd9b41d9b57de9
Author: Kai Jiang 
Date:   2017-08-28T23:36:47Z

rebase issue




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] beam pull request #3568: [BEAM-2612] Variance builtin aggregation functions

2017-08-28 Thread vectorijk
Github user vectorijk closed the pull request at:

https://github.com/apache/beam/pull/3568


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] beam pull request #3568: [BEAM-2612] variance builtin aggregation functions

2017-07-16 Thread vectorijk
GitHub user vectorijk opened a pull request:

https://github.com/apache/beam/pull/3568

[BEAM-2612] variance builtin aggregation functions

implement var_pop, var_samp builtin aggregation functions


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vectorijk/beam beam-2612-variance

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/3568.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3568


commit ff9cb47f6ac03cdbf2aed233f0c6045b719bf643
Author: Kai Jiang 
Date:   2017-07-16T10:25:32Z

var_pop, var_samp builtin aggreagtion functions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---