[GitHub] beam pull request #3956: Restore Python precommit; enable phrase triggering ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/3956


---

[GitHub] beam pull request #3956: Restore Python precommit; enable phrase triggering ...

[kennknowles]

GitHub user kennknowles opened a pull request:

https://github.com/apache/beam/pull/3956

Restore Python precommit; enable phrase triggering for precommits in general

Follow this checklist to help us incorporate your contribution quickly and 
easily:

 - [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
 - [ ] Each commit in the pull request should have a meaningful subject 
line and body.
 - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue.
 - [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
 - [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
 - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

---

R: @jasonkuster 
CC: @herohde you can do it for Go
CC: @pabloem there was a little issue, JFYI this should keep the feature 
you added. LMK if it breaks

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kennknowles/beam python-precommit

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/3956.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3956


commit 7db65c56fc9dc18fe88a540235971d8633aafe55
Author: Kenneth Knowles 
Date:   2017-10-06T21:14:29Z

Allow precommits to coexist with phrase triggering

commit 8c1547f900a179d26b8dce57ad96d15c87793331
Author: Kenneth Knowles 
Date:   2017-10-06T21:14:43Z

Restore Python precommit

commit cbdf75ae1877d9616cad34a213c4ac16c0d1e369
Author: Kenneth Knowles 
Date:   2017-10-06T21:17:28Z

Enable phrase triggering of Java PreCommit

commit 7de4d769e73045fb59cd16a9ad366c1772aa764c
Author: Kenneth Knowles 
Date:   2017-10-06T21:19:43Z

Enable phrase triggering of Go PreCommit




---