[GitHub] beam pull request #3962: [BEAM-3028] Fixes a bug in DatastoreIO query splitt...

2017-10-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/3962


---


[GitHub] beam pull request #3962: [Beam-3028] Fixes a bug in DatastoreIO query splitt...

2017-10-08 Thread chamikaramj
GitHub user chamikaramj opened a pull request:

https://github.com/apache/beam/pull/3962

[Beam-3028] Fixes a bug in DatastoreIO query splitting.

We were returning original query instead of the sub-queries resulting in 
data duplication when reading.

Follow this checklist to help us incorporate your contribution quickly and 
easily:

 - [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
 - [ ] Each commit in the pull request should have a meaningful subject 
line and body.
 - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue.
 - [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
 - [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
 - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chamikaramj/beam query_splitting

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/3962.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3962


commit 636b56964b750fba025c42e260219b60b085a868
Author: chamik...@google.com 
Date:   2017-10-09T00:02:43Z

Fixes a bug in query splitting.

We were returning original query instead of the sub-queries resulting in 
data duplication when reading.




---