[GitHub] beam pull request #3968: Only fail nightly release at end, for more detailed...

2017-10-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/3968


---


[GitHub] beam pull request #3968: Only fail nightly release at end, for more detailed...

2017-10-09 Thread kennknowles
GitHub user kennknowles opened a pull request:

https://github.com/apache/beam/pull/3968

Only fail nightly release at end, for more detailed signal

Follow this checklist to help us incorporate your contribution quickly and 
easily:

 - [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
 - [x] Each commit in the pull request should have a meaningful subject 
line and body.
 - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue.
 - [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
 - [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
 - [x] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

---

R: @aviemzur (since you mentioned how broken things are, sending things to 
you)

I think the nightly build - misnamed, since it isn't night for everyone - 
should gather all the failures. It hit a flake in some IO and then we lost any 
other signal.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kennknowles/beam nightly-fail-at-end

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/3968.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3968


commit 15b0e47b1e35dbcfd1149379bad6e7170552ec0f
Author: Kenneth Knowles 
Date:   2017-10-10T03:16:24Z

Only fail nightly release at end, for more detailed signal




---