[jira] [Commented] (BEAM-1379) Shade Guava in beam-sdks-java-io-kafka module

2017-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850032#comment-15850032
 ] 

ASF GitHub Bot commented on BEAM-1379:
--

GitHub user aviemzur opened a pull request:

https://github.com/apache/beam/pull/1906

[BEAM-1379] Shade Guava in beam-sdks-java-io-kafka module

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aviemzur/incubator-beam 
shade-guava-in-kafka-module

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/1906.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1906


commit dc56829f7c73fc283ca53bcd82bbf69da4552909
Author: Aviem Zur 
Date:   2017-02-02T15:08:27Z

[BEAM-1379] Shade Guava in beam-sdks-java-io-kafka module




> Shade Guava in beam-sdks-java-io-kafka module
> -
>
> Key: BEAM-1379
> URL: https://issues.apache.org/jira/browse/BEAM-1379
> Project: Beam
>  Issue Type: Task
>  Components: sdk-java-extensions
>Reporter: Aviem Zur
>Assignee: Davor Bonaci
>
> Shade Guava in Kafka IO module to avoid collisions with Guava versions 
> supplied in different clusters.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1379) Shade Guava in beam-sdks-java-io-kafka module

2017-02-02 Thread Aviem Zur (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850030#comment-15850030
 ] 

Aviem Zur commented on BEAM-1379:
-

Kafka IO is commonly used in clusters which may have a different version of 
Guava.

I myself had my application crash in a Spark cluster due to KafkaIO not having 
its guava dependency shaded.
While it is true that users can shade their applications themselves it might be 
too much to expect them to go through this process, figure out that they have a 
transient dependency on a different version of guava then shade it.

> Shade Guava in beam-sdks-java-io-kafka module
> -
>
> Key: BEAM-1379
> URL: https://issues.apache.org/jira/browse/BEAM-1379
> Project: Beam
>  Issue Type: Task
>  Components: sdk-java-extensions
>Reporter: Aviem Zur
>Assignee: Davor Bonaci
>
> Shade Guava in Kafka IO module to avoid collisions with Guava versions 
> supplied in different clusters.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)